Skip to content

Conversation

@gavinchou
Copy link
Contributor

pick #53341

@gavinchou gavinchou requested a review from morrySnow as a code owner August 1, 2025 08:55
@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@gavinchou gavinchou changed the title [chore](cloud) Optimize RPC log for meta-service [chore](cloud) Optimize RPC log Aug 1, 2025
@gavinchou gavinchou changed the title [chore](cloud) Optimize RPC log [chore](cloud) Optimize RPC log #53341 Aug 1, 2025
@gavinchou
Copy link
Contributor Author

run buildall

@hello-stephen
Copy link
Contributor

Cloud UT Coverage Report

Increment line coverage 92.06% (58/63) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 81.10% (1210/1492)
Line Coverage 65.29% (21335/32678)
Region Coverage 66.74% (10718/16059)
Branch Coverage 56.46% (5645/9998)

@doris-robot
Copy link

TPC-H: Total hot run time: 32258 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 0705db93110d189201b1bcdb9cee6bc46cca80ee, data reload: false

------ Round 1 ----------------------------------
q1	17596	5460	5378	5378
q2	2060	271	161	161
q3	10499	1228	737	737
q4	10259	871	443	443
q5	8678	2341	2073	2073
q6	185	165	132	132
q7	903	739	616	616
q8	9318	1419	1131	1131
q9	5256	4849	4921	4849
q10	6778	2279	1802	1802
q11	503	276	253	253
q12	328	357	208	208
q13	17773	3600	3016	3016
q14	226	223	205	205
q15	533	466	460	460
q16	414	420	372	372
q17	593	856	363	363
q18	6760	6455	6310	6310
q19	1219	949	562	562
q20	331	358	207	207
q21	3076	2159	1978	1978
q22	1035	1023	1002	1002
Total cold run time: 104323 ms
Total hot run time: 32258 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5513	5462	5463	5462
q2	234	337	237	237
q3	2252	2657	2313	2313
q4	1350	1806	1342	1342
q5	4429	4875	4971	4875
q6	165	163	128	128
q7	2046	1925	1820	1820
q8	2686	2791	2695	2695
q9	7218	7139	7219	7139
q10	3025	3300	2815	2815
q11	568	506	486	486
q12	654	740	602	602
q13	3407	3736	3175	3175
q14	290	281	280	280
q15	500	469	474	469
q16	432	534	454	454
q17	1203	1703	1262	1262
q18	7532	7364	7313	7313
q19	810	1188	1024	1024
q20	1982	2131	1892	1892
q21	5281	4927	4714	4714
q22	1108	1068	983	983
Total cold run time: 52685 ms
Total hot run time: 51480 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 196932 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 0705db93110d189201b1bcdb9cee6bc46cca80ee, data reload: false

query1	1267	963	923	923
query2	6235	2051	1957	1957
query3	10972	4525	4544	4525
query4	33226	23829	23387	23387
query5	3718	630	488	488
query6	278	183	169	169
query7	3985	496	324	324
query8	293	245	219	219
query9	9460	2567	2580	2567
query10	483	327	270	270
query11	18007	15238	15242	15238
query12	167	107	103	103
query13	1563	566	414	414
query14	8881	7774	7245	7245
query15	238	196	188	188
query16	8136	651	471	471
query17	1619	769	598	598
query18	2117	421	324	324
query19	226	191	160	160
query20	126	118	113	113
query21	210	135	109	109
query22	4576	4722	4319	4319
query23	34458	33868	34060	33868
query24	7354	2699	2766	2699
query25	539	487	449	449
query26	800	283	173	173
query27	2183	471	365	365
query28	5377	2194	2202	2194
query29	708	598	463	463
query30	241	189	169	169
query31	1013	919	853	853
query32	93	61	60	60
query33	518	355	315	315
query34	762	874	524	524
query35	800	800	724	724
query36	1023	1069	983	983
query37	109	98	68	68
query38	4000	4002	3976	3976
query39	1530	1478	1483	1478
query40	204	116	102	102
query41	51	47	48	47
query42	117	107	109	107
query43	517	524	492	492
query44	1325	872	831	831
query45	189	178	172	172
query46	890	1057	681	681
query47	1955	1940	1908	1908
query48	407	434	336	336
query49	731	512	403	403
query50	687	709	439	439
query51	7513	7296	7239	7239
query52	97	107	95	95
query53	235	260	192	192
query54	549	579	471	471
query55	82	79	84	79
query56	272	265	257	257
query57	1246	1253	1208	1208
query58	247	222	225	222
query59	3137	3177	3091	3091
query60	290	294	264	264
query61	123	121	112	112
query62	804	772	690	690
query63	241	196	205	196
query64	3782	997	660	660
query65	3328	3254	3310	3254
query66	793	410	320	320
query67	16374	15802	15535	15535
query68	6912	842	554	554
query69	500	301	266	266
query70	1178	1120	1092	1092
query71	392	307	270	270
query72	5733	3772	3617	3617
query73	642	750	362	362
query74	10566	9404	8978	8978
query75	3210	3139	2666	2666
query76	3095	1185	768	768
query77	461	363	282	282
query78	10317	10452	9623	9623
query79	4100	840	602	602
query80	804	536	437	437
query81	511	260	220	220
query82	712	125	88	88
query83	164	159	145	145
query84	245	100	76	76
query85	791	366	298	298
query86	400	314	273	273
query87	4253	4331	4262	4262
query88	5180	2394	2386	2386
query89	426	338	294	294
query90	1760	190	196	190
query91	135	142	114	114
query92	70	56	61	56
query93	2748	909	539	539
query94	703	417	295	295
query95	348	287	270	270
query96	495	619	283	283
query97	3206	3275	3241	3241
query98	231	216	195	195
query99	1573	1423	1315	1315
Total cold run time: 295338 ms
Total hot run time: 196932 ms

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 0.00% (0/20) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 45.42% (12637/27822)
Line Coverage 36.26% (112623/310624)
Region Coverage 35.31% (58217/164893)
Branch Coverage 32.50% (31663/97414)

@doris-robot
Copy link

ClickBench: Total hot run time: 28.22 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 0705db93110d189201b1bcdb9cee6bc46cca80ee, data reload: false

query1	0.04	0.03	0.02
query2	0.08	0.03	0.03
query3	0.24	0.07	0.07
query4	1.62	0.11	0.11
query5	0.54	0.53	0.51
query6	1.14	0.74	0.72
query7	0.02	0.02	0.02
query8	0.05	0.04	0.03
query9	0.58	0.51	0.50
query10	0.55	0.55	0.55
query11	0.14	0.11	0.11
query12	0.14	0.11	0.11
query13	0.61	0.60	0.60
query14	0.77	0.78	0.80
query15	0.83	0.83	0.82
query16	0.39	0.37	0.42
query17	1.02	1.05	1.06
query18	0.24	0.22	0.22
query19	1.86	1.86	1.80
query20	0.02	0.02	0.01
query21	15.38	0.98	0.59
query22	0.73	0.80	0.62
query23	15.13	1.52	0.54
query24	3.04	1.45	0.31
query25	0.20	0.14	0.10
query26	0.30	0.14	0.14
query27	0.05	0.04	0.04
query28	12.83	1.02	0.43
query29	12.60	3.88	3.25
query30	0.25	0.10	0.07
query31	2.82	0.59	0.38
query32	3.23	0.54	0.45
query33	2.97	3.00	3.02
query34	16.63	5.16	4.55
query35	4.53	4.53	4.56
query36	0.62	0.50	0.48
query37	0.09	0.06	0.07
query38	0.06	0.04	0.04
query39	0.03	0.03	0.02
query40	0.16	0.13	0.13
query41	0.07	0.02	0.02
query42	0.04	0.02	0.02
query43	0.04	0.02	0.03
Total cold run time: 102.68 s
Total hot run time: 28.22 s

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 40.00% (8/20) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 76.18% (20942/27489)
Line Coverage 69.59% (216029/310416)
Region Coverage 67.62% (129308/191230)
Branch Coverage 61.16% (67239/109938)

@morrySnow morrySnow changed the title [chore](cloud) Optimize RPC log #53341 branch-3.1: [chore](cloud) Optimize RPC log #53341 Aug 4, 2025
@morrySnow morrySnow merged commit b7809eb into apache:branch-3.1 Aug 4, 2025
24 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants