Skip to content

branch-3.1: [fix](function) Fix functionbuilder check #54255#54339

Merged
morrySnow merged 1 commit intobranch-3.1from
auto-pick-54255-branch-3.1
Aug 5, 2025
Merged

branch-3.1: [fix](function) Fix functionbuilder check #54255#54339
morrySnow merged 1 commit intobranch-3.1from
auto-pick-54255-branch-3.1

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Aug 5, 2025

Cherry-picked from #54255

@dwdwqfwe
[fix](function) Fix functionbuilder check (#54255)
e31bf99 
### What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

### Release note

None

### Check List (For Author)

- Test <!-- At least one of them must be included. -->
    - [ ] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [ ] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

### Check List (For Reviewer who merge this PR)

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
@github-actions github-actions bot requested a review from morrySnow as a code owner August 5, 2025 08:33
@Thearas
Copy link
Contributor

Thearas commented Aug 5, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring closed this Aug 5, 2025
@dataroaring dataroaring reopened this Aug 5, 2025
@Thearas
Copy link
Contributor

Thearas commented Aug 5, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Aug 5, 2025

TPC-H: Total hot run time: 32748 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit e31bf99b6de6c7c59895aeda18c2c89c81cdfa8f, data reload: false

------ Round 1 ----------------------------------
q1	17631	5857	5490	5490
q2	2059	273	163	163
q3	10510	1237	776	776
q4	10301	867	453	453
q5	9461	2330	2141	2141
q6	189	162	129	129
q7	907	743	604	604
q8	9323	1472	1209	1209
q9	5301	4888	4951	4888
q10	6773	2267	1809	1809
q11	477	283	268	268
q12	335	357	212	212
q13	17800	3648	3048	3048
q14	229	232	206	206
q15	524	460	491	460
q16	425	435	377	377
q17	607	865	353	353
q18	6756	6381	6429	6381
q19	1206	964	546	546
q20	334	349	205	205
q21	3039	2229	2045	2045
q22	1056	1013	985	985
Total cold run time: 105243 ms
Total hot run time: 32748 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5614	5535	5534	5534
q2	240	332	242	242
q3	2253	2651	2292	2292
q4	1411	1923	1398	1398
q5	4427	4923	5004	4923
q6	179	166	130	130
q7	2047	2007	1803	1803
q8	2634	2862	2682	2682
q9	7236	7209	7232	7209
q10	3027	3290	2672	2672
q11	561	500	506	500
q12	675	762	654	654
q13	3440	3785	3163	3163
q14	286	305	268	268
q15	515	480	459	459
q16	440	492	428	428
q17	1262	1722	1259	1259
q18	7590	7571	7410	7410
q19	881	1214	1075	1075
q20	1991	2055	1884	1884
q21	5473	4900	4519	4519
q22	1077	1042	1010	1010
Total cold run time: 53259 ms
Total hot run time: 51514 ms

@doris-robot
Copy link

doris-robot commented Aug 5, 2025

TPC-DS: Total hot run time: 197379 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit e31bf99b6de6c7c59895aeda18c2c89c81cdfa8f, data reload: false

query1	1316	953	940	940
query2	6254	1970	1895	1895
query3	10976	4380	4474	4380
query4	32723	24029	23503	23503
query5	3860	634	478	478
query6	275	208	207	207
query7	4005	523	329	329
query8	310	251	241	241
query9	9503	2611	2564	2564
query10	480	323	259	259
query11	18053	15448	15326	15326
query12	164	108	103	103
query13	1555	556	438	438
query14	9735	7028	7303	7028
query15	226	202	192	192
query16	7293	665	488	488
query17	1605	776	579	579
query18	1959	387	304	304
query19	214	192	164	164
query20	121	117	115	115
query21	202	132	108	108
query22	4600	4511	4405	4405
query23	35013	34089	34116	34089
query24	7557	2739	2745	2739
query25	513	495	431	431
query26	804	288	175	175
query27	2203	508	349	349
query28	5177	2222	2217	2217
query29	660	594	492	492
query30	257	194	162	162
query31	1009	934	849	849
query32	79	61	60	60
query33	539	383	317	317
query34	773	875	538	538
query35	784	859	758	758
query36	1044	1071	961	961
query37	101	95	68	68
query38	4033	4054	3989	3989
query39	1558	1511	1475	1475
query40	213	127	109	109
query41	54	55	53	53
query42	126	110	108	108
query43	523	526	489	489
query44	1391	828	830	828
query45	188	181	172	172
query46	926	1086	717	717
query47	1983	1972	1901	1901
query48	406	430	362	362
query49	747	496	402	402
query50	719	729	436	436
query51	7473	7416	7286	7286
query52	102	106	93	93
query53	240	270	201	201
query54	544	562	481	481
query55	81	84	86	84
query56	274	289	247	247
query57	1265	1268	1221	1221
query58	241	219	214	214
query59	3041	3123	2954	2954
query60	299	310	274	274
query61	113	116	111	111
query62	823	753	701	701
query63	236	199	204	199
query64	3530	1029	696	696
query65	3400	3278	3290	3278
query66	803	412	308	308
query67	16172	15908	15506	15506
query68	5470	885	551	551
query69	487	311	276	276
query70	1165	1165	1126	1126
query71	407	305	274	274
query72	5741	3796	3885	3796
query73	651	754	359	359
query74	10069	9390	8996	8996
query75	3231	3135	2664	2664
query76	3110	1176	800	800
query77	474	369	298	298
query78	10415	10509	9618	9618
query79	2228	901	614	614
query80	1715	535	440	440
query81	563	258	222	222
query82	376	121	90	90
query83	255	168	151	151
query84	243	95	78	78
query85	785	368	299	299
query86	469	319	304	304
query87	4326	4332	4200	4200
query88	4230	2428	2402	2402
query89	403	337	291	291
query90	1817	192	187	187
query91	143	137	113	113
query92	64	57	54	54
query93	2503	905	539	539
query94	719	407	308	308
query95	341	280	270	270
query96	491	605	281	281
query97	3170	3251	3136	3136
query98	222	218	200	200
query99	1329	1433	1296	1296
Total cold run time: 291058 ms
Total hot run time: 197379 ms

@doris-robot
Copy link

doris-robot commented Aug 5, 2025

ClickBench: Total hot run time: 29.05 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit e31bf99b6de6c7c59895aeda18c2c89c81cdfa8f, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.03	0.03
query3	0.23	0.07	0.06
query4	1.66	0.10	0.10
query5	0.53	0.51	0.52
query6	1.12	0.73	0.72
query7	0.02	0.02	0.02
query8	0.04	0.04	0.03
query9	0.59	0.49	0.50
query10	0.55	0.54	0.57
query11	0.14	0.10	0.10
query12	0.14	0.11	0.11
query13	0.60	0.60	0.58
query14	0.79	0.81	0.79
query15	0.84	0.84	0.84
query16	0.39	0.39	0.37
query17	1.07	0.98	0.98
query18	0.23	0.22	0.21
query19	1.98	1.92	1.83
query20	0.02	0.02	0.01
query21	15.38	0.93	0.59
query22	0.72	0.83	0.66
query23	15.08	1.44	0.60
query24	2.61	1.51	1.06
query25	0.24	0.11	0.16
query26	0.31	0.13	0.14
query27	0.05	0.05	0.05
query28	13.70	1.08	0.44
query29	12.56	3.85	3.29
query30	0.25	0.10	0.07
query31	2.82	0.59	0.37
query32	3.23	0.54	0.46
query33	3.00	3.04	3.02
query34	16.65	5.26	4.54
query35	4.54	4.54	4.53
query36	0.64	0.50	0.48
query37	0.09	0.06	0.06
query38	0.04	0.04	0.03
query39	0.04	0.02	0.03
query40	0.18	0.13	0.14
query41	0.08	0.03	0.02
query42	0.04	0.02	0.02
query43	0.03	0.02	0.02
Total cold run time: 103.32 s
Total hot run time: 29.05 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Aug 5, 2025

BE UT Coverage Report

Increment line coverage 28.57% (2/7) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 45.40% (12641/27842)
Line Coverage 36.26% (112689/310763)
Region Coverage 35.29% (58225/164968)
Branch Coverage 32.49% (31666/97458)

@hello-stephen
Copy link
Contributor

hello-stephen commented Aug 5, 2025

BE Regression && UT Coverage Report

Increment line coverage 28.57% (2/7) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 76.19% (20961/27510)
Line Coverage 69.61% (216177/310556)
Region Coverage 67.62% (129366/191307)
Branch Coverage 61.19% (67297/109984)

@morrySnow morrySnow merged commit c690795 into branch-3.1 Aug 5, 2025
21 of 23 checks passed
@github-actions github-actions bot deleted the auto-pick-54255-branch-3.1 branch August 5, 2025 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morrySnow morrySnow morrySnow approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Thearas @doris-robot @hello-stephen @morrySnow @dataroaring @dwdwqfwe