Skip to content

[minor](pipeline) Report error if fragment closed#54554

Merged
yiguolei merged 1 commit intoapache:masterfrom
Gabriel39:minor_0811
Aug 12, 2025
Merged

[minor](pipeline) Report error if fragment closed#54554
yiguolei merged 1 commit intoapache:masterfrom
Gabriel39:minor_0811

Conversation

@Gabriel39
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Gabriel39
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 33875 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 2a51f58b3a688a349d368af301f38c2c910e8226, data reload: false

------ Round 1 ----------------------------------
q1	17642	5343	5414	5343
q2	1926	285	188	188
q3	10316	1322	735	735
q4	10228	1037	521	521
q5	7516	2338	2300	2300
q6	178	162	131	131
q7	929	757	635	635
q8	9299	1286	1072	1072
q9	6818	5109	5061	5061
q10	6901	2369	1965	1965
q11	464	279	286	279
q12	357	368	233	233
q13	17761	3463	3003	3003
q14	232	252	226	226
q15	547	458	475	458
q16	424	416	377	377
q17	577	839	353	353
q18	7181	6939	6933	6933
q19	2001	988	551	551
q20	333	307	222	222
q21	3434	3111	2276	2276
q22	1073	1048	1013	1013
Total cold run time: 106137 ms
Total hot run time: 33875 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5473	5505	5380	5380
q2	228	308	217	217
q3	2113	2623	2215	2215
q4	1320	1734	1321	1321
q5	4146	4412	4332	4332
q6	230	180	140	140
q7	1960	1911	1808	1808
q8	2662	2491	2456	2456
q9	7220	7364	7363	7363
q10	3048	3479	2921	2921
q11	571	518	482	482
q12	699	749	620	620
q13	3437	3832	3265	3265
q14	278	319	301	301
q15	496	440	474	440
q16	428	466	445	445
q17	1195	1489	1417	1417
q18	8086	8104	7704	7704
q19	13018	922	895	895
q20	2019	1984	1888	1888
q21	14924	4329	4292	4292
q22	1040	1065	1022	1022
Total cold run time: 74591 ms
Total hot run time: 50924 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 185667 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 2a51f58b3a688a349d368af301f38c2c910e8226, data reload: false

query1	1040	406	402	402
query2	6531	1750	1692	1692
query3	6749	229	222	222
query4	27150	23187	22941	22941
query5	4333	616	497	497
query6	316	262	213	213
query7	4630	511	294	294
query8	279	228	225	225
query9	8582	2931	2947	2931
query10	476	374	288	288
query11	15921	14977	14773	14773
query12	183	137	150	137
query13	1651	537	390	390
query14	8597	5705	5910	5705
query15	214	207	167	167
query16	7127	666	490	490
query17	935	763	630	630
query18	1990	430	310	310
query19	219	204	182	182
query20	151	147	138	138
query21	218	128	106	106
query22	3997	4000	4016	4000
query23	34621	34443	34356	34356
query24	5245	2462	2434	2434
query25	485	510	429	429
query26	713	286	163	163
query27	2255	499	351	351
query28	3009	2325	2336	2325
query29	597	597	547	547
query30	292	227	201	201
query31	813	788	700	700
query32	90	79	78	78
query33	441	424	405	405
query34	786	845	535	535
query35	830	846	741	741
query36	1007	1016	914	914
query37	135	111	93	93
query38	3933	3972	3975	3972
query39	1456	1372	1385	1372
query40	237	141	130	130
query41	63	58	54	54
query42	139	120	129	120
query43	537	499	502	499
query44	1375	868	858	858
query45	195	200	180	180
query46	933	1057	668	668
query47	1812	1858	1791	1791
query48	397	425	307	307
query49	679	533	423	423
query50	658	694	416	416
query51	4242	4229	4102	4102
query52	135	131	120	120
query53	257	293	213	213
query54	646	648	550	550
query55	89	90	88	88
query56	350	365	352	352
query57	1182	1248	1151	1151
query58	362	327	339	327
query59	2613	2657	2574	2574
query60	403	421	395	395
query61	123	131	125	125
query62	785	726	660	660
query63	249	216	220	216
query64	2382	1115	784	784
query65	4255	4157	4171	4157
query66	721	459	343	343
query67	16166	15844	15786	15786
query68	15582	586	629	586
query69	1024	312	293	293
query70	1276	1073	1118	1073
query71	731	337	326	326
query72	9206	2313	2328	2313
query73	3396	624	350	350
query74	9037	9091	8700	8700
query75	7741	3127	2666	2666
query76	8645	1207	779	779
query77	1160	416	333	333
query78	9532	11653	9310	9310
query79	13902	591	576	576
query80	1960	563	520	520
query81	567	251	236	236
query82	503	208	117	117
query83	389	291	270	270
query84	310	94	83	83
query85	952	371	338	338
query86	374	342	304	304
query87	4274	4213	4218	4213
query88	5508	2221	2229	2221
query89	479	370	315	315
query90	2680	241	240	240
query91	144	146	111	111
query92	96	73	69	69
query93	5959	962	646	646
query94	1092	396	274	274
query95	410	340	330	330
query96	504	599	277	277
query97	2690	2696	2551	2551
query98	251	230	225	225
query99	1448	1365	1284	1284
Total cold run time: 311804 ms
Total hot run time: 185667 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 33.36 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 2a51f58b3a688a349d368af301f38c2c910e8226, data reload: false

query1	0.05	0.04	0.04
query2	0.07	0.04	0.04
query3	0.24	0.08	0.07
query4	1.63	0.11	0.10
query5	0.41	0.44	0.44
query6	1.17	0.68	0.66
query7	0.03	0.02	0.02
query8	0.05	0.03	0.03
query9	0.56	0.49	0.47
query10	0.53	0.52	0.53
query11	0.16	0.10	0.11
query12	0.16	0.11	0.10
query13	0.64	0.66	0.64
query14	0.93	1.09	1.11
query15	0.95	0.87	0.88
query16	0.39	0.42	0.39
query17	1.06	1.07	1.06
query18	0.23	0.20	0.20
query19	2.09	1.84	1.88
query20	0.02	0.01	0.02
query21	15.40	0.86	0.55
query22	0.76	1.19	0.79
query23	14.82	1.13	0.65
query24	6.80	1.24	0.74
query25	0.49	0.14	0.19
query26	0.69	0.16	0.14
query27	0.05	0.06	0.05
query28	9.80	0.85	0.45
query29	12.57	3.86	3.34
query30	3.08	2.99	3.09
query31	2.82	0.57	0.40
query32	3.24	0.57	0.50
query33	3.10	3.17	3.12
query34	16.11	5.40	4.91
query35	4.88	5.02	5.02
query36	0.71	0.51	0.50
query37	0.10	0.07	0.08
query38	0.06	0.05	0.05
query39	0.04	0.03	0.03
query40	0.17	0.14	0.14
query41	0.09	0.04	0.03
query42	0.04	0.03	0.03
query43	0.04	0.04	0.03
Total cold run time: 107.23 s
Total hot run time: 33.36 s

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 33.33% (1/3) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 59.00% (16604/28141)
Line Coverage 47.87% (150488/314354)
Region Coverage 36.72% (112747/307082)
Branch Coverage 39.63% (50013/126196)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 33.33% (1/3) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 81.54% (22519/27616)
Line Coverage 74.20% (233259/314353)
Region Coverage 61.56% (194116/315344)
Branch Coverage 65.54% (83728/127744)

Copy link
Contributor

@BiteTheDDDDt BiteTheDDDDt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 12, 2025
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@yiguolei yiguolei merged commit 2493400 into apache:master Aug 12, 2025
26 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants