Skip to content

[branch-3.0] [fix](checker) Use cloud::blob_get/put to get tablet schema #54518#54592

Merged
dataroaring merged 1 commit intoapache:branch-3.0from
wyxxxcat:pick_54518_3_0
Aug 12, 2025
Merged

[branch-3.0] [fix](checker) Use cloud::blob_get/put to get tablet schema #54518#54592
dataroaring merged 1 commit intoapache:branch-3.0from
wyxxxcat:pick_54518_3_0

Conversation

@wyxxxcat
Copy link
Collaborator

@wyxxxcat wyxxxcat commented Aug 12, 2025

pick: #54518

@wyxxxcat
[fix](checker) Use cloud::blob_get/put to get tablet schema (apache…
88d973f 
…#54518)

1. change from `txn->get` to `cloud::blob_get`
2. check when index is empty
3. add releated cases
@wyxxxcat wyxxxcat requested a review from dataroaring as a code owner August 12, 2025 01:49
@hello-stephen
Copy link
Contributor

hello-stephen commented Aug 12, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@wyxxxcat
Copy link
Collaborator Author

wyxxxcat commented Aug 12, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Aug 12, 2025

Cloud UT Coverage Report

Increment line coverage 68.75% (22/32) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 80.95% (1173/1449)
Line Coverage 65.11% (20107/30882)
Region Coverage 66.68% (10144/15213)
Branch Coverage 56.27% (5356/9518)

dataroaring
dataroaring approved these changes Aug 12, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit f54a162 into apache:branch-3.0 Aug 12, 2025
24 checks passed
@gavinchou gavinchou mentioned this pull request Sep 1, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wyxxxcat @hello-stephen @doris-robot @dataroaring