Skip to content

Conversation

@morrySnow
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@morrySnow
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 33828 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 2a82bbd3020ed2da1e4f35d39f8c161180bada06, data reload: false

------ Round 1 ----------------------------------
q1	17636	5208	5200	5200
q2	1900	273	174	174
q3	10342	1236	707	707
q4	10209	979	506	506
q5	7515	2378	2282	2282
q6	176	157	126	126
q7	875	729	628	628
q8	9327	1276	1093	1093
q9	6884	5099	5076	5076
q10	6925	2366	1965	1965
q11	474	291	281	281
q12	333	341	220	220
q13	17774	3618	3033	3033
q14	232	239	220	220
q15	567	475	480	475
q16	411	428	376	376
q17	591	846	353	353
q18	7421	7089	7086	7086
q19	1086	927	560	560
q20	344	327	218	218
q21	3706	3115	2288	2288
q22	1078	1024	961	961
Total cold run time: 105806 ms
Total hot run time: 33828 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5114	5126	5232	5126
q2	244	315	221	221
q3	2190	2664	2295	2295
q4	1373	1785	1331	1331
q5	4178	4379	4400	4379
q6	211	172	133	133
q7	2018	2000	1775	1775
q8	2601	2505	2459	2459
q9	7228	7395	7336	7336
q10	3114	3273	2867	2867
q11	608	524	637	524
q12	736	767	615	615
q13	3483	3898	3210	3210
q14	294	307	277	277
q15	526	621	501	501
q16	445	477	426	426
q17	1130	1593	1363	1363
q18	7789	7758	7748	7748
q19	816	801	864	801
q20	2005	2084	1858	1858
q21	4866	4192	4257	4192
q22	1082	1043	985	985
Total cold run time: 52051 ms
Total hot run time: 50422 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 184426 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 2a82bbd3020ed2da1e4f35d39f8c161180bada06, data reload: false

query1	1019	390	390	390
query2	6535	1729	1752	1729
query3	6748	220	214	214
query4	26191	23529	23128	23128
query5	4339	626	482	482
query6	301	216	189	189
query7	4631	504	281	281
query8	269	226	207	207
query9	8549	2815	2844	2815
query10	455	326	265	265
query11	15722	14973	14896	14896
query12	162	113	116	113
query13	1659	557	420	420
query14	8447	5645	5607	5607
query15	207	195	170	170
query16	7193	646	455	455
query17	1200	720	601	601
query18	2012	399	307	307
query19	209	177	157	157
query20	119	119	115	115
query21	219	121	106	106
query22	4379	4390	4160	4160
query23	33983	33304	33096	33096
query24	8076	2331	2364	2331
query25	540	482	403	403
query26	1229	272	163	163
query27	2763	501	347	347
query28	4328	2232	2212	2212
query29	804	588	501	501
query30	283	228	190	190
query31	877	803	718	718
query32	83	72	74	72
query33	574	362	330	330
query34	782	847	492	492
query35	771	803	747	747
query36	957	1034	907	907
query37	113	110	83	83
query38	3982	4012	3943	3943
query39	1485	1410	1401	1401
query40	219	122	114	114
query41	58	58	52	52
query42	126	109	119	109
query43	487	507	479	479
query44	1309	845	834	834
query45	172	168	160	160
query46	833	999	629	629
query47	1757	1858	1710	1710
query48	382	403	311	311
query49	730	484	408	408
query50	635	685	390	390
query51	3999	4044	4071	4044
query52	117	111	98	98
query53	233	258	196	196
query54	584	594	539	539
query55	87	89	80	80
query56	305	310	303	303
query57	1176	1179	1139	1139
query58	293	277	280	277
query59	2711	2692	2584	2584
query60	352	358	336	336
query61	175	127	126	126
query62	798	735	675	675
query63	228	181	191	181
query64	4413	1025	698	698
query65	4291	4214	4206	4206
query66	1158	412	332	332
query67	15486	15208	15194	15194
query68	7897	901	570	570
query69	487	321	341	321
query70	1218	1161	1161	1161
query71	417	322	300	300
query72	5636	4703	4512	4512
query73	619	551	342	342
query74	9006	9087	8704	8704
query75	3253	3048	2653	2653
query76	3245	1133	728	728
query77	526	429	326	326
query78	9480	9743	8864	8864
query79	2193	828	607	607
query80	652	538	484	484
query81	491	253	219	219
query82	218	142	105	105
query83	259	246	236	236
query84	251	99	80	80
query85	795	375	342	342
query86	339	291	282	282
query87	4204	4312	4140	4140
query88	2767	2211	2202	2202
query89	408	309	278	278
query90	1825	221	223	221
query91	141	140	116	116
query92	77	71	68	68
query93	1161	965	637	637
query94	614	405	296	296
query95	400	329	320	320
query96	481	595	277	277
query97	2602	2653	2577	2577
query98	243	216	208	208
query99	1338	1433	1303	1303
Total cold run time: 268552 ms
Total hot run time: 184426 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.6 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 2a82bbd3020ed2da1e4f35d39f8c161180bada06, data reload: false

query1	0.04	0.04	0.03
query2	0.08	0.04	0.04
query3	0.24	0.07	0.07
query4	1.61	0.11	0.11
query5	0.43	0.43	0.39
query6	1.17	0.63	0.66
query7	0.03	0.02	0.02
query8	0.05	0.04	0.04
query9	0.60	0.52	0.52
query10	0.57	0.57	0.58
query11	0.16	0.11	0.11
query12	0.15	0.11	0.12
query13	0.62	0.61	0.60
query14	0.80	0.81	0.86
query15	0.87	0.87	0.87
query16	0.39	0.40	0.39
query17	1.04	1.04	1.07
query18	0.21	0.19	0.20
query19	1.97	1.77	1.89
query20	0.02	0.01	0.01
query21	15.38	0.89	0.55
query22	0.76	1.24	0.87
query23	14.78	1.36	0.63
query24	6.49	1.71	0.76
query25	0.47	0.18	0.07
query26	0.52	0.16	0.13
query27	0.06	0.05	0.05
query28	9.70	0.94	0.43
query29	12.57	3.87	3.28
query30	3.02	2.97	2.91
query31	2.83	0.57	0.38
query32	3.24	0.54	0.47
query33	3.05	3.06	3.09
query34	16.01	5.41	4.89
query35	4.87	4.96	4.96
query36	0.68	0.50	0.51
query37	0.10	0.08	0.07
query38	0.04	0.04	0.04
query39	0.03	0.03	0.02
query40	0.18	0.14	0.15
query41	0.08	0.03	0.02
query42	0.04	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 105.99 s
Total hot run time: 32.6 s

@hello-stephen
Copy link
Contributor

FE UT Coverage Report

Increment line coverage 100.00% (1/1) 🎉
Increment coverage report
Complete coverage report

@morrySnow
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 33647 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 4b3a7635de535188860fe71f5bd01d4d909fd6fd, data reload: false

------ Round 1 ----------------------------------
q1	17570	5280	5049	5049
q2	1930	284	180	180
q3	10332	1277	702	702
q4	10225	987	527	527
q5	7475	2404	2315	2315
q6	178	156	128	128
q7	878	738	606	606
q8	9312	1308	1043	1043
q9	6894	5084	5085	5084
q10	6969	2374	1945	1945
q11	475	285	263	263
q12	334	340	211	211
q13	17769	3626	3032	3032
q14	238	231	210	210
q15	530	483	485	483
q16	416	424	366	366
q17	591	843	355	355
q18	7509	7190	7059	7059
q19	1094	964	560	560
q20	345	324	219	219
q21	3984	3195	2340	2340
q22	1046	1010	970	970
Total cold run time: 106094 ms
Total hot run time: 33647 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5121	5157	5080	5080
q2	255	321	222	222
q3	2165	2658	2289	2289
q4	1363	1763	1340	1340
q5	4225	4541	4551	4541
q6	209	165	125	125
q7	2019	1940	1845	1845
q8	2638	2624	2643	2624
q9	7323	7279	7168	7168
q10	3120	3344	2925	2925
q11	571	528	498	498
q12	721	778	637	637
q13	3518	4040	3319	3319
q14	278	326	273	273
q15	526	482	476	476
q16	516	516	457	457
q17	1180	1578	1384	1384
q18	7874	7736	7667	7667
q19	847	838	912	838
q20	2000	2048	1861	1861
q21	4723	4285	4291	4285
q22	1072	1073	1017	1017
Total cold run time: 52264 ms
Total hot run time: 50871 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 184719 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 4b3a7635de535188860fe71f5bd01d4d909fd6fd, data reload: false

query1	1001	397	419	397
query2	6510	1758	1747	1747
query3	6741	222	212	212
query4	26428	23534	22964	22964
query5	4386	621	479	479
query6	310	227	206	206
query7	4627	493	292	292
query8	270	228	226	226
query9	8645	2902	2915	2902
query10	493	345	302	302
query11	15401	14956	14771	14771
query12	158	110	110	110
query13	1672	564	445	445
query14	8675	5763	5762	5762
query15	207	198	169	169
query16	7761	665	470	470
query17	1207	721	610	610
query18	2035	424	325	325
query19	191	189	162	162
query20	126	124	117	117
query21	215	124	108	108
query22	4066	4065	4150	4065
query23	34354	33218	33150	33150
query24	8084	2365	2356	2356
query25	528	480	407	407
query26	1226	271	162	162
query27	2726	493	345	345
query28	4453	2269	2239	2239
query29	737	565	474	474
query30	289	221	186	186
query31	883	803	716	716
query32	81	77	82	77
query33	548	377	347	347
query34	781	850	495	495
query35	769	808	751	751
query36	969	1007	908	908
query37	123	109	88	88
query38	4034	4068	3998	3998
query39	1479	1450	1422	1422
query40	221	125	115	115
query41	58	61	57	57
query42	124	112	116	112
query43	501	505	475	475
query44	1348	860	875	860
query45	176	164	168	164
query46	854	1062	643	643
query47	1759	1831	1710	1710
query48	395	422	312	312
query49	738	494	376	376
query50	629	692	395	395
query51	4093	4154	4090	4090
query52	113	111	110	110
query53	240	268	211	211
query54	594	579	517	517
query55	87	89	86	86
query56	318	314	309	309
query57	1192	1183	1121	1121
query58	303	271	273	271
query59	2672	2799	2597	2597
query60	339	338	327	327
query61	129	123	151	123
query62	792	723	683	683
query63	227	190	185	185
query64	4257	978	728	728
query65	4303	4198	4232	4198
query66	1103	419	326	326
query67	15632	15297	15008	15008
query68	8476	906	570	570
query69	485	342	292	292
query70	1244	1141	1088	1088
query71	491	326	308	308
query72	5295	4667	4876	4667
query73	747	624	353	353
query74	8959	8958	8917	8917
query75	3838	3069	2627	2627
query76	3711	1133	719	719
query77	795	391	336	336
query78	9553	9702	8858	8858
query79	3012	790	588	588
query80	637	536	465	465
query81	473	256	222	222
query82	295	134	105	105
query83	294	244	234	234
query84	290	111	91	91
query85	765	419	335	335
query86	351	328	295	295
query87	4382	4302	4153	4153
query88	2796	2166	2169	2166
query89	420	313	283	283
query90	2073	214	213	213
query91	137	137	118	118
query92	92	75	67	67
query93	2126	985	636	636
query94	690	388	317	317
query95	397	315	300	300
query96	479	592	279	279
query97	2603	2677	2568	2568
query98	233	215	215	215
query99	1429	1422	1263	1263
Total cold run time: 273954 ms
Total hot run time: 184719 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.13 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 4b3a7635de535188860fe71f5bd01d4d909fd6fd, data reload: false

query1	0.05	0.04	0.04
query2	0.08	0.04	0.04
query3	0.24	0.07	0.07
query4	1.62	0.11	0.11
query5	0.44	0.43	0.42
query6	1.19	0.64	0.65
query7	0.02	0.02	0.02
query8	0.04	0.04	0.03
query9	0.61	0.53	0.53
query10	0.57	0.56	0.56
query11	0.16	0.11	0.11
query12	0.15	0.12	0.12
query13	0.62	0.61	0.60
query14	0.81	0.82	0.85
query15	0.86	0.84	0.86
query16	0.40	0.39	0.39
query17	1.08	1.08	1.04
query18	0.22	0.20	0.20
query19	1.99	1.78	1.88
query20	0.01	0.01	0.01
query21	15.40	0.93	0.55
query22	0.80	1.17	0.85
query23	14.77	1.37	0.63
query24	5.83	1.59	0.31
query25	0.45	0.34	0.06
query26	0.51	0.15	0.13
query27	0.06	0.06	0.05
query28	10.02	0.95	0.43
query29	12.55	3.94	3.25
query30	3.03	3.04	2.95
query31	2.82	0.60	0.39
query32	3.23	0.56	0.48
query33	3.03	3.06	3.14
query34	16.15	5.44	4.83
query35	4.92	4.94	4.96
query36	0.67	0.51	0.52
query37	0.09	0.08	0.07
query38	0.06	0.04	0.04
query39	0.04	0.02	0.03
query40	0.18	0.14	0.13
query41	0.08	0.03	0.03
query42	0.04	0.03	0.02
query43	0.03	0.03	0.03
Total cold run time: 105.92 s
Total hot run time: 32.13 s

@morrySnow morrySnow marked this pull request as ready for review August 15, 2025 10:01
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 15, 2025
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@starocean999 starocean999 merged commit 23f35dc into apache:master Aug 18, 2025
29 of 30 checks passed
@morrySnow morrySnow deleted the remove_sql_parser branch August 19, 2025 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants