Skip to content

Conversation

@yiguolei
Copy link
Contributor

What problem does this PR solve?

If init = false, some variables is not inited, for example, the _tablet_reader is not inited. And when update counters, it will core.
This problem only exist in master and 3.1.
And in master branch, I refactor these code because the init flag is modified very confused.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@yiguolei yiguolei requested a review from morrySnow as a code owner August 18, 2025 06:21
@Thearas
Copy link
Contributor

Thearas commented Aug 18, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@yiguolei
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 32774 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit b47e493888983e7e0793ecc327191f362c52f159, data reload: false

------ Round 1 ----------------------------------
q1	17616	5425	5394	5394
q2	2031	393	281	281
q3	12327	1215	745	745
q4	10585	891	488	488
q5	9623	2378	2142	2142
q6	192	162	132	132
q7	889	736	632	632
q8	9338	1404	1151	1151
q9	5239	4912	4889	4889
q10	6763	2266	1834	1834
q11	479	285	271	271
q12	341	350	208	208
q13	17779	3601	3018	3018
q14	221	226	213	213
q15	532	464	478	464
q16	411	427	384	384
q17	597	851	367	367
q18	6827	6459	6481	6459
q19	1231	939	541	541
q20	324	338	215	215
q21	2920	2147	1961	1961
q22	1034	1007	985	985
Total cold run time: 107299 ms
Total hot run time: 32774 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5509	5481	5467	5467
q2	238	341	242	242
q3	2257	2662	2337	2337
q4	1375	1756	1348	1348
q5	4389	4977	4970	4970
q6	172	162	126	126
q7	2053	1966	1833	1833
q8	2610	2835	2663	2663
q9	7202	7152	7235	7152
q10	3037	3286	2715	2715
q11	568	501	518	501
q12	654	853	598	598
q13	3408	3759	3104	3104
q14	277	320	271	271
q15	530	486	469	469
q16	434	485	443	443
q17	1244	1732	1272	1272
q18	7739	7429	7304	7304
q19	764	1152	1057	1057
q20	2009	2067	1918	1918
q21	5336	4867	4599	4599
q22	1060	1079	1028	1028
Total cold run time: 52865 ms
Total hot run time: 51417 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 193328 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit b47e493888983e7e0793ecc327191f362c52f159, data reload: false

query1	949	408	409	408
query2	6197	1941	1964	1941
query3	8690	197	194	194
query4	33773	23864	23857	23857
query5	3915	590	458	458
query6	306	202	186	186
query7	4212	503	310	310
query8	320	265	254	254
query9	9312	2633	2628	2628
query10	502	333	253	253
query11	17954	15355	15220	15220
query12	160	110	106	106
query13	1563	537	417	417
query14	9625	7114	6701	6701
query15	244	196	184	184
query16	8076	650	476	476
query17	1604	742	578	578
query18	2154	415	317	317
query19	227	191	162	162
query20	120	116	118	116
query21	205	138	107	107
query22	4706	4813	4589	4589
query23	35142	34453	33860	33860
query24	7690	2668	2709	2668
query25	546	513	451	451
query26	885	299	178	178
query27	2179	495	353	353
query28	5475	2254	2214	2214
query29	722	621	474	474
query30	245	198	171	171
query31	1020	923	826	826
query32	119	57	59	57
query33	494	351	311	311
query34	738	869	523	523
query35	801	845	763	763
query36	1015	1088	968	968
query37	110	102	73	73
query38	4017	3981	3965	3965
query39	1567	1474	1484	1474
query40	206	117	106	106
query41	50	49	47	47
query42	122	103	103	103
query43	525	521	506	506
query44	1348	827	826	826
query45	182	189	176	176
query46	912	1093	683	683
query47	2032	2014	1939	1939
query48	420	438	353	353
query49	735	506	410	410
query50	699	716	425	425
query51	7440	7351	7279	7279
query52	102	112	97	97
query53	237	266	191	191
query54	557	569	475	475
query55	79	79	77	77
query56	267	274	262	262
query57	1290	1260	1211	1211
query58	252	236	210	210
query59	3217	3275	3266	3266
query60	338	291	280	280
query61	114	112	114	112
query62	832	778	715	715
query63	233	194	194	194
query64	3977	1015	655	655
query65	3378	3303	3329	3303
query66	790	426	307	307
query67	16306	15803	15669	15669
query68	5197	849	528	528
query69	503	304	270	270
query70	1236	1131	1151	1131
query71	375	292	265	265
query72	5850	3764	3835	3764
query73	639	770	353	353
query74	10629	9441	9344	9344
query75	3240	3107	2676	2676
query76	2923	1240	786	786
query77	492	365	283	283
query78	10433	10312	9708	9708
query79	3189	921	587	587
query80	1572	518	437	437
query81	529	258	219	219
query82	689	123	90	90
query83	216	160	150	150
query84	230	107	82	82
query85	805	383	316	316
query86	473	302	291	291
query87	4240	4261	4204	4204
query88	5159	2421	2404	2404
query89	411	336	301	301
query90	1776	191	190	190
query91	140	137	112	112
query92	63	59	54	54
query93	2750	897	562	562
query94	757	399	316	316
query95	361	282	274	274
query96	490	640	284	284
query97	3232	3304	3187	3187
query98	217	222	197	197
query99	1330	1409	1295	1295
Total cold run time: 294365 ms
Total hot run time: 193328 ms

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 0.00% (0/5) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 45.48% (12717/27963)
Line Coverage 36.35% (113320/311757)
Region Coverage 33.99% (64870/190843)
Branch Coverage 31.01% (34030/109726)

@yiguolei yiguolei added the p0_c label Aug 18, 2025
@doris-robot
Copy link

ClickBench: Total hot run time: 28.39 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit b47e493888983e7e0793ecc327191f362c52f159, data reload: false

query1	0.04	0.03	0.03
query2	0.07	0.02	0.03
query3	0.24	0.07	0.07
query4	1.62	0.10	0.11
query5	0.51	0.51	0.51
query6	1.14	0.73	0.72
query7	0.02	0.02	0.01
query8	0.05	0.03	0.04
query9	0.57	0.51	0.50
query10	0.55	0.56	0.56
query11	0.14	0.10	0.10
query12	0.14	0.11	0.10
query13	0.62	0.60	0.60
query14	0.76	0.78	0.79
query15	0.86	0.82	0.83
query16	0.38	0.40	0.40
query17	1.08	1.04	1.08
query18	0.24	0.23	0.24
query19	1.96	1.86	1.88
query20	0.02	0.01	0.01
query21	15.37	0.91	0.60
query22	0.74	0.79	0.60
query23	15.19	1.44	0.53
query24	3.26	1.80	0.44
query25	0.26	0.13	0.10
query26	0.30	0.15	0.14
query27	0.05	0.05	0.04
query28	12.92	1.01	0.43
query29	12.57	3.94	3.21
query30	0.27	0.09	0.06
query31	2.82	0.60	0.39
query32	3.23	0.55	0.46
query33	2.99	3.01	3.06
query34	16.81	5.16	4.51
query35	4.58	4.62	4.60
query36	0.65	0.48	0.49
query37	0.09	0.06	0.06
query38	0.05	0.04	0.03
query39	0.04	0.03	0.02
query40	0.17	0.14	0.12
query41	0.08	0.03	0.02
query42	0.03	0.02	0.02
query43	0.03	0.03	0.04
Total cold run time: 103.51 s
Total hot run time: 28.39 s

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (5/5) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 77.43% (21326/27541)
Line Coverage 71.66% (223018/311236)
Region Coverage 69.63% (133502/191743)
Branch Coverage 63.24% (69743/110290)

@morrySnow morrySnow merged commit 8c1c25b into apache:branch-3.1 Aug 19, 2025
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants