-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[refine](function) refine split_by_string function #54938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[refine](function) refine split_by_string function #54938
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
TPC-H: Total hot run time: 33952 ms |
TPC-DS: Total hot run time: 184917 ms |
ClickBench: Total hot run time: 32.56 s |
|
run buildall |
TPC-H: Total hot run time: 34262 ms |
TPC-DS: Total hot run time: 184608 ms |
ClickBench: Total hot run time: 33.1 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
3ca4549 to
4fae710
Compare
|
run buildall |
TPC-H: Total hot run time: 34037 ms |
TPC-DS: Total hot run time: 185211 ms |
ClickBench: Total hot run time: 32.52 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
HappenLee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
zclllyybb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What problem does this PR solve?
For the split_by_string function:
Use StringSearch to optimize the search.
For const, use a unified function for handling.
Removed the handling of null maps (since the return values are all not null).
Previously, split_by_string had some behavioral inconformity, which was also fixed here.
before
now
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)