Skip to content

Conversation

@peterylh
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #52274

Related PR: #52935

Problem Summary:
migration #52935 to branch 2.1

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

peterylh and others added 3 commits August 19, 2025 15:44
…kup (apache#52935)

Issue Number: close apache#52274

Problem Summary:

When a backup is running, dropping a table, dropping a partition or
truncating a table would cause backup failure because BE cannot find
some tablets. This fix:

1. Add droppedTables and droppedPartitionsByTable fields to track
dropped objects during backup
2.  Filter out dropped tables and partitions during backup

This ensures backup jobs can complete successfully even when tables or
partitions are dropped during the backup process.

Co-authored-by: ylh <ylh@example.com>
@peterylh peterylh requested a review from yiguolei as a code owner August 19, 2025 09:15
@Thearas
Copy link
Contributor

Thearas commented Aug 19, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@peterylh
Copy link
Contributor Author

run buildall

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 4, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2025

PR approved by anyone and no changes requested.

@yiguolei yiguolei merged commit f12253c into apache:branch-2.1 Sep 9, 2025
21 of 22 checks passed
@lide-reed
Copy link
Contributor

2025-09-22 21:52:25,061 WARN (main|1) [DorisFE.start():236] java.io.IOException: java.lang.reflect.InvocationTargetException at org.apache.doris.persist.meta.MetaReader.read(MetaReader.java:129) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.catalog.Env.loadImage(Env.java:1999) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.catalog.Env.initialize(Env.java:1071) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.DorisFE.start(DorisFE.java:189) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.DorisFE.main(DorisFE.java:97) ~[doris-fe.jar:1.2-SNAPSHOT] Caused by: java.lang.reflect.InvocationTargetException at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_272] at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_272] at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_272] at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_272] at org.apache.doris.persist.meta.MetaReader.read(MetaReader.java:126) ~[doris-fe.jar:1.2-SNAPSHOT] ... 4 more Caused by: java.io.EOFException at java.io.DataInputStream.readFully(DataInputStream.java:197) ~[?:1.8.0_272] at java.io.DataInputStream.readLong(DataInputStream.java:416) ~[?:1.8.0_272] at org.apache.doris.backup.BackupJob.readOthers(BackupJob.java:1503) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.backup.BackupJob.readFields(BackupJob.java:1435) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.backup.AbstractJob.read(AbstractJob.java:174) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.backup.BackupHandler.readFields(BackupHandler.java:932) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.catalog.Env.loadBackupHandler(Env.java:2155) ~[doris-fe.jar:1.2-SNAPSHOT] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_272] at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_272] at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_272] at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_272] at org.apache.doris.persist.meta.MetaReader.read(MetaReader.java:126) ~[doris-fe.jar:1.2-SNAPSHOT] ... 4 more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. kind/behavior-changed reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants