Skip to content

branch-3.0: [fix](Nereids) should not produce date type for datev2 type when process string literal #55011 #55103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 1 commit into from
Sep 11, 2025
Merged

branch-3.0: [fix](Nereids) should not produce date type for datev2 type when process string literal #55011 #55103

dataroaring merged 1 commit into from
Sep 11, 2025

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Aug 21, 2025

Cherry-picked from #55011

@morrySnow
[fix](Nereids) should not produce date type for datev2 type when proc…
ef43c3f 
…ess string literal (#55011)

### What problem does this PR solve?

Related PR: #42941

Problem Summary:

return wrong literal for datev2 type since it use
DateLiteral#parseDateLiteral to process datev2 type.
@github-actions github-actions bot requested a review from dataroaring as a code owner August 21, 2025 06:32
@Thearas
Copy link
Contributor

Thearas commented Aug 21, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Aug 21, 2025
@Thearas
Copy link
Contributor

Thearas commented Aug 21, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Aug 21, 2025

TPC-H: Total hot run time: 39893 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit ef43c3fd1179f8af73fcf694406abe09d55267ed, data reload: false

------ Round 1 ----------------------------------
q1	17600	7409	6719	6719
q2	2045	207	178	178
q3	10607	1150	1229	1150
q4	10497	733	726	726
q5	7769	2892	2824	2824
q6	212	132	137	132
q7	957	619	613	613
q8	9363	1957	1978	1957
q9	6665	6389	6425	6389
q10	7053	2235	2261	2235
q11	456	257	264	257
q12	406	216	214	214
q13	17805	2997	2959	2959
q14	236	203	212	203
q15	536	457	472	457
q16	488	383	383	383
q17	1018	548	554	548
q18	7298	6633	6613	6613
q19	1412	1076	1069	1069
q20	475	212	208	208
q21	3920	3079	3330	3079
q22	1115	1019	980	980
Total cold run time: 107933 ms
Total hot run time: 39893 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6647	6575	6584	6575
q2	327	232	231	231
q3	2931	2931	2966	2931
q4	2049	1830	1758	1758
q5	5744	5735	5708	5708
q6	202	126	128	126
q7	2228	1822	1874	1822
q8	3374	3550	3547	3547
q9	8819	9054	8979	8979
q10	3594	3603	3573	3573
q11	585	493	503	493
q12	822	662	637	637
q13	9904	3219	3152	3152
q14	311	279	259	259
q15	512	477	473	473
q16	492	457	447	447
q17	1827	1609	1654	1609
q18	8326	7832	7810	7810
q19	1679	1600	1519	1519
q20	2070	1859	1878	1859
q21	5244	5062	4945	4945
q22	1140	1095	1007	1007
Total cold run time: 68827 ms
Total hot run time: 59460 ms

@doris-robot
Copy link

doris-robot commented Aug 21, 2025

TPC-DS: Total hot run time: 192026 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit ef43c3fd1179f8af73fcf694406abe09d55267ed, data reload: false

query1	946	378	407	378
query2	6339	1961	1923	1923
query3	8691	201	203	201
query4	33732	23501	23563	23501
query5	3731	471	444	444
query6	296	189	190	189
query7	4208	335	316	316
query8	293	232	233	232
query9	9485	2610	2581	2581
query10	498	275	258	258
query11	18027	15467	15331	15331
query12	162	102	100	100
query13	1559	434	433	433
query14	9756	7707	6749	6749
query15	250	171	176	171
query16	8163	512	499	499
query17	1652	601	590	590
query18	2181	354	328	328
query19	399	172	167	167
query20	125	116	122	116
query21	207	108	115	108
query22	4795	4510	4417	4417
query23	34800	34642	33913	33913
query24	11915	2953	2891	2891
query25	702	438	419	419
query26	1877	177	174	174
query27	3072	350	366	350
query28	7403	2182	2178	2178
query29	1065	459	464	459
query30	278	163	166	163
query31	1019	828	804	804
query32	103	61	59	59
query33	762	315	314	314
query34	995	510	507	507
query35	851	736	764	736
query36	1093	970	953	953
query37	178	67	66	66
query38	4105	3933	4029	3933
query39	1531	1489	1524	1489
query40	262	103	105	103
query41	50	48	48	48
query42	114	99	102	99
query43	522	475	501	475
query44	1396	803	810	803
query45	182	170	170	170
query46	1157	737	741	737
query47	2028	1910	1900	1900
query48	492	385	393	385
query49	1038	421	403	403
query50	824	428	432	428
query51	7707	7267	7137	7137
query52	98	92	87	87
query53	257	184	185	184
query54	1271	480	485	480
query55	78	80	84	80
query56	270	270	247	247
query57	1301	1213	1220	1213
query58	224	215	208	208
query59	3239	3036	3161	3036
query60	300	270	260	260
query61	143	115	130	115
query62	897	708	700	700
query63	228	200	193	193
query64	5031	700	642	642
query65	3351	3287	3231	3231
query66	1317	291	288	288
query67	15893	15598	15712	15598
query68	4983	573	577	573
query69	441	269	263	263
query70	1174	1091	1143	1091
query71	359	258	248	248
query72	6217	4116	4045	4045
query73	762	340	357	340
query74	10896	9042	8986	8986
query75	3391	2639	2653	2639
query76	2730	1011	1025	1011
query77	428	282	275	275
query78	10611	9532	9526	9526
query79	1653	599	587	587
query80	1036	471	423	423
query81	541	221	224	221
query82	651	90	88	88
query83	229	149	152	149
query84	240	78	78	78
query85	1281	313	295	295
query86	396	303	274	274
query87	4396	4260	4313	4260
query88	3550	2381	2334	2334
query89	419	297	287	287
query90	1896	187	189	187
query91	186	149	152	149
query92	61	50	50	50
query93	1892	564	557	557
query94	862	309	300	300
query95	362	264	261	261
query96	626	284	281	281
query97	3265	3090	3193	3090
query98	221	197	196	196
query99	1682	1304	1272	1272
Total cold run time: 304351 ms
Total hot run time: 192026 ms

@doris-robot
Copy link

doris-robot commented Aug 21, 2025

ClickBench: Total hot run time: 30.55 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit ef43c3fd1179f8af73fcf694406abe09d55267ed, data reload: false

query1	0.03	0.04	0.03
query2	0.07	0.03	0.03
query3	0.24	0.07	0.07
query4	1.61	0.11	0.11
query5	0.53	0.50	0.51
query6	1.14	0.74	0.75
query7	0.02	0.02	0.01
query8	0.04	0.03	0.03
query9	0.55	0.50	0.50
query10	0.55	0.56	0.55
query11	0.14	0.11	0.10
query12	0.14	0.10	0.10
query13	0.60	0.59	0.59
query14	0.79	0.82	0.79
query15	0.84	0.83	0.84
query16	0.39	0.38	0.40
query17	0.98	1.09	1.07
query18	0.24	0.22	0.22
query19	1.94	1.90	1.89
query20	0.01	0.01	0.01
query21	15.40	0.58	0.60
query22	2.36	2.01	1.24
query23	16.86	1.05	0.73
query24	3.52	1.68	1.72
query25	0.29	0.16	0.15
query26	0.44	0.15	0.14
query27	0.03	0.04	0.04
query28	8.72	0.52	0.48
query29	12.60	3.23	3.26
query30	0.24	0.05	0.05
query31	2.88	0.39	0.39
query32	3.23	0.46	0.46
query33	3.00	3.06	3.04
query34	17.05	4.52	4.55
query35	4.55	4.51	4.50
query36	0.67	0.48	0.48
query37	0.09	0.06	0.06
query38	0.05	0.04	0.03
query39	0.04	0.03	0.02
query40	0.16	0.12	0.12
query41	0.09	0.02	0.02
query42	0.03	0.02	0.02
query43	0.03	0.02	0.03
Total cold run time: 103.18 s
Total hot run time: 30.55 s

dataroaring
dataroaring approved these changes Sep 11, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 11, 2025
@github-actions
Copy link
Contributor Author

github-actions bot commented Sep 11, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor Author

github-actions bot commented Sep 11, 2025

PR approved by anyone and no changes requested.

@morrySnow
Copy link
Contributor

morrySnow commented Sep 11, 2025

run feut

@hello-stephen
Copy link
Contributor

hello-stephen commented Sep 11, 2025

FE UT Coverage Report

Increment line coverage 100.00% (5/5) 🎉
Increment coverage report
Complete coverage report

@dataroaring dataroaring merged commit 790bae0 into branch-3.0 Sep 11, 2025
25 of 26 checks passed
@github-actions github-actions bot deleted the auto-pick-55011-branch-3.0 branch September 11, 2025 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Thearas @doris-robot @morrySnow @hello-stephen @dataroaring