Skip to content

branch-3.1: [fix](temp_table) alive session id set should be thread safe #55315#55338

Merged
morrySnow merged 1 commit intobranch-3.1from
auto-pick-55315-branch-3.1
Aug 28, 2025
Merged

branch-3.1: [fix](temp_table) alive session id set should be thread safe #55315#55338
morrySnow merged 1 commit intobranch-3.1from
auto-pick-55315-branch-3.1

Conversation

@github-actions
Copy link
Contributor

Cherry-picked from #55315

### What problem does this PR solve?

Related PR: ##40680

Problem Summary:

java.lang.NullPointerException: Cannot invoke "String.getBytes(java.nio.charset.Charset)" because "str" is null
at org.apache.thrift.protocol.TBinaryProtocol.writeString(TBinaryProtocol.java:227) ~[libthrift-0.16.0.jar:0.16.0]
at org.apache.doris.thrift.TFrontendReportAliveSessionResult$TFrontendReportAliveSessionResultStandardScheme.write(TFrontendReportAliveSessionResult.java:577) ~[fe-common-1.2-SNAPSHOT.jar:1.2-SNAPSHOT]
at org.apache.doris.thrift.TFrontendReportAliveSessionResult$TFrontendReportAliveSessionResultStandardScheme.write(TFrontendReportAliveSessionResult.java:500) ~[fe-common-1.2-SNAPSHOT.jar:1.2-SNAPSHOT]
at org.apache.doris.thrift.TFrontendReportAliveSessionResult.write(TFrontendReportAliveSessionResult.java:429) ~[fe-common-1.2-SNAPSHOT.jar:1.2-SNAPSHOT]
at org.apache.doris.thrift.FrontendService$getAliveSessions_result$getAliveSessions_resultStandardScheme.write(FrontendService.java:33897) ~[fe-common-1.2-SNAPSHOT.jar:1.2-SNAPSHOT]
at org.apache.doris.thrift.FrontendService$getAliveSessions_result$getAliveSessions_resultStandardScheme.write(FrontendService.java:33859) ~[fe-common-1.2-SNAPSHOT.jar:1.2-SNAPSHOT]
at org.apache.doris.thrift.FrontendService$getAliveSessions_result.write(FrontendService.java:33810) ~[fe-common-1.2-SNAPSHOT.jar:1.2-SNAPSHOT]
at org.apache.thrift.ProcessFunction.process(ProcessFunction.java:58) ~[libthrift-0.16.0.jar:0.16.0]
at org.apache.thrift.TBaseProcessor.process(TBaseProcessor.java:38) ~[libthrift-0.16.0.jar:0.16.0]
at org.apache.thrift.server.TThreadPoolServer$WorkerProcess.run(TThreadPoolServer.java:250) ~[libthrift-0.16.0.jar:0.16.0]
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) ~[?:?]
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) ~[?:?]
at java.lang.Thread.run(Thread.java:833) ~[?:?]
@github-actions github-actions bot requested a review from morrySnow as a code owner August 27, 2025 03:50
@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Aug 27, 2025
@hello-stephen
Copy link
Contributor

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 32751 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit f194503c9e8230a801552250ca2ae8654efc0706, data reload: false

------ Round 1 ----------------------------------
q1	17615	5530	5456	5456
q2	2026	398	273	273
q3	12051	1248	755	755
q4	10224	880	460	460
q5	8141	2433	2178	2178
q6	188	165	133	133
q7	888	745	621	621
q8	9359	1455	1185	1185
q9	5228	4904	4917	4904
q10	6758	2279	1817	1817
q11	489	273	266	266
q12	330	365	218	218
q13	17788	3598	3014	3014
q14	228	239	207	207
q15	524	477	476	476
q16	426	426	369	369
q17	598	868	358	358
q18	7112	6524	6377	6377
q19	1197	943	555	555
q20	333	340	209	209
q21	2746	2178	1917	1917
q22	1051	1040	1003	1003
Total cold run time: 105300 ms
Total hot run time: 32751 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5512	5496	5481	5481
q2	231	331	235	235
q3	2230	2593	2290	2290
q4	1332	1770	1336	1336
q5	4382	4919	4981	4919
q6	169	165	127	127
q7	2021	1945	1838	1838
q8	2613	2831	2769	2769
q9	7243	7238	7236	7236
q10	3009	3338	2725	2725
q11	560	504	489	489
q12	652	822	648	648
q13	3391	3782	3178	3178
q14	293	310	269	269
q15	519	473	472	472
q16	454	474	436	436
q17	1255	1722	1268	1268
q18	7701	7363	7274	7274
q19	798	1165	1066	1066
q20	1985	2041	1858	1858
q21	5490	4946	4708	4708
q22	1080	1055	1015	1015
Total cold run time: 52920 ms
Total hot run time: 51637 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 193129 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit f194503c9e8230a801552250ca2ae8654efc0706, data reload: false

query1	947	406	397	397
query2	6180	1896	1876	1876
query3	8683	193	190	190
query4	33700	23860	23548	23548
query5	3708	611	444	444
query6	274	186	168	168
query7	4197	476	302	302
query8	294	243	229	229
query9	9430	2591	2580	2580
query10	459	330	262	262
query11	17961	15394	15185	15185
query12	153	109	104	104
query13	1550	546	414	414
query14	10021	7047	7582	7047
query15	247	193	183	183
query16	8121	675	511	511
query17	1616	795	597	597
query18	2122	426	317	317
query19	246	192	162	162
query20	125	121	123	121
query21	215	128	103	103
query22	4636	4700	4590	4590
query23	34940	34542	34486	34486
query24	7812	2710	2684	2684
query25	515	481	408	408
query26	1163	294	167	167
query27	2020	472	359	359
query28	5243	2201	2172	2172
query29	751	595	443	443
query30	238	193	162	162
query31	1017	921	854	854
query32	90	56	53	53
query33	534	383	312	312
query34	754	874	537	537
query35	780	827	751	751
query36	1039	1089	963	963
query37	108	97	70	70
query38	4030	4019	3955	3955
query39	1527	1467	1451	1451
query40	208	123	111	111
query41	54	56	51	51
query42	126	108	105	105
query43	502	511	482	482
query44	1310	837	830	830
query45	194	177	176	176
query46	886	1073	668	668
query47	1956	2008	1954	1954
query48	428	428	363	363
query49	798	513	442	442
query50	665	702	437	437
query51	7272	7383	7190	7190
query52	102	100	95	95
query53	233	269	194	194
query54	568	581	494	494
query55	90	80	81	80
query56	287	293	273	273
query57	1283	1288	1227	1227
query58	244	229	228	228
query59	3043	3064	2972	2972
query60	294	280	273	273
query61	110	112	108	108
query62	793	759	691	691
query63	234	196	195	195
query64	4587	989	633	633
query65	3369	3323	3346	3323
query66	963	420	322	322
query67	16058	15855	15762	15762
query68	7330	811	528	528
query69	503	313	268	268
query70	1199	1102	1138	1102
query71	392	290	263	263
query72	5737	3702	3782	3702
query73	623	741	354	354
query74	9464	9035	9344	9035
query75	3189	3184	2652	2652
query76	3353	1190	758	758
query77	616	361	285	285
query78	10297	10477	9699	9699
query79	3137	927	599	599
query80	626	520	441	441
query81	501	264	218	218
query82	581	121	91	91
query83	157	159	143	143
query84	239	97	86	86
query85	773	369	294	294
query86	361	308	313	308
query87	4298	4316	4274	4274
query88	4980	2504	2399	2399
query89	424	338	308	308
query90	1845	194	193	193
query91	132	152	106	106
query92	66	61	54	54
query93	1882	893	550	550
query94	679	406	311	311
query95	353	290	273	273
query96	498	609	289	289
query97	3252	3300	3195	3195
query98	231	208	204	204
query99	1509	1434	1311	1311
Total cold run time: 293330 ms
Total hot run time: 193129 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 28.54 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit f194503c9e8230a801552250ca2ae8654efc0706, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.03	0.03
query3	0.24	0.07	0.07
query4	1.61	0.11	0.10
query5	0.51	0.51	0.51
query6	1.13	0.72	0.72
query7	0.02	0.02	0.02
query8	0.04	0.03	0.03
query9	0.55	0.50	0.49
query10	0.55	0.56	0.55
query11	0.13	0.10	0.11
query12	0.13	0.11	0.10
query13	0.62	0.59	0.59
query14	0.78	0.78	0.79
query15	0.84	0.84	0.81
query16	0.37	0.41	0.39
query17	1.06	1.06	1.05
query18	0.24	0.22	0.22
query19	1.91	1.75	1.86
query20	0.01	0.01	0.01
query21	15.39	0.92	0.58
query22	0.76	0.78	0.62
query23	15.19	1.45	0.53
query24	2.94	0.78	1.02
query25	0.23	0.10	0.06
query26	0.24	0.15	0.13
query27	0.06	0.05	0.03
query28	13.79	0.98	0.43
query29	12.54	3.94	3.22
query30	0.25	0.09	0.06
query31	2.85	0.59	0.37
query32	3.22	0.54	0.45
query33	3.02	3.06	3.07
query34	16.79	5.18	4.55
query35	4.56	4.53	4.57
query36	0.62	0.50	0.48
query37	0.09	0.06	0.06
query38	0.05	0.04	0.03
query39	0.03	0.02	0.02
query40	0.16	0.14	0.13
query41	0.08	0.03	0.03
query42	0.04	0.03	0.02
query43	0.04	0.03	0.02
Total cold run time: 103.78 s
Total hot run time: 28.54 s

@hello-stephen
Copy link
Contributor

FE UT Coverage Report

Increment line coverage 100.00% (1/1) 🎉
Increment coverage report
Complete coverage report

@morrySnow morrySnow merged commit eb22b53 into branch-3.1 Aug 28, 2025
23 checks passed
@github-actions github-actions bot deleted the auto-pick-55315-branch-3.1 branch August 28, 2025 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants