-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix](unique function) fix merge project with unique function #55415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix](unique function) fix merge project with unique function #55415
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
TPC-H: Total hot run time: 34323 ms |
TPC-DS: Total hot run time: 186825 ms |
ClickBench: Total hot run time: 33.5 s |
| if (ExpressionUtils.containsWindowExpression(parentProjects) | ||
| && ExpressionUtils.containsWindowExpression(bottomProjects)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add some comment to explain why cannot merge two project that contain window expression
FE UT Coverage ReportIncrement line coverage |
|
run buildall |
This reverts commit 0e9f00b.
|
run buildall |
TPC-H: Total hot run time: 34326 ms |
TPC-DS: Total hot run time: 187179 ms |
ClickBench: Total hot run time: 33.32 s |
FE Regression Coverage ReportIncrement line coverage |
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
What problem does this PR solve?
when merge project, if the slot reference in parent project exists multiple times, and the slot reference's origin expression contains unique expression, then shouldn't merge these projects, otherwise be will calculate the unique function multiple time.
for example:
after merge project, it will got:
then be wil calcute twice random() for each row.
relate PR: #43546
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)