Skip to content

Conversation

@englefly
Copy link
Contributor

@englefly englefly commented Sep 4, 2025

What problem does this PR solve?

for example, select json_col from T1 union select variant_col from T2;
we cannot find compatible data type for json and variant, and hence we cannot determine the output data type.
currently, there is no error message. In this pr, we print expressions and their data types.

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@englefly
Copy link
Contributor Author

englefly commented Sep 4, 2025

run buildall

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

Copy link
Contributor

@morrySnow morrySnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add test

@englefly englefly force-pushed the compatible-type-exception branch from df82365 to c0923c0 Compare September 4, 2025 07:45
@englefly
Copy link
Contributor Author

englefly commented Sep 4, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 34444 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit c0923c0cb3c9454517514966d6ff4eb032e07fd6, data reload: false

------ Round 1 ----------------------------------
q1	17653	5287	5186	5186
q2	1992	347	215	215
q3	10245	1300	761	761
q4	10252	1006	552	552
q5	7553	2512	2382	2382
q6	193	167	139	139
q7	972	778	645	645
q8	9352	1375	1181	1181
q9	6967	5163	5124	5124
q10	6947	2386	1998	1998
q11	498	307	278	278
q12	366	365	242	242
q13	17779	3697	3058	3058
q14	237	245	229	229
q15	574	515	485	485
q16	434	440	389	389
q17	603	882	372	372
q18	7361	6984	7009	6984
q19	1221	968	585	585
q20	356	344	242	242
q21	4114	3242	2421	2421
q22	1052	1052	976	976
Total cold run time: 106721 ms
Total hot run time: 34444 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5217	5120	5151	5120
q2	251	329	230	230
q3	2176	2681	2270	2270
q4	1375	1759	1386	1386
q5	4244	4482	4470	4470
q6	222	179	133	133
q7	2082	2010	1884	1884
q8	2771	2499	2601	2499
q9	7308	7280	7347	7280
q10	3180	3287	2930	2930
q11	586	524	554	524
q12	693	803	644	644
q13	3584	3942	3284	3284
q14	299	317	302	302
q15	526	482	475	475
q16	445	716	464	464
q17	1183	1523	1405	1405
q18	7893	7744	7634	7634
q19	903	859	937	859
q20	2048	2081	1968	1968
q21	4843	4392	4270	4270
q22	1085	1065	991	991
Total cold run time: 52914 ms
Total hot run time: 51022 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 186823 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit c0923c0cb3c9454517514966d6ff4eb032e07fd6, data reload: false

query1	1054	468	418	418
query2	6563	1810	1736	1736
query3	6754	226	220	220
query4	26043	23502	23316	23316
query5	4387	638	545	545
query6	315	248	242	242
query7	4652	528	306	306
query8	324	269	258	258
query9	8650	2890	2945	2890
query10	495	370	293	293
query11	15955	15096	14716	14716
query12	186	123	122	122
query13	1705	584	461	461
query14	9924	5905	5761	5761
query15	220	196	176	176
query16	7670	659	475	475
query17	1364	757	654	654
query18	2062	437	333	333
query19	202	198	193	193
query20	133	125	122	122
query21	215	129	114	114
query22	4178	4382	4087	4087
query23	33718	32883	32963	32883
query24	8142	2369	2421	2369
query25	575	502	452	452
query26	1245	284	166	166
query27	2718	516	353	353
query28	4320	2252	2224	2224
query29	779	610	495	495
query30	298	224	206	206
query31	936	820	750	750
query32	94	79	77	77
query33	575	394	394	394
query34	805	867	545	545
query35	831	812	739	739
query36	961	1015	923	923
query37	130	110	98	98
query38	4106	4141	4045	4045
query39	1521	1418	1418	1418
query40	226	140	136	136
query41	72	65	68	65
query42	135	118	117	117
query43	540	490	491	490
query44	1373	873	864	864
query45	188	181	172	172
query46	866	1026	653	653
query47	1757	1825	1708	1708
query48	398	420	326	326
query49	785	524	430	430
query50	652	737	399	399
query51	4073	4176	4054	4054
query52	121	115	106	106
query53	266	269	195	195
query54	619	603	543	543
query55	102	91	93	91
query56	335	329	323	323
query57	1210	1218	1143	1143
query58	294	280	279	279
query59	2568	2677	2595	2595
query60	358	366	342	342
query61	178	166	160	160
query62	831	720	645	645
query63	229	201	197	197
query64	4398	1141	832	832
query65	4313	4200	4181	4181
query66	1106	453	340	340
query67	15577	15519	15271	15271
query68	9238	946	580	580
query69	489	341	304	304
query70	1222	1166	1141	1141
query71	587	347	328	328
query72	5607	4957	4997	4957
query73	737	601	363	363
query74	9003	9049	9153	9049
query75	4346	3142	2651	2651
query76	3710	1183	753	753
query77	821	421	342	342
query78	9546	9783	8762	8762
query79	2074	847	585	585
query80	712	569	527	527
query81	474	261	226	226
query82	256	142	116	116
query83	295	262	251	251
query84	304	117	164	117
query85	842	455	426	426
query86	369	314	308	308
query87	4279	4295	4161	4161
query88	2839	2240	2226	2226
query89	472	326	289	289
query90	2100	231	228	228
query91	175	175	132	132
query92	91	78	72	72
query93	1335	1004	659	659
query94	682	395	319	319
query95	424	335	328	328
query96	494	604	279	279
query97	2647	2673	2594	2594
query98	243	221	215	215
query99	1449	1452	1303	1303
Total cold run time: 276237 ms
Total hot run time: 186823 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 33.28 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit c0923c0cb3c9454517514966d6ff4eb032e07fd6, data reload: false

query1	0.06	0.05	0.05
query2	0.09	0.05	0.05
query3	0.25	0.08	0.08
query4	1.60	0.12	0.12
query5	0.46	0.42	0.44
query6	1.17	0.65	0.66
query7	0.03	0.02	0.02
query8	0.06	0.04	0.04
query9	0.61	0.54	0.53
query10	0.58	0.58	0.58
query11	0.17	0.11	0.11
query12	0.15	0.13	0.12
query13	0.62	0.63	0.61
query14	0.80	0.84	0.85
query15	0.88	0.85	0.85
query16	0.39	0.40	0.39
query17	1.04	1.05	1.05
query18	0.22	0.20	0.21
query19	1.96	1.92	1.79
query20	0.02	0.01	0.02
query21	15.39	0.99	0.60
query22	0.75	1.13	0.90
query23	14.75	1.40	0.65
query24	5.93	1.36	1.11
query25	0.52	0.25	0.14
query26	0.52	0.15	0.14
query27	0.06	0.06	0.07
query28	9.60	1.01	0.42
query29	12.55	3.95	3.21
query30	3.12	3.10	2.99
query31	2.82	0.60	0.39
query32	3.25	0.56	0.48
query33	3.06	3.10	3.12
query34	16.06	5.46	4.83
query35	4.89	4.90	4.91
query36	0.70	0.51	0.49
query37	0.11	0.08	0.07
query38	0.06	0.05	0.04
query39	0.04	0.03	0.03
query40	0.18	0.15	0.14
query41	0.08	0.02	0.03
query42	0.04	0.03	0.03
query43	0.04	0.04	0.03
Total cold run time: 105.68 s
Total hot run time: 33.28 s

@hello-stephen
Copy link
Contributor

FE Regression Coverage Report

Increment line coverage 100.00% (5/5) 🎉
Increment coverage report
Complete coverage report

@englefly
Copy link
Contributor Author

englefly commented Sep 5, 2025

run external

Copy link
Contributor

@yujun777 yujun777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2025

PR approved by anyone and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2025

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 5, 2025
@englefly englefly merged commit 2e8df95 into apache:master Sep 5, 2025
29 of 31 checks passed
wenzhenghu pushed a commit to wenzhenghu/doris that referenced this pull request Sep 8, 2025
…e data type (apache#55669)

### What problem does this PR solve?
for example, select json_col from T1 union select variant_col from T2;
we cannot find compatible data type for json and variant, and hence we
cannot determine the output data type.
currently, there is no error message. In this pr, we print expressions
and their data types.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants