-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix](unique function) fix virtual slot with unique function #55716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix](unique function) fix virtual slot with unique function #55716
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
|
run buildall |
TPC-H: Total hot run time: 34327 ms |
TPC-DS: Total hot run time: 186632 ms |
ClickBench: Total hot run time: 29.75 s |
FE UT Coverage ReportIncrement line coverage |
FE Regression Coverage ReportIncrement line coverage |
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
What problem does this PR solve?
if a sub expression exists multiple time in filter, rule PushDownVirtualColumnsIntoOlapScan will extract it as a virtual slot and push it into olap scan.
but if this sub expression itself contains an unique function which exists multiple times, then it should not push into olap scan, rule AddProjectForUniqueFunction will extract the unique function for it.
But we can't construct a real example SQL satisfy the above case, maybe it's not exists in real SQL, we just still fix it for safe reason. And this PR we don't add a real SQL regression test, we just test it with fe ut.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)