Skip to content

Conversation

@0AyanamiRei
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:
This PR fixes a bug in RowsetBuilder::check_tablet_version_count where the TOO_MANY_VERSION error was not triggered due to being masked by the memory limit check. In the original logic, if the tablet version count did not exceed max_version_config - 100 or the memory usage exceeded the soft limit (GlobalMemoryArbitrator::is_exceed_soft_mem_limit), the method returned Status::OK() prematurely, bypassing the version count check against max_tablet_version_num. This caused the TOO_MANY_VERSION error to be suppressed, leading to incorrect behavior in version limit enforcement and failing regression tests (e.g., too_many_versions_detection). The fix reorders the logic to prioritize the version count check, ensuring TOO_MANY_VERSION is triggered when version_count > max_tablet_version_num. Additionally, a new FETCH_MEMORY_EXCEEDED error is introduced for memory shortage cases to improve error clarity.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Sep 7, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@0AyanamiRei 0AyanamiRei closed this Sep 7, 2025
@0AyanamiRei 0AyanamiRei deleted the versions-check-fix branch September 7, 2025 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants