[opt](agg) remove experimental functions approx_top_k and approx_top_sum #55845

zzzxl1993 · 2025-09-10T02:46:54Z

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

This PR removes the experimental aggregate functions approx_top_k and approx_top_sum that were previously implemented but never properly documented or finalized.

Verified no existing tests depend on these functions
Confirmed removal doesn't break other aggregate functions

Release note

None

Check List (For Author)

Test
- Regression test
- Unit Test
- Manual test (add detailed scripts or steps below)
- No need to test or manual test. Explain why:
  - This is a refactor/code format and no logic has been changed.
  - Previous test can cover this change.
  - No code files have been changed.
  - Other reason
Behavior changed:
- No.
- Yes.
Does this need documentation?
- No.
- Yes.

Check List (For Reviewer who merge this PR)

Confirm the release note
Confirm test cases
Confirm document
Add branch pick label

Thearas · 2025-09-10T02:46:59Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

zzzxl1993 · 2025-09-10T02:50:14Z

run buildall

zzzxl1993 · 2025-09-10T03:54:24Z

run buildall

doris-robot · 2025-09-10T05:03:54Z

TPC-H: Total hot run time: 34560 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 21b0711c4b2551fa1bbc03ef57857e1be88ada47, data reload: false

------ Round 1 ----------------------------------
q1	17609	5325	5092	5092
q2	1991	347	217	217
q3	10248	1293	716	716
q4	10238	1024	515	515
q5	7558	2425	2310	2310
q6	178	167	138	138
q7	914	769	640	640
q8	9342	1333	1136	1136
q9	7066	5125	5158	5125
q10	6976	2392	1957	1957
q11	482	318	279	279
q12	374	363	227	227
q13	17799	3650	3038	3038
q14	239	234	218	218
q15	573	516	488	488
q16	1014	1005	940	940
q17	597	860	387	387
q18	7733	7174	6965	6965
q19	1192	962	582	582
q20	353	344	227	227
q21	3796	3163	2375	2375
q22	1055	1007	988	988
Total cold run time: 107327 ms
Total hot run time: 34560 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5197	5121	5109	5109
q2	248	332	229	229
q3	2204	2681	2325	2325
q4	1367	1767	1313	1313
q5	4256	4603	4529	4529
q6	220	175	135	135
q7	2117	1991	1865	1865
q8	2678	2493	2606	2493
q9	7533	7259	7353	7259
q10	3134	3301	2899	2899
q11	588	514	515	514
q12	763	793	633	633
q13	3533	4018	3431	3431
q14	296	301	286	286
q15	534	515	480	480
q16	1059	1327	1062	1062
q17	1202	1610	1400	1400
q18	7771	7572	7704	7572
q19	862	888	958	888
q20	2028	2019	1816	1816
q21	4666	4463	4303	4303
q22	1089	1046	983	983
Total cold run time: 53345 ms
Total hot run time: 51524 ms

doris-robot · 2025-09-10T05:15:36Z

TPC-DS: Total hot run time: 189150 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 21b0711c4b2551fa1bbc03ef57857e1be88ada47, data reload: false

query1	1061	446	422	422
query2	6595	1705	1736	1705
query3	6757	234	228	228
query4	26062	23297	23197	23197
query5	4423	650	533	533
query6	334	238	216	216
query7	4665	519	302	302
query8	292	267	256	256
query9	8621	2904	2877	2877
query10	459	345	295	295
query11	16080	14930	14711	14711
query12	195	119	115	115
query13	1674	562	430	430
query14	10870	9131	9031	9031
query15	213	198	172	172
query16	7392	682	480	480
query17	1224	769	613	613
query18	2027	430	331	331
query19	202	196	188	188
query20	134	126	127	126
query21	214	132	118	118
query22	4063	4177	4054	4054
query23	33753	33135	33137	33135
query24	8209	2401	2413	2401
query25	600	546	480	480
query26	1251	301	173	173
query27	2712	521	362	362
query28	4430	2253	2248	2248
query29	809	593	493	493
query30	290	222	206	206
query31	917	768	721	721
query32	95	81	82	81
query33	577	440	355	355
query34	804	849	523	523
query35	807	815	765	765
query36	963	999	928	928
query37	125	123	92	92
query38	3546	3514	3514	3514
query39	1510	1478	1411	1411
query40	225	136	129	129
query41	63	63	58	58
query42	145	124	124	124
query43	519	506	479	479
query44	1372	863	863	863
query45	179	177	172	172
query46	851	1006	648	648
query47	1752	1797	1725	1725
query48	393	428	319	319
query49	765	520	422	422
query50	645	685	400	400
query51	3961	3940	3886	3886
query52	118	113	107	107
query53	263	268	193	193
query54	622	613	549	549
query55	95	93	91	91
query56	378	360	336	336
query57	1203	1181	1148	1148
query58	304	284	281	281
query59	2550	2638	2565	2565
query60	360	366	352	352
query61	164	164	163	163
query62	833	736	703	703
query63	232	198	192	192
query64	4514	1138	839	839
query65	4025	3985	3962	3962
query66	1172	448	362	362
query67	15406	15154	15277	15154
query68	7949	933	587	587
query69	513	336	293	293
query70	1354	1293	1250	1250
query71	589	351	334	334
query72	5853	5040	5292	5040
query73	722	704	361	361
query74	9126	9106	9021	9021
query75	3537	3237	2767	2767
query76	3256	1150	727	727
query77	712	413	333	333
query78	9473	9620	8855	8855
query79	2209	839	572	572
query80	712	577	521	521
query81	476	267	229	229
query82	456	175	142	142
query83	265	267	255	255
query84	259	111	93	93
query85	923	473	447	447
query86	343	335	310	310
query87	3687	3717	3635	3635
query88	3384	2182	2216	2182
query89	401	327	286	286
query90	1949	229	224	224
query91	160	167	141	141
query92	93	73	72	72
query93	1210	978	660	660
query94	762	431	305	305
query95	416	336	337	336
query96	479	581	278	278
query97	2949	2962	2880	2880
query98	256	230	214	214
query99	1667	1433	1290	1290
Total cold run time: 274204 ms
Total hot run time: 189150 ms

doris-robot · 2025-09-10T05:21:04Z

ClickBench: Total hot run time: 29.96 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 21b0711c4b2551fa1bbc03ef57857e1be88ada47, data reload: false

query1	0.05	0.05	0.05
query2	0.09	0.05	0.05
query3	0.27	0.09	0.09
query4	1.63	0.11	0.12
query5	0.28	0.26	0.25
query6	1.19	0.65	0.65
query7	0.03	0.03	0.03
query8	0.06	0.05	0.05
query9	0.64	0.52	0.51
query10	0.58	0.58	0.58
query11	0.17	0.11	0.12
query12	0.15	0.13	0.12
query13	0.63	0.63	0.63
query14	1.01	1.02	1.02
query15	0.87	0.87	0.89
query16	0.41	0.42	0.40
query17	1.06	1.03	1.06
query18	0.22	0.20	0.20
query19	1.97	1.87	1.87
query20	0.02	0.01	0.02
query21	15.43	0.95	0.58
query22	0.77	1.14	0.67
query23	14.99	1.40	0.62
query24	6.84	1.05	0.76
query25	0.52	0.16	0.17
query26	0.68	0.15	0.13
query27	0.06	0.05	0.06
query28	9.10	0.95	0.44
query29	12.54	3.94	3.27
query30	0.28	0.13	0.13
query31	2.82	0.58	0.39
query32	3.25	0.56	0.47
query33	3.12	3.10	3.12
query34	15.98	5.49	4.80
query35	4.94	4.91	4.86
query36	0.70	0.51	0.51
query37	0.11	0.08	0.07
query38	0.06	0.05	0.04
query39	0.04	0.03	0.03
query40	0.17	0.15	0.16
query41	0.08	0.04	0.03
query42	0.04	0.04	0.03
query43	0.05	0.04	0.04
Total cold run time: 103.9 s
Total hot run time: 29.96 s

hello-stephen · 2025-09-10T06:32:33Z

BE UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	52.02% (17299/33255)
Line Coverage	37.33% (157603/422135)
Region Coverage	31.94% (120191/376344)
Branch Coverage	33.34% (52815/158422)

airborne12

LGTM

github-actions · 2025-09-10T06:56:10Z

PR approved by at least one committer and no changes requested.

github-actions · 2025-09-10T06:56:13Z

PR approved by anyone and no changes requested.

hello-stephen · 2025-09-10T07:52:33Z

BE Regression && UT Coverage Report

Increment line coverage 100% (0/0) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	70.72% (23073/32627)
Line Coverage	57.09% (240749/421677)
Region Coverage	52.65% (200947/381634)
Branch Coverage	54.22% (86355/159260)

csun5285

LGTM

hello-stephen · 2025-09-10T11:55:01Z

BE Regression && UT Coverage Report

Increment line coverage 100% (0/0) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	70.72% (23073/32627)
Line Coverage	57.09% (240749/421677)
Region Coverage	52.65% (200947/381634)
Branch Coverage	54.22% (86355/159260)

hello-stephen · 2025-09-10T13:42:32Z

BE Regression && UT Coverage Report

Increment line coverage 100% (0/0) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	70.72% (23073/32627)
Line Coverage	57.09% (240749/421677)
Region Coverage	52.65% (200947/381634)
Branch Coverage	54.22% (86355/159260)

hello-stephen · 2025-09-11T05:30:51Z

BE Regression && UT Coverage Report

Increment line coverage 100% (0/0) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	70.72% (23073/32627)
Line Coverage	57.09% (240749/421677)
Region Coverage	52.65% (200947/381634)
Branch Coverage	54.22% (86355/159260)

[opt](agg) remove experimental functions approx_top_k and approx_top_sum

21b0711

zzzxl1993 force-pushed the 202509101037 branch from f9879cb to 21b0711 Compare September 10, 2025 03:53

airborne12 approved these changes Sep 10, 2025

View reviewed changes

github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Sep 10, 2025

csun5285 approved these changes Sep 10, 2025

View reviewed changes

airborne12 merged commit a15c88c into apache:master Sep 11, 2025
25 of 29 checks passed

[opt](agg) remove experimental functions approx_top_k and approx_top_sum #55845

[opt](agg) remove experimental functions approx_top_k and approx_top_sum #55845

Uh oh!

Conversation

zzzxl1993 commented Sep 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

Release note

Check List (For Author)

Check List (For Reviewer who merge this PR)

Uh oh!

Thearas commented Sep 10, 2025

Uh oh!

zzzxl1993 commented Sep 10, 2025

Uh oh!

zzzxl1993 commented Sep 10, 2025

Uh oh!

doris-robot commented Sep 10, 2025

Uh oh!

doris-robot commented Sep 10, 2025

Uh oh!

doris-robot commented Sep 10, 2025

Uh oh!

hello-stephen commented Sep 10, 2025

BE UT Coverage Report

Uh oh!

airborne12 left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Sep 10, 2025

Uh oh!

github-actions bot commented Sep 10, 2025

Uh oh!

hello-stephen commented Sep 10, 2025

BE Regression && UT Coverage Report

Uh oh!

csun5285 left a comment

Choose a reason for hiding this comment

Uh oh!

hello-stephen commented Sep 10, 2025

BE Regression && UT Coverage Report

Uh oh!

hello-stephen commented Sep 10, 2025

BE Regression && UT Coverage Report

Uh oh!

hello-stephen commented Sep 11, 2025

BE Regression && UT Coverage Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

zzzxl1993 commented Sep 10, 2025 •

edited

Loading