Skip to content

[opt](hive) remove some unused code #55889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zy-kkk merged 1 commit into from
Sep 11, 2025
Merged

[opt](hive) remove some unused code #55889

zy-kkk merged 1 commit into from
Sep 11, 2025

Conversation

@morningman
Copy link
Contributor

@morningman morningman commented Sep 10, 2025 •
edited
Loading

What problem does this PR solve?

  1. remove unused code
  2. add some ut for loading cache

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

hello-stephen commented Sep 10, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@morningman
Copy link
Contributor Author

morningman commented Sep 10, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Sep 10, 2025

TPC-H: Total hot run time: 34494 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 92e058fdcebd6c8402dd0f3b387b4e77665c2dc9, data reload: false

------ Round 1 ----------------------------------
q1	17633	5202	5046	5046
q2	1983	353	217	217
q3	10226	1274	693	693
q4	10239	1016	529	529
q5	7560	2452	2305	2305
q6	180	165	135	135
q7	920	777	629	629
q8	9348	1327	1146	1146
q9	6805	5162	5138	5138
q10	6952	2379	1976	1976
q11	484	297	283	283
q12	371	364	222	222
q13	17796	3632	3072	3072
q14	234	240	210	210
q15	564	486	496	486
q16	990	984	938	938
q17	605	855	371	371
q18	7473	6974	7081	6974
q19	1336	958	553	553
q20	352	343	235	235
q21	3876	2550	2347	2347
q22	1064	1053	989	989
Total cold run time: 106991 ms
Total hot run time: 34494 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5090	5076	5082	5076
q2	246	331	232	232
q3	2212	2708	2256	2256
q4	1359	1793	1319	1319
q5	4205	4402	4622	4402
q6	212	181	137	137
q7	2068	1949	1819	1819
q8	2607	2641	2564	2564
q9	7379	7554	7504	7504
q10	3100	3298	2841	2841
q11	571	513	508	508
q12	701	814	639	639
q13	3505	3908	3408	3408
q14	282	514	331	331
q15	526	500	476	476
q16	1060	1120	1046	1046
q17	1141	1542	1416	1416
q18	7922	7800	7619	7619
q19	813	823	838	823
q20	1996	2180	1976	1976
q21	4636	4382	4214	4214
q22	1057	1038	1016	1016
Total cold run time: 52688 ms
Total hot run time: 51622 ms

@doris-robot
Copy link

doris-robot commented Sep 10, 2025

TPC-DS: Total hot run time: 186880 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 92e058fdcebd6c8402dd0f3b387b4e77665c2dc9, data reload: false

query1	1083	438	399	399
query2	6570	1724	1752	1724
query3	6760	231	232	231
query4	26196	23627	23144	23144
query5	4453	647	544	544
query6	372	275	260	260
query7	4660	518	302	302
query8	310	270	256	256
query9	8667	2926	2895	2895
query10	501	380	297	297
query11	15421	15024	14885	14885
query12	168	121	114	114
query13	1677	546	438	438
query14	10809	9312	9340	9312
query15	224	192	171	171
query16	7628	639	489	489
query17	1243	730	619	619
query18	2048	451	329	329
query19	199	195	172	172
query20	144	131	123	123
query21	212	129	118	118
query22	4094	4099	4148	4099
query23	33693	32738	32861	32738
query24	8126	2403	2415	2403
query25	591	561	486	486
query26	1243	278	175	175
query27	2720	510	367	367
query28	4394	2273	2240	2240
query29	813	655	544	544
query30	297	221	195	195
query31	905	800	755	755
query32	92	85	82	82
query33	603	411	370	370
query34	795	862	524	524
query35	840	828	777	777
query36	977	1059	944	944
query37	135	126	99	99
query38	3583	3566	3569	3566
query39	1489	1450	1427	1427
query40	239	145	133	133
query41	70	126	62	62
query42	132	120	118	118
query43	536	525	466	466
query44	1383	876	859	859
query45	184	186	176	176
query46	854	1010	657	657
query47	1758	1795	1724	1724
query48	397	434	320	320
query49	757	513	430	430
query50	655	682	405	405
query51	3944	3910	3878	3878
query52	115	116	120	116
query53	255	275	200	200
query54	654	606	541	541
query55	95	87	93	87
query56	342	340	328	328
query57	1205	1182	1116	1116
query58	291	286	281	281
query59	2566	2616	2461	2461
query60	359	357	356	356
query61	169	159	162	159
query62	817	760	700	700
query63	233	201	205	201
query64	4425	1162	854	854
query65	4110	3970	3958	3958
query66	1132	441	400	400
query67	15189	15201	15196	15196
query68	9101	937	598	598
query69	494	331	299	299
query70	1379	1344	1216	1216
query71	566	366	325	325
query72	5979	2655	5347	2655
query73	816	789	364	364
query74	9310	9174	8743	8743
query75	4388	3241	2767	2767
query76	3684	1146	761	761
query77	899	411	333	333
query78	9644	9715	8848	8848
query79	2323	841	601	601
query80	684	587	529	529
query81	470	274	245	245
query82	441	167	135	135
query83	301	344	270	270
query84	301	109	91	91
query85	864	467	431	431
query86	347	323	300	300
query87	3689	3755	3647	3647
query88	3038	2194	2212	2194
query89	402	329	301	301
query90	1925	237	226	226
query91	164	174	139	139
query92	92	74	81	74
query93	1305	1024	636	636
query94	697	416	328	328
query95	408	332	342	332
query96	483	581	283	283
query97	2938	2944	2880	2880
query98	260	218	213	213
query99	1453	1384	1321	1321
Total cold run time: 276446 ms
Total hot run time: 186880 ms

@doris-robot
Copy link

doris-robot commented Sep 10, 2025

ClickBench: Total hot run time: 30.79 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 92e058fdcebd6c8402dd0f3b387b4e77665c2dc9, data reload: false

query1	0.06	0.05	0.06
query2	0.09	0.05	0.05
query3	0.26	0.09	0.09
query4	1.61	0.12	0.11
query5	0.28	0.27	0.26
query6	1.16	0.67	0.63
query7	0.04	0.03	0.03
query8	0.05	0.04	0.04
query9	0.62	0.53	0.54
query10	0.58	0.56	0.58
query11	0.16	0.11	0.11
query12	0.15	0.12	0.12
query13	0.64	0.63	0.61
query14	1.03	1.03	1.04
query15	0.87	0.85	0.86
query16	0.40	0.41	0.41
query17	1.03	1.05	1.02
query18	0.22	0.20	0.22
query19	1.97	1.85	1.85
query20	0.01	0.01	0.01
query21	15.40	0.95	0.59
query22	0.81	1.14	0.94
query23	14.75	1.41	0.64
query24	6.80	2.11	1.38
query25	0.48	0.13	0.12
query26	0.51	0.16	0.14
query27	0.06	0.05	0.06
query28	10.45	0.90	0.44
query29	12.64	3.90	3.29
query30	0.31	0.13	0.10
query31	2.83	0.60	0.40
query32	3.23	0.55	0.47
query33	3.11	3.02	3.09
query34	16.00	5.40	4.87
query35	4.96	4.89	4.92
query36	0.70	0.52	0.53
query37	0.10	0.07	0.07
query38	0.07	0.05	0.04
query39	0.04	0.03	0.03
query40	0.18	0.14	0.14
query41	0.09	0.03	0.02
query42	0.04	0.03	0.03
query43	0.05	0.04	0.04
Total cold run time: 104.84 s
Total hot run time: 30.79 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Sep 11, 2025

FE Regression Coverage Report

Increment line coverage 100.00% (1/1) 🎉
Increment coverage report
Complete coverage report

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 11, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 11, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 11, 2025

PR approved by anyone and no changes requested.

@zy-kkk zy-kkk merged commit 2033211 into apache:master Sep 11, 2025
29 of 31 checks passed
morningman added a commit to morningman/doris that referenced this pull request Sep 11, 2025
@morningman
[opt](hive) remove some unused code (apache#55889)
1f40343 
1. remove unused code
2. add some ut for loading cache
@morningman morningman mentioned this pull request Sep 11, 2025
Merged
morningman added a commit that referenced this pull request Sep 11, 2025
@morningman
branch-3.1: [opt](hive) remove some unused code (#55889) (#55911)
f7b5506 
#55889
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CalvinKirs CalvinKirs CalvinKirs approved these changes

@zy-kkk zy-kkk zy-kkk approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.x dev/3.0.x-conflict dev/3.1.1-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@morningman @hello-stephen @doris-robot @CalvinKirs @zy-kkk