-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[Opt](MergeIO) make read slice size is configurable #55936
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
78aac9b to
84235f2
Compare
|
run buildall |
Cloud UT Coverage ReportIncrement line coverage Increment coverage report
|
|
run buildall |
Cloud UT Coverage ReportIncrement line coverage Increment coverage report
|
TPC-H: Total hot run time: 35261 ms |
TPC-DS: Total hot run time: 189327 ms |
ClickBench: Total hot run time: 30.83 s |
|
run buildall |
Cloud UT Coverage ReportIncrement line coverage Increment coverage report
|
TPC-H: Total hot run time: 34788 ms |
TPC-DS: Total hot run time: 189473 ms |
ClickBench: Total hot run time: 0.09 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
FE Regression Coverage ReportIncrement line coverage |
|
run vault_p0 |
morningman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
d42c4bd to
88d73d2
Compare
|
run buildall |
Cloud UT Coverage ReportIncrement line coverage Increment coverage report
|
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
FE Regression Coverage ReportIncrement line coverage |
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
dataroaring
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Make the `read slice size` variable configurable to reduce the impact caused by read amplification. Co-authored-by: garenshi <garenshi@tencnet.com>
### What problem does this PR solve? Make the `read slice size` variable configurable to reduce the impact caused by read amplification. Co-authored-by: garenshi <garenshi@tencnet.com>
…he#55936) (apache#5214) close apache#4875 --------- Co-authored-by: shee <13843187+qzsee@users.noreply.github.com> Co-authored-by: garenshi <garenshi@tencnet.com>
What problem does this PR solve?
Make the
read slice sizevariable configurable to reduce the impact caused by read amplification.Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)