Skip to content

branch-2.1: [Fix](cast) Fix lost of cast for nested type with precision (#54824) #55974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
zclllyybb wants to merge 1 commit into from
Closed

branch-2.1: [Fix](cast) Fix lost of cast for nested type with precision (#54824) #55974

zclllyybb wants to merge 1 commit into from

Conversation

@zclllyybb
Copy link
Contributor

@zclllyybb zclllyybb commented Sep 12, 2025

pick #54824

@zclllyybb
[Fix](cast) Fix lost of cast for nested type with precision (apache#5…
8f76077 
…4824)

before, we wrongly thought types like `array<datetime(x)>` and
`array<datetime(y)>` is same. it's wrong. it would lead to missing of
cast when translate CastExpr to thrift.
@zclllyybb zclllyybb requested a review from yiguolei as a code owner September 12, 2025 09:19
@Thearas
Copy link
Contributor

Thearas commented Sep 12, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zclllyybb
Copy link
Contributor Author

zclllyybb commented Sep 12, 2025

run buildall

@zclllyybb zclllyybb closed this Oct 21, 2025
@zclllyybb zclllyybb deleted the fix_nest_type_fe_21 branch October 21, 2025 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguolei yiguolei Awaiting requested review from yiguolei yiguolei is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zclllyybb @Thearas