Skip to content

Conversation

@w41ter
Copy link
Contributor

@w41ter w41ter commented Sep 17, 2025

…ing definitions

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Sep 17, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@w41ter
Copy link
Contributor Author

w41ter commented Sep 17, 2025

run buildall

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Sep 17, 2025
@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@gavinchou gavinchou changed the title [chore](cloud) add DORIS_ADDITIONAL_DEFINITIONS to expose the underly… [chore](cloud) add DORIS_ADDITIONAL_DEFINITIONS to expose the underlying definitions Sep 17, 2025
@dataroaring dataroaring merged commit 37f9b46 into apache:master Sep 17, 2025
33 of 34 checks passed
@w41ter w41ter deleted the fix_add_definitions branch September 18, 2025 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. cloud reviewed snapshot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants