Skip to content

[opt](function) Make coalesce support more types #56430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mrhhsg merged 1 commit into from
Oct 14, 2025
Merged

[opt](function) Make coalesce support more types #56430

mrhhsg merged 1 commit into from
Oct 14, 2025

Conversation

@mrhhsg
Copy link
Member

@mrhhsg mrhhsg commented Sep 25, 2025 •
edited
Loading

What problem does this PR solve?

Add support for types:

  1. JSON
  2. Array
  3. MAP
  4. Struct

Doc: apache/doris-website#2793

Related PR: #55672 (which this PR depends on.)

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Sep 25, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

zclllyybb
zclllyybb reviewed Sep 25, 2025
View reviewed changes
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 12, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 12, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 12, 2025

PR approved by anyone and no changes requested.

@yiguolei yiguolei closed this Oct 12, 2025
@yiguolei yiguolei reopened this Oct 12, 2025
@yiguolei
Copy link
Contributor

yiguolei commented Oct 12, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Oct 12, 2025

TPC-DS: Total hot run time: 190776 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 6c8f61b1ced4f8aff8f6fd1bf94c48b5b2d3880c, data reload: false

query1	1037	451	414	414
query2	6570	1678	1671	1671
query3	6749	235	227	227
query4	26137	23354	23539	23354
query5	5471	648	495	495
query6	330	236	222	222
query7	4665	499	289	289
query8	299	264	257	257
query9	8695	2550	2537	2537
query10	526	334	278	278
query11	15725	15735	15745	15735
query12	187	121	115	115
query13	1726	578	481	481
query14	12460	9563	9622	9563
query15	256	221	208	208
query16	8394	716	517	517
query17	1751	826	667	667
query18	2084	438	347	347
query19	232	215	204	204
query20	145	123	124	123
query21	220	131	120	120
query22	4548	4775	4845	4775
query23	34922	34065	33064	33064
query24	8164	2361	2429	2361
query25	576	509	444	444
query26	1232	274	154	154
query27	2691	501	351	351
query28	4276	2150	2141	2141
query29	793	613	518	518
query30	301	231	202	202
query31	907	860	772	772
query32	83	83	73	73
query33	596	375	365	365
query34	782	858	526	526
query35	798	873	741	741
query36	987	999	925	925
query37	134	110	89	89
query38	3462	3505	3471	3471
query39	1484	1457	1426	1426
query40	226	128	113	113
query41	59	59	61	59
query42	124	109	114	109
query43	466	503	475	475
query44	1326	826	822	822
query45	187	182	170	170
query46	838	995	642	642
query47	1777	1813	1736	1736
query48	386	414	311	311
query49	772	513	411	411
query50	634	696	422	422
query51	3902	4034	3863	3863
query52	114	118	98	98
query53	281	269	188	188
query54	601	598	541	541
query55	90	82	83	82
query56	323	338	313	313
query57	1192	1209	1123	1123
query58	285	285	282	282
query59	2606	2639	2550	2550
query60	352	337	331	331
query61	161	146	151	146
query62	787	732	670	670
query63	236	196	187	187
query64	4373	1142	936	936
query65	4070	3996	3960	3960
query66	1065	453	354	354
query67	15348	15512	15364	15364
query68	7965	951	606	606
query69	523	329	303	303
query70	1366	1248	1318	1248
query71	501	344	331	331
query72	5990	4836	4729	4729
query73	621	562	366	366
query74	8865	9075	8748	8748
query75	3824	3403	2880	2880
query76	3506	1171	741	741
query77	794	408	308	308
query78	9666	9891	8799	8799
query79	2319	848	580	580
query80	656	572	499	499
query81	507	268	228	228
query82	489	163	133	133
query83	266	269	247	247
query84	263	121	90	90
query85	896	485	427	427
query86	389	297	290	290
query87	3697	3811	3741	3741
query88	3763	2267	2287	2267
query89	397	345	296	296
query90	2003	221	215	215
query91	159	165	143	143
query92	90	74	66	66
query93	2064	994	634	634
query94	676	421	336	336
query95	406	334	327	327
query96	485	585	293	293
query97	2938	2992	2889	2889
query98	244	216	215	215
query99	1360	1426	1321	1321
Total cold run time: 280664 ms
Total hot run time: 190776 ms

@doris-robot
Copy link

doris-robot commented Oct 12, 2025

ClickBench: Total hot run time: 29.88 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 6c8f61b1ced4f8aff8f6fd1bf94c48b5b2d3880c, data reload: false

query1	0.06	0.05	0.05
query2	0.10	0.06	0.05
query3	0.24	0.08	0.08
query4	1.60	0.12	0.11
query5	0.28	0.26	0.25
query6	1.19	0.65	0.64
query7	0.03	0.02	0.03
query8	0.06	0.04	0.04
query9	0.62	0.53	0.52
query10	0.59	0.58	0.57
query11	0.16	0.11	0.12
query12	0.15	0.12	0.11
query13	0.64	0.62	0.60
query14	1.02	1.03	1.02
query15	0.87	0.84	0.87
query16	0.39	0.40	0.40
query17	1.07	1.07	1.05
query18	0.21	0.20	0.20
query19	1.92	1.86	1.88
query20	0.02	0.01	0.01
query21	15.44	0.91	0.57
query22	0.76	1.23	0.66
query23	14.95	1.42	0.59
query24	7.59	0.82	0.38
query25	0.49	0.22	0.12
query26	0.59	0.16	0.13
query27	0.06	0.07	0.06
query28	9.40	1.36	0.91
query29	12.54	3.95	3.27
query30	0.28	0.13	0.14
query31	2.84	0.59	0.39
query32	3.26	0.55	0.48
query33	3.13	3.07	3.06
query34	16.29	5.45	4.82
query35	4.92	4.90	4.90
query36	0.69	0.52	0.51
query37	0.11	0.08	0.07
query38	0.07	0.05	0.05
query39	0.04	0.03	0.03
query40	0.17	0.14	0.14
query41	0.09	0.03	0.02
query42	0.04	0.04	0.03
query43	0.05	0.04	0.03
Total cold run time: 105.02 s
Total hot run time: 29.88 s

@doris-robot
Copy link

doris-robot commented Oct 13, 2025

BE UT Coverage Report

Increment line coverage 100.00% (9/9) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.53% (17750/33793)
Line Coverage 37.71% (161197/427461)
Region Coverage 32.21% (123177/382415)
Branch Coverage 33.59% (54006/160763)

@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 13, 2025

BE Regression && UT Coverage Report

Increment line coverage 100.00% (9/9) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.12% (23550/33111)
Line Coverage 57.59% (245932/427050)
Region Coverage 52.74% (204253/387247)
Branch Coverage 54.52% (88096/161578)

@mrhhsg mrhhsg merged commit 7f41367 into apache:master Oct 14, 2025
42 of 47 checks passed
@mrhhsg mrhhsg deleted the opt_coalesce2 branch November 6, 2025 05:54
github-actions bot pushed a commit that referenced this pull request Nov 6, 2025
@mrhhsg
[opt](function) Make coalesce support more types (#56430)
b27aeb4 
### What problem does this PR solve?

Add support for types:
1. JSON
2. Array
3. MAP
4. Struct

Doc: apache/doris-website#2793

Related PR: #xxx

Problem Summary:

### Release note

None

### Check List (For Author)

- Test <!-- At least one of them must be included. -->
    - [ ] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [ ] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

### Check List (For Reviewer who merge this PR)

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
@github-actions github-actions bot mentioned this pull request Nov 6, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguolei yiguolei yiguolei approved these changes

@zclllyybb zclllyybb zclllyybb approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@mrhhsg @Thearas @yiguolei @doris-robot @hello-stephen @zclllyybb @morrySnow