-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix](sql cache) fix sql cache use legacy cache when use some special session variables and audit log's HitSqlCache not working #56434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix](sql cache) fix sql cache use legacy cache when use some special session variables and audit log's HitSqlCache not working #56434
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
|
run buildall |
|
run buildall |
ClickBench: Total hot run time: 30.04 s |
morrySnow
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test case?
FE Regression Coverage ReportIncrement line coverage |
the test case already exists in |
dataroaring
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
shuke987
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
… session variables and audit log's HitSqlCache not working (#56434) ### What problem does this PR solve? 1. fix sql cache use legacy cache when use some special session variables, and make some regression test unstable - skip_delete_predicate - skip_delete_sign - skip_delete_bitmap - skip_missing_version - skip_bad_tablet - skip_storage_engine_merge - show_hidden_columns 2. fix audit log's HitSqlCache not working because not set stmtType for LogicalSqlCache
What problem does this PR solve?
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)