Skip to content

Conversation

@924060929
Copy link
Contributor

@924060929 924060929 commented Sep 25, 2025

What problem does this PR solve?

  1. fix sql cache use legacy cache when use some special session variables, and make some regression test unstable
  • skip_delete_predicate
  • skip_delete_sign
  • skip_delete_bitmap
  • skip_missing_version
  • skip_bad_tablet
  • skip_storage_engine_merge
  • show_hidden_columns
  1. fix audit log's HitSqlCache not working because not set stmtType for LogicalSqlCache

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@924060929 924060929 changed the title [fix](sql cache) fix sql cache with some special session variables and audit log's HitSqlCache not working [fix](sql cache) fix sql cache use legacy cache when use some special session variables and audit log's HitSqlCache not working Sep 25, 2025
@924060929
Copy link
Contributor Author

run buildall

@924060929
Copy link
Contributor Author

run buildall

@924060929
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

ClickBench: Total hot run time: 30.04 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 62ce998d5f9d073de5bc0328a5a10bdc893c0378, data reload: false

query1	0.06	0.04	0.04
query2	0.08	0.05	0.06
query3	0.26	0.08	0.08
query4	1.60	0.12	0.12
query5	0.28	0.26	0.25
query6	1.18	0.65	0.65
query7	0.03	0.03	0.03
query8	0.05	0.04	0.04
query9	0.63	0.55	0.53
query10	0.59	0.58	0.58
query11	0.16	0.12	0.11
query12	0.16	0.12	0.12
query13	0.62	0.62	0.61
query14	1.03	1.04	1.02
query15	0.87	0.85	0.86
query16	0.40	0.40	0.40
query17	1.06	1.06	1.04
query18	0.22	0.19	0.20
query19	1.99	1.83	1.86
query20	0.01	0.01	0.02
query21	15.46	0.95	0.62
query22	0.76	1.13	0.71
query23	14.96	1.38	0.66
query24	7.03	0.95	0.40
query25	0.50	0.12	0.08
query26	0.60	0.16	0.14
query27	0.07	0.06	0.04
query28	9.32	1.40	0.92
query29	12.61	3.85	3.21
query30	0.28	0.14	0.12
query31	2.82	0.58	0.40
query32	3.26	0.56	0.48
query33	3.04	3.08	3.15
query34	16.22	5.45	4.89
query35	4.97	4.88	4.90
query36	0.70	0.50	0.49
query37	0.10	0.08	0.08
query38	0.07	0.05	0.04
query39	0.04	0.03	0.04
query40	0.19	0.14	0.13
query41	0.10	0.04	0.03
query42	0.04	0.03	0.03
query43	0.04	0.03	0.04
Total cold run time: 104.46 s
Total hot run time: 30.04 s

Copy link
Contributor

@morrySnow morrySnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test case?

@hello-stephen
Copy link
Contributor

FE Regression Coverage Report

Increment line coverage 81.82% (9/11) 🎉
Increment coverage report
Complete coverage report

@924060929
Copy link
Contributor Author

test case?

the test case already exists in compaction/test_full_compaction_ck.groovy and unique_with_mow_p0/partial_update/test_partial_update_delete_sign.groovy but not stable

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 26, 2025
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

Copy link
Collaborator

@shuke987 shuke987 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 64395bc into apache:master Sep 28, 2025
30 of 32 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 28, 2025
… session variables and audit log's HitSqlCache not working (#56434)

### What problem does this PR solve?

1. fix sql cache use legacy cache when use some special session
variables, and make some regression test unstable
  - skip_delete_predicate
  - skip_delete_sign
  - skip_delete_bitmap
  - skip_missing_version
  - skip_bad_tablet
  - skip_storage_engine_merge
  - show_hidden_columns
2. fix audit log's HitSqlCache not working because not set stmtType for
LogicalSqlCache
yiguolei pushed a commit that referenced this pull request Sep 28, 2025
…some special session variables and audit log's HitSqlCache not working #56434 (#56530)

Cherry-picked from #56434

Co-authored-by: 924060929 <lanhuajian@selectdb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/4.0.0-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants