Skip to content

Conversation

@github-actions
Copy link
Contributor

Cherry-picked from #56416

### What problem does this PR solve?

1. Simplify `change catalog/db` and `init db` logic. No need to check
existence twice.
2. Fix bug that missing `sendResponsePacket(context);` if name is
invalid

Before:
```
mysql -h [127.0.0.1](http://127.0.0.1/) -P 9033 -uroot -D iceberg2.da
ERROR 2013 (HY000): Lost connection to MySQL server at 'reading authorization packet', system error: 2
```

After
```
mysql -h [127.0.0.1](http://127.0.0.1/) -P 9033 -uroot -D iceberg2.da
ERROR 5086 (42000): errCode = 2, detailMessage = Unknown catalog 'iceberg2'
```
@Thearas
Copy link
Contributor

Thearas commented Sep 25, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Sep 25, 2025
@Thearas
Copy link
Contributor

Thearas commented Sep 25, 2025

run buildall

@doris-robot
Copy link

ClickBench: Total hot run time: 29.97 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit cd3455efc9f04b285fe556411b8ecc314208964b, data reload: true

query1	0.03	0.04	0.03
query2	0.11	0.05	0.04
query3	0.28	0.07	0.07
query4	1.75	0.11	0.12
query5	0.27	0.24	0.25
query6	1.26	0.64	0.64
query7	0.02	0.03	0.01
query8	0.06	0.04	0.04
query9	0.63	0.51	0.51
query10	0.59	0.58	0.57
query11	0.18	0.11	0.11
query12	0.16	0.11	0.12
query13	0.63	0.61	0.61
query14	0.80	0.82	0.82
query15	0.88	0.85	0.84
query16	0.39	0.40	0.40
query17	1.02	1.04	1.06
query18	0.20	0.20	0.19
query19	1.97	1.86	1.79
query20	0.02	0.02	0.01
query21	15.45	0.94	0.57
query22	0.82	1.22	0.75
query23	15.03	1.36	0.58
query24	4.63	0.64	0.34
query25	0.32	0.09	0.07
query26	0.43	0.15	0.13
query27	0.06	0.04	0.05
query28	12.42	1.47	0.91
query29	12.71	3.85	3.16
query30	0.30	0.13	0.12
query31	3.01	0.59	0.39
query32	3.32	0.66	0.53
query33	3.28	3.25	3.50
query34	18.06	5.78	5.00
query35	5.01	5.05	5.04
query36	0.77	0.55	0.55
query37	0.10	0.07	0.07
query38	0.05	0.04	0.03
query39	0.04	0.03	0.03
query40	0.19	0.16	0.15
query41	0.09	0.03	0.03
query42	0.04	0.03	0.02
query43	0.04	0.03	0.03
Total cold run time: 107.42 s
Total hot run time: 29.97 s

@morningman morningman merged commit 43b9fd6 into branch-4.0 Sep 25, 2025
22 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants