Skip to content

[fix](nereids) fix copy into fail with no where expression #56549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dataroaring merged 1 commit into from
Sep 28, 2025
Merged

[fix](nereids) fix copy into fail with no where expression #56549

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ...e-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/info/CopyFromDesc.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ public class CopyFromDesc {

public CopyFromDesc(StageAndPattern stageAndPattern) {
this.stageAndPattern = stageAndPattern;
this.fileFilterExpr = Optional.empty();
}

public CopyFromDesc(StageAndPattern stageAndPattern, List<NamedExpression> exprList,
Expand Down Expand Up @@ -105,7 +106,7 @@ public List<String> getTargetColumns() {
*/
public void validate(String fullDbName, TableName tableName, boolean useDeleteSign, String fileType)
throws AnalysisException {
if (exprList == null && fileFilterExpr == null && !useDeleteSign) {
if (exprList == null && !fileFilterExpr.isPresent() && !useDeleteSign) {
return;
}
this.fileColumns = new ArrayList<>();
Expand Down Expand Up @@ -240,7 +241,7 @@ private int getMaxFileColumnId() throws AnalysisException {
exprList.stream().map(expr -> (Expression) expr).collect(Collectors.toList()));
maxId = maxId > maxFileColumnId ? maxId : maxFileColumnId;
}
if (fileFilterExpr != null) {
if (fileFilterExpr.isPresent()) {
int maxFileColumnId = getMaxFileFilterColumnId(Lists.newArrayList(fileFilterExpr.get()));
maxId = maxId > maxFileColumnId ? maxId : maxFileColumnId;
}
Expand Down
Loading