Skip to content

Conversation

@w41ter
Copy link
Contributor

@w41ter w41ter commented Sep 28, 2025

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

and change some column values

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@w41ter
Copy link
Contributor Author

w41ter commented Sep 28, 2025

run buildall

@w41ter w41ter requested a review from mymeiyi September 28, 2025 10:41
@hello-stephen
Copy link
Contributor

Cloud UT Coverage Report

Increment line coverage 100.00% (3/3) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 83.99% (1632/1943)
Line Coverage 68.24% (28826/42241)
Region Coverage 68.47% (14215/20762)
Branch Coverage 58.70% (7565/12888)

@doris-robot
Copy link

ClickBench: Total hot run time: 30.66 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 3c53b5214b973d1a88d6a816d533d201e48105b8, data reload: false

query1	0.05	0.05	0.05
query2	0.09	0.05	0.06
query3	0.25	0.08	0.08
query4	1.61	0.12	0.12
query5	0.28	0.27	0.26
query6	1.19	0.66	0.65
query7	0.03	0.03	0.03
query8	0.06	0.04	0.04
query9	0.62	0.52	0.53
query10	0.59	0.58	0.58
query11	0.16	0.11	0.12
query12	0.16	0.12	0.12
query13	0.63	0.64	0.63
query14	1.05	1.05	1.03
query15	0.87	0.86	0.87
query16	0.40	0.40	0.41
query17	1.03	1.06	1.03
query18	0.21	0.19	0.20
query19	2.01	1.85	1.84
query20	0.02	0.01	0.01
query21	15.42	0.94	0.59
query22	0.78	1.33	0.99
query23	14.72	1.42	0.64
query24	7.09	1.61	0.63
query25	0.53	0.39	0.07
query26	0.57	0.15	0.14
query27	0.06	0.06	0.06
query28	10.28	1.38	0.94
query29	12.55	3.95	3.23
query30	0.28	0.14	0.13
query31	2.82	0.63	0.39
query32	3.24	0.56	0.49
query33	3.19	3.12	3.15
query34	16.17	5.52	4.82
query35	4.93	4.92	4.96
query36	0.69	0.51	0.51
query37	0.10	0.08	0.08
query38	0.06	0.05	0.04
query39	0.04	0.04	0.03
query40	0.18	0.15	0.14
query41	0.09	0.04	0.03
query42	0.04	0.03	0.03
query43	0.05	0.04	0.04
Total cold run time: 105.19 s
Total hot run time: 30.66 s

@hello-stephen
Copy link
Contributor

FE UT Coverage Report

Increment line coverage 100.00% (2/2) 🎉
Increment coverage report
Complete coverage report

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 58.33% (14/24) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.42% (17635/33642)
Line Coverage 37.64% (160213/425689)
Region Coverage 32.17% (122153/379735)
Branch Coverage 33.52% (53576/159843)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 70.83% (17/24) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.21% (23384/32840)
Line Coverage 57.58% (244439/424511)
Region Coverage 52.95% (203732/384757)
Branch Coverage 54.65% (87702/160492)

@hello-stephen
Copy link
Contributor

FE Regression Coverage Report

Increment line coverage 100.00% (2/2) 🎉
Increment coverage report
Complete coverage report

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Sep 28, 2025
@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@gavinchou gavinchou self-requested a review September 28, 2025 17:02
@gavinchou gavinchou merged commit 2523fbd into apache:master Sep 28, 2025
30 of 33 checks passed
@w41ter w41ter deleted the snapshot/fix/internal_schema_cluster_snapshot_table branch September 29, 2025 02:10
w41ter added a commit to w41ter/incubator-doris that referenced this pull request Dec 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. cloud reviewed snapshot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants