Skip to content

Conversation

@cambyzju
Copy link
Contributor

What problem does this PR solve?

The OffsetIndex is defined at the RowGroup and Column Chunk level.
After change RowGroup, we should clear it from last RowGroup

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@cambyzju
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

ClickBench: Total hot run time: 30.74 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit d63ba1a1987e4b4d0d7a425a60ba08fba07edbf5, data reload: false

query1	0.05	0.05	0.05
query2	0.09	0.06	0.05
query3	0.25	0.09	0.08
query4	1.63	0.11	0.12
query5	0.30	0.26	0.26
query6	1.19	0.66	0.67
query7	0.03	0.03	0.03
query8	0.06	0.04	0.05
query9	0.61	0.52	0.52
query10	0.58	0.58	0.58
query11	0.18	0.11	0.12
query12	0.15	0.12	0.12
query13	0.63	0.62	0.62
query14	1.02	1.04	1.03
query15	0.88	0.85	0.86
query16	0.38	0.40	0.40
query17	1.05	1.05	1.04
query18	0.22	0.21	0.20
query19	1.98	1.90	1.85
query20	0.01	0.01	0.02
query21	15.44	0.94	0.57
query22	0.76	1.16	0.62
query23	15.06	1.31	0.67
query24	6.96	1.17	1.08
query25	0.47	0.28	0.06
query26	0.50	0.17	0.14
query27	0.07	0.05	0.06
query28	10.07	1.37	0.92
query29	12.56	3.86	3.24
query30	0.28	0.14	0.12
query31	2.83	0.60	0.38
query32	3.27	0.56	0.48
query33	3.15	3.11	3.20
query34	16.13	5.42	4.89
query35	4.93	4.91	4.91
query36	0.69	0.52	0.51
query37	0.10	0.08	0.07
query38	0.06	0.04	0.04
query39	0.04	0.03	0.03
query40	0.17	0.15	0.15
query41	0.09	0.04	0.03
query42	0.04	0.03	0.02
query43	0.04	0.04	0.04
Total cold run time: 105 s
Total hot run time: 30.74 s

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 100.00% (1/1) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.44% (17644/33648)
Line Coverage 37.64% (160258/425766)
Region Coverage 32.14% (122258/380418)
Branch Coverage 33.53% (53621/159943)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 50.00% (1/2) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.27% (23408/32846)
Line Coverage 57.68% (244915/424595)
Region Coverage 52.98% (203874/384825)
Branch Coverage 54.73% (87855/160536)

@cambyzju cambyzju closed this Oct 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants