[fix](mtmv) Fix create partition mv fail when contain cast and the cast target data type is same to cast source data type #56804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
TPC-DS: Total hot run time: 190517 ms |
ClickBench: Total hot run time: 30.34 s |
Contributor
FE Regression Coverage ReportIncrement line coverage |
morrySnow
reviewed
Oct 11, 2025
| // remove sink | ||
| materializedViewPlan = materializedViewPlan.accept(new DefaultPlanRewriter<Void>() { | ||
| @Override | ||
| public Plan visitLogicalSink(LogicalSink<? extends Plan> logicalSink, Void context) { |
Contributor
Author
There was a problem hiding this comment.
if mv is partitioned and partition roll up, would add date_trunc(col, unit) expr above mv def sql plan, if def sql plan is sink, would add project above sink, this would not cause err now but unreasonable
…st target data type is same to cast source data type
seawinde
force-pushed
the
fix_create_partition_mv_fail_when_use_cast
branch
from
c1115cd to
e80728d
Compare
Contributor
Author
|
run buildall |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 34025 ms |
TPC-DS: Total hot run time: 187432 ms |
ClickBench: Total hot run time: 27.3 s |
Contributor
FE UT Coverage ReportIncrement line coverage `` 🎉 |
yiguolei
pushed a commit
to yiguolei/incubator-doris
that referenced
this pull request
Dec 30, 2025
…st target data type is same to cast source data type apache#56804 (apache#5766) ## Proposed changes It would fail when create partition mv when contain cast and the cast target data type is same to cast source data type such as materialized view def sql is as following l_shipdate data type is `date` ```sql CREATE MATERIALIZED VIEW mv_10086 BUILD IMMEDIATE REFRESH AUTO ON MANUAL partition by(l_shipdate_d) DISTRIBUTED BY RANDOM BUCKETS 2 PROPERTIES ('replication_num' = '1') AS select cast(l_shipdate as DATE) as l_shipdate_d, l_partkey, l_suppkey from lineitem; ``` the pr fix this Issue Number: close #xxx <!--Describe your changes.-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would fail when create partition mv when contain cast and the cast target data type is same to cast source data type
such as materialized view def sql is as following
l_shipdate data type is
dateCREATE MATERIALIZED VIEW mv_10086 BUILD IMMEDIATE REFRESH AUTO ON MANUAL partition by(l_shipdate_d) DISTRIBUTED BY RANDOM BUCKETS 2 PROPERTIES ('replication_num' = '1') AS select cast(l_shipdate as DATE) as l_shipdate_d, l_partkey, l_suppkey from lineitem;the pr fix this
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #44786
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)