Skip to content

[Enchancement](sort) do a little optimization for full sort #56853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
qzsee wants to merge 3 commits into
base: branch-3.0
Choose a base branch
from
Open

[Enchancement](sort) do a little optimization for full sort #56853

qzsee wants to merge 3 commits into from
+25 −14

Conversation

@qzsee
Copy link
Contributor

@qzsee qzsee commented Oct 11, 2025

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

cp from #55317

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@qzsee
[Enchancement](sort) do a little optimization for full sort (apache#5…
d7520b1 
…5317)

### What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

### Release note

None

### Check List (For Author)

- Test <!-- At least one of them must be included. -->
    - [ ] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [ ] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

### Check List (For Reviewer who merge this PR)

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->

---------

Co-authored-by: garenshi <garenshi@tencnet.com>
Co-authored-by: garenshi <garenshi@tencent.com>
@qzsee qzsee requested a review from dataroaring as a code owner October 11, 2025 09:01
@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 11, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@qzsee qzsee changed the title [Enchancement](sort) do a little optimization for full sort #55317 [Enchancement](sort) do a little optimization for full sort Oct 11, 2025
BiteTheDDDDt
BiteTheDDDDt previously approved these changes Oct 11, 2025
View reviewed changes
Copy link
Contributor

@BiteTheDDDDt BiteTheDDDDt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BiteTheDDDDt
Copy link
Contributor

BiteTheDDDDt commented Oct 11, 2025

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 11, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 11, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 11, 2025

PR approved by anyone and no changes requested.

@doris-robot
Copy link

doris-robot commented Oct 11, 2025

BE UT Coverage Report

Increment line coverage 0.00% (0/19) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 42.10% (11245/26712)
Line Coverage 32.62% (96266/295092)
Region Coverage 30.56% (55289/180897)
Branch Coverage 26.88% (27364/101788)

@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 11, 2025

BE Regression && UT Coverage Report

Increment line coverage 73.68% (14/19) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 75.29% (19730/26205)
Line Coverage 68.56% (201408/293777)
Region Coverage 66.62% (120575/181001)
Branch Coverage 59.95% (61221/102112)

@qzsee qzsee requested a review from lide-reed as a code owner December 25, 2025 03:42
HappenLee
HappenLee approved these changes Dec 30, 2025
View reviewed changes
Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BiteTheDDDDt
Copy link
Contributor

BiteTheDDDDt commented Dec 30, 2025

run buildall

@dqz123
Copy link

dqz123 commented Dec 30, 2025

run p0

leeleander
leeleander approved these changes Dec 30, 2025
View reviewed changes
Copy link

@leeleander leeleander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

leeleander
leeleander approved these changes Dec 30, 2025
View reviewed changes
Copy link

@leeleander leeleander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lide-reed
lide-reed approved these changes Dec 30, 2025
View reviewed changes
Copy link
Contributor

@lide-reed lide-reed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lide-reed lide-reed lide-reed approved these changes

@HappenLee HappenLee HappenLee approved these changes

@BiteTheDDDDt BiteTheDDDDt BiteTheDDDDt left review comments

@dataroaring dataroaring Awaiting requested review from dataroaring

+1 more reviewer

@leeleander leeleander leeleander approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.1.x reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@qzsee @hello-stephen @BiteTheDDDDt @doris-robot @dqz123 @lide-reed @leeleander @HappenLee