Skip to content

branch-4.0: [feature](function) support sort_json_object_keys/normalize_json_numbers_to_double function #56576 #56876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yiguolei merged 1 commit into from
Oct 14, 2025
Merged

branch-4.0: [feature](function) support sort_json_object_keys/normalize_json_numbers_to_double function #56576 #56876

yiguolei merged 1 commit into from
Oct 14, 2025

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Oct 12, 2025

Cherry-picked from #56576

@Mryange
[feature](function) support sort_json_object_keys/normalize_json_numb…
2e8e8e0 
…ers_to_double function (#56576)

### What problem does this PR solve?

apache/doris-website#2927

```sql
mysql>   select sort_json_object_keys(cast('{"b":123,"b":456,"a":789}' as json));
+------------------------------------------------------------------+
| sort_json_object_keys(cast('{"b":123,"b":456,"a":789}' as json)) |
+------------------------------------------------------------------+
| {"a":789,"b":123}                                                |
+------------------------------------------------------------------+


mysql> select cast('{"abc": 18446744073709551616}' as json) , normalize_json_numbers_to_double(cast('{"abc": 18446744073709551616}' as json));
+-----------------------------------------------+---------------------------------------------------------------------------------+
| cast('{"abc": 18446744073709551616}' as json) | normalize_json_numbers_to_double(cast('{"abc": 18446744073709551616}' as json)) |
+-----------------------------------------------+---------------------------------------------------------------------------------+
| {"abc":18446744073709551616}                  | {"abc":1.8446744073709552e+19}                                                  |
+-----------------------------------------------+---------------------------------------------------------------------------------+
```




### Release note

None

### Check List (For Author)

- Test <!-- At least one of them must be included. -->
    - [ ] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [ ] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

### Check List (For Reviewer who merge this PR)

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
@github-actions github-actions bot requested a review from yiguolei as a code owner October 12, 2025 06:41
@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 12, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Oct 12, 2025
@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 12, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 12, 2025

FE UT Coverage Report

Increment line coverage `` 🎉
Increment coverage report
Complete coverage report

@doris-robot
Copy link

doris-robot commented Oct 12, 2025

ClickBench: Total hot run time: 30.67 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 2e8e8e067e4107128718f11f4266ccd02a30f52c, data reload: true

query1	0.04	0.04	0.03
query2	0.10	0.04	0.04
query3	0.28	0.07	0.08
query4	1.73	0.11	0.11
query5	0.28	0.25	0.26
query6	1.26	0.64	0.65
query7	0.02	0.02	0.02
query8	0.06	0.04	0.04
query9	0.62	0.52	0.52
query10	0.57	0.57	0.57
query11	0.18	0.11	0.12
query12	0.16	0.12	0.11
query13	0.63	0.63	0.64
query14	0.79	0.83	0.83
query15	0.88	0.84	0.87
query16	0.41	0.39	0.39
query17	1.03	1.03	1.06
query18	0.19	0.20	0.19
query19	1.96	1.89	1.85
query20	0.02	0.01	0.01
query21	15.45	0.92	0.57
query22	0.82	1.03	0.82
query23	15.27	1.32	0.62
query24	16.28	1.51	0.59
query25	2.25	0.42	0.20
query26	0.18	0.19	0.18
query27	0.21	0.20	0.20
query28	1.83	1.03	0.96
query29	12.69	3.99	3.21
query30	0.29	0.12	0.10
query31	3.02	0.57	0.38
query32	3.34	0.55	0.48
query33	3.12	3.11	3.03
query34	16.84	5.63	5.01
query35	5.13	5.15	5.13
query36	0.75	0.55	0.55
query37	0.11	0.07	0.07
query38	0.06	0.04	0.03
query39	0.04	0.03	0.03
query40	0.19	0.15	0.15
query41	0.09	0.03	0.03
query42	0.04	0.03	0.02
query43	0.04	0.03	0.03
Total cold run time: 109.25 s
Total hot run time: 30.67 s

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 14, 2025
@yiguolei yiguolei merged commit 6b2de77 into branch-4.0 Oct 14, 2025
22 of 26 checks passed
@github-actions
Copy link
Contributor Author

github-actions bot commented Oct 14, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor Author

github-actions bot commented Oct 14, 2025

PR approved by anyone and no changes requested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguolei yiguolei yiguolei approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@hello-stephen @doris-robot @yiguolei @dataroaring @Mryange