Skip to content

Conversation

@github-actions
Copy link
Contributor

Cherry-picked from #56963

Fix bug of checking string length of complex type.
When doing substring to truncate nested string column for complex types,
should not use `block->get_by_position(slot_index)`, because the column
returned by this method is the original column of complex type, not the
string column that we want to do substring.
@github-actions github-actions bot requested a review from yiguolei as a code owner October 16, 2025 01:35
@Thearas
Copy link
Contributor

Thearas commented Oct 16, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Oct 16, 2025
@Thearas
Copy link
Contributor

Thearas commented Oct 16, 2025

run buildall

@github-actions
Copy link
Contributor Author

Possible file(s) that should be tracked in LFS detected: 🚨

The following file(s) exceeds the file size limit: 1048576 bytes, as set in the .yml configuration files:

  • regression-test/data/datatype_p0/nested_types/base_cases/one_level_nestedtypes_with_s3data.out

Consider using git-lfs to manage large files.

@github-actions github-actions bot added the lfs-detected! Warning Label for use when LFS is detected in the commits of a Pull Request label Oct 16, 2025
@doris-robot
Copy link

ClickBench: Total hot run time: 30.34 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit f08a55e4a4326c43a6065cbd721c27401a2a28b4, data reload: true

query1	0.03	0.04	0.03
query2	0.10	0.04	0.03
query3	0.28	0.08	0.07
query4	1.73	0.11	0.12
query5	0.26	0.25	0.24
query6	1.24	0.64	0.65
query7	0.03	0.02	0.02
query8	0.06	0.03	0.04
query9	0.65	0.53	0.51
query10	0.58	0.58	0.58
query11	0.19	0.10	0.11
query12	0.16	0.11	0.11
query13	0.63	0.61	0.62
query14	0.79	0.82	0.81
query15	0.88	0.84	0.87
query16	0.40	0.40	0.38
query17	1.07	1.04	1.04
query18	0.19	0.21	0.19
query19	1.92	1.76	1.86
query20	0.02	0.01	0.01
query21	15.45	0.91	0.57
query22	0.81	0.97	1.00
query23	14.91	1.36	0.55
query24	16.31	1.51	0.59
query25	2.24	0.39	0.20
query26	0.18	0.18	0.18
query27	0.21	0.20	0.20
query28	1.78	1.03	0.94
query29	12.73	3.84	3.23
query30	0.31	0.12	0.11
query31	3.00	0.59	0.38
query32	3.32	0.56	0.48
query33	3.01	3.16	3.06
query34	16.88	5.51	4.79
query35	4.74	5.21	5.11
query36	0.76	0.53	0.52
query37	0.09	0.07	0.06
query38	0.05	0.04	0.04
query39	0.04	0.02	0.02
query40	0.20	0.16	0.15
query41	0.08	0.03	0.03
query42	0.04	0.02	0.03
query43	0.06	0.04	0.03
Total cold run time: 108.41 s
Total hot run time: 30.34 s

@yiguolei yiguolei merged commit ce0da8a into branch-4.0 Oct 16, 2025
23 of 27 checks passed
@github-actions github-actions bot deleted the auto-pick-56963-branch-4.0 branch October 16, 2025 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lfs-detected! Warning Label for use when LFS is detected in the commits of a Pull Request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants