Skip to content

Conversation

@sollhui
Copy link
Contributor

@sollhui sollhui commented Oct 17, 2025

What problem does this PR solve?

pick #56780

NSERT_JOB was introduced in #26146, the purpose is to specify the job id for insert job. But there is no need to add a new job type, which would make the code difficult to understand. This pr aim to unified INSERT_JOB to INSERT.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@sollhui sollhui requested a review from yiguolei as a code owner October 17, 2025 07:29
@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@sollhui
Copy link
Contributor Author

sollhui commented Oct 17, 2025

run buildall

…e#56780)

NSERT_JOB was introduced in apache#26146,
the purpose is to specify the job id for insert job. But there is no
need to add a new job type, which would make the code difficult to
understand. This pr aim to unified INSERT_JOB to INSERT.
@sollhui
Copy link
Contributor Author

sollhui commented Oct 17, 2025

run buildall

@yiguolei yiguolei merged commit f115b5d into apache:branch-4.0 Oct 18, 2025
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants