Skip to content

branch-4.0: [Feature](variable) Support session variable lc_time_names #56915 #57293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yiguolei merged 1 commit into from
Oct 24, 2025
Merged

branch-4.0: [Feature](variable) Support session variable lc_time_names #56915 #57293

yiguolei merged 1 commit into from
Oct 24, 2025

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Oct 24, 2025

Cherry-picked from #56915

@linrrzqqq
[Feature](variable) Support session variable lc_time_names (#56915)
026d531 
### What problem does this PR solve?

Issue Number: #48203 

Related PR: #xxx

Problem Summary:

### Release note

Support session variable `lc_time_name`
The supported locale are consistent with
[MySQL](https://dev.mysql.com/doc/refman/8.4/en/locale-support.html).

```text
mysql> SELECT DAYNAME('2025-10-15');
+-----------------------+
| DAYNAME('2025-10-15') |
+-----------------------+
| Wednesday             |
+-----------------------+
1 row in set (0.02 sec)

mysql> SELECT MONTHNAME('2025-10-15');
+-------------------------+
| MONTHNAME('2025-10-15') |
+-------------------------+
| October                 |
+-------------------------+
1 row in set (0.01 sec)

mysql> SET lc_time_names='zh_CN';
Query OK, 0 rows affected (0.00 sec)

mysql> SELECT DAYNAME('2025-10-15');
+-----------------------+
| DAYNAME('2025-10-15') |
+-----------------------+
| 星期三                |
+-----------------------+
1 row in set (0.01 sec)

mysql> SELECT MONTHNAME('2025-10-15');
+-------------------------+
| MONTHNAME('2025-10-15') |
+-------------------------+
| 十月                    |
+-------------------------+
1 row in set (0.02 sec)
```
@github-actions github-actions bot requested a review from yiguolei as a code owner October 24, 2025 04:15
@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 24, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Oct 24, 2025
@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 24, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Oct 24, 2025

FE UT Coverage Report

Increment line coverage `` 🎉
Increment coverage report
Complete coverage report

@yiguolei yiguolei merged commit 6350ffa into branch-4.0 Oct 24, 2025
23 of 27 checks passed
@github-actions github-actions bot deleted the auto-pick-56915-branch-4.0 branch October 24, 2025 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguolei yiguolei yiguolei approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@hello-stephen @yiguolei @dataroaring @linrrzqqq