branch-3.1: [fix](Rollup) When creating a table with rollup and setting a sequence column, we should correctly configure the uniqueId of the sequence column #56143 #57388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e column, we should correctly configure the uniqueId of the sequence column (#56143) Doris version master ```sql CREATE TABLE IF NOT EXISTS users( user_id VARCHAR(32) NOT NULL, event_time DATETIME NOT NULL, val1 BIGINT NOT NULL ) ENGINE=OLAP UNIQUE KEY(user_id, event_time) DISTRIBUTED BY HASH(user_id) BUCKETS 1 ROLLUP ( rlp_spacetime_collision(event_time, user_id) ) PROPERTIES ( "replication_allocation" = "tag.location.default: 1", "function_column.sequence_col" = "event_time" ); mysql> insert into users values(1,'2025-01-01 00:00:00',1);Query OK, 1 row affected (0.18 sec) mysql> select * from users1; ERROR 1105 (HY000): errCode = 2, detailMessage = (9.134.213.24)[E-207]slot(id: 3, name: __DORIS_DELETE_SIGN__)'s nullable does not match column(tablet id: -1, index: 5, name: __DORIS_SEQUENCE_COL__) ``` The reasons are as follows. all `MaterializedIndexMeta` shared one `sequenceCol` ```java public void setSequenceInfo(Type type, Column refColumn) { this.hasSequenceCol = true; this.sequenceType = type; Column sequenceCol; if (getEnableUniqueKeyMergeOnWrite()) { // sequence column is value column with NONE aggregate type for // unique key table with merge on write sequenceCol = ColumnDef.newSequenceColumnDef(type, AggregateType.NONE).toColumn(); } else { // sequence column is value column with REPLACE aggregate type for // unique key table sequenceCol = ColumnDef.newSequenceColumnDef(type, AggregateType.REPLACE).toColumn(); } if (refColumn != null) { sequenceCol.setDefaultValueInfo(refColumn); } // add sequence column at last fullSchema.add(sequenceCol); nameToColumn.put(Column.SEQUENCE_COL, sequenceCol); for (MaterializedIndexMeta indexMeta : indexIdToMeta.values()) { List<Column> schema = indexMeta.getSchema(); schema.add(sequenceCol); } } ``` when init column `uniqueId`, base index sequence column unique id override roullup index sequence column `uniqueId ` ```java public void initSchemaColumnUniqueId() { maxColUniqueId = Column.COLUMN_UNIQUE_ID_INIT_VALUE; this.schema.forEach(column -> { column.setUniqueId(incAndGetMaxColUniqueId()); if (LOG.isDebugEnabled()) { LOG.debug("indexId: {}, column:{}, uniqueId:{}", indexId, column, column.getUniqueId()); } }); } ``` then BE will make an incorrect judgment. ### Release note None ### Check List (For Author) - Test <!-- At least one of them must be included. --> - [ ] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason <!-- Add your reason? --> - Behavior changed: - [ ] No. - [ ] Yes. <!-- Explain the behavior change --> - Does this need documentation? - [ ] No. - [ ] Yes. <!-- Add document PR link here. eg: apache/doris-website#1214 --> ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into --> --------- Co-authored-by: garenshi <garenshi@tencnet.com>
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
|
run buildall |
TPC-H: Total hot run time: 33260 ms |
TPC-DS: Total hot run time: 192784 ms |
ClickBench: Total hot run time: 28.89 s |
morrySnow
approved these changes
Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #56143