[fix](profile) ensure file cache profile stats output in cloud mode by zzzxl1993 · Pull Request #57464 · apache/doris

zzzxl1993 · 2025-10-29T09:05:56Z

introduce by #52118

Remove the query_options().enable_file_cache check in
olap_scanner.cpp when reporting file cache profile statistics. This
check should only apply to external table scanners (FileScanner).

Thearas · 2025-10-29T09:06:02Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

zzzxl1993 · 2025-10-29T09:08:58Z

run buildall

deardeng

LGTM

github-actions · 2025-10-29T09:10:40Z

PR approved by anyone and no changes requested.

doris-robot · 2025-10-29T09:51:38Z

ClickBench: Total hot run time: 29.19 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit e564ba5eb48ddbee17a6f3528d864d5c3355d6f5, data reload: false

query1	0.07	0.05	0.06
query2	0.11	0.07	0.06
query3	0.26	0.09	0.09
query4	1.62	0.13	0.12
query5	0.30	0.28	0.29
query6	1.19	0.69	0.70
query7	0.04	0.03	0.03
query8	0.07	0.06	0.05
query9	0.67	0.56	0.56
query10	0.62	0.62	0.63
query11	0.19	0.14	0.13
query12	0.21	0.14	0.13
query13	0.64	0.63	0.61
query14	1.05	1.05	1.03
query15	0.90	0.90	0.89
query16	0.42	0.41	0.43
query17	1.13	1.21	1.18
query18	0.24	0.22	0.23
query19	2.00	2.00	1.87
query20	0.02	0.01	0.01
query21	15.36	0.20	0.15
query22	5.10	0.07	0.05
query23	15.63	0.31	0.12
query24	3.05	0.96	0.41
query25	0.08	0.07	0.07
query26	0.17	0.15	0.16
query27	0.08	0.06	0.06
query28	4.47	1.23	0.98
query29	12.67	4.68	3.83
query30	0.30	0.16	0.12
query31	2.84	0.68	0.45
query32	3.25	0.57	0.49
query33	3.25	3.17	3.22
query34	15.82	5.21	4.59
query35	4.62	4.62	4.62
query36	0.71	0.55	0.52
query37	0.12	0.08	0.07
query38	0.07	0.05	0.04
query39	0.05	0.04	0.03
query40	0.17	0.15	0.14
query41	0.10	0.03	0.04
query42	0.05	0.03	0.03
query43	0.06	0.05	0.04
Total cold run time: 99.77 s
Total hot run time: 29.19 s

doris-robot · 2025-10-29T10:59:39Z

BE UT Coverage Report

Increment line coverage 0.00% (0/1) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	52.76% (18065/34243)
Line Coverage	37.99% (163815/431223)
Region Coverage	32.36% (124872/385846)
Branch Coverage	33.73% (54612/161927)

hello-stephen · 2025-10-29T11:20:01Z

BE Regression && UT Coverage Report

Increment line coverage 100.00% (1/1) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	71.45% (23969/33548)
Line Coverage	57.88% (249482/431035)
Region Coverage	52.76% (206066/390608)
Branch Coverage	54.63% (88895/162710)

zzzxl1993 · 2025-10-30T03:22:37Z

run buildall

doris-robot · 2025-10-30T05:04:33Z

ClickBench: Total hot run time: 28.45 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit eff8031611dc43fe9af534ebe3d9eeadd1c0fb54, data reload: false

query1	0.06	0.05	0.05
query2	0.10	0.05	0.05
query3	0.27	0.08	0.09
query4	1.66	0.12	0.12
query5	0.29	0.27	0.27
query6	1.19	0.66	0.68
query7	0.04	0.03	0.03
query8	0.06	0.04	0.04
query9	0.63	0.55	0.52
query10	0.60	0.59	0.59
query11	0.17	0.12	0.12
query12	0.16	0.12	0.13
query13	0.63	0.61	0.60
query14	1.01	1.02	1.01
query15	0.87	0.86	0.85
query16	0.41	0.41	0.43
query17	1.09	1.03	1.04
query18	0.23	0.21	0.21
query19	2.01	1.94	1.90
query20	0.02	0.01	0.01
query21	15.42	0.19	0.14
query22	5.18	0.08	0.05
query23	15.64	0.28	0.11
query24	2.67	0.70	0.81
query25	0.08	0.06	0.06
query26	0.15	0.13	0.15
query27	0.08	0.07	0.06
query28	4.22	1.19	0.95
query29	12.57	4.11	3.41
query30	0.29	0.17	0.15
query31	2.84	0.62	0.40
query32	3.23	0.56	0.50
query33	3.02	3.04	3.08
query34	15.87	5.19	4.62
query35	4.57	4.57	4.58
query36	0.71	0.53	0.51
query37	0.11	0.07	0.07
query38	0.07	0.05	0.04
query39	0.05	0.03	0.03
query40	0.17	0.15	0.14
query41	0.09	0.03	0.03
query42	0.04	0.03	0.03
query43	0.04	0.04	0.04
Total cold run time: 98.61 s
Total hot run time: 28.45 s

doris-robot · 2025-10-30T06:23:56Z

BE UT Coverage Report

Increment line coverage 0.00% (0/1) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	52.71% (18037/34221)
Line Coverage	37.95% (163620/431167)
Region Coverage	32.32% (124759/386061)
Branch Coverage	33.69% (54551/161929)

zzzxl1993 · 2025-10-30T06:28:27Z

run buildall

hello-stephen · 2025-10-30T07:30:36Z

BE UT Coverage Report

Increment line coverage 0.00% (0/1) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	52.71% (18041/34224)
Line Coverage	37.96% (163716/431244)
Region Coverage	32.31% (124749/386097)
Branch Coverage	33.70% (54582/161951)

doris-robot · 2025-10-30T07:35:45Z

ClickBench: Total hot run time: 28.45 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 3b8a41fca5446c1e1d988819020b2418c799ce52, data reload: false

query1	0.06	0.05	0.05
query2	0.11	0.06	0.05
query3	0.26	0.08	0.08
query4	1.60	0.12	0.12
query5	0.29	0.26	0.26
query6	1.24	0.66	0.66
query7	0.03	0.03	0.03
query8	0.05	0.05	0.05
query9	0.62	0.54	0.53
query10	0.61	0.61	0.59
query11	0.17	0.12	0.12
query12	0.15	0.12	0.13
query13	0.63	0.61	0.60
query14	1.02	1.02	1.02
query15	0.88	0.87	0.89
query16	0.41	0.42	0.39
query17	1.10	1.07	1.08
query18	0.23	0.20	0.20
query19	1.89	1.84	1.91
query20	0.02	0.01	0.01
query21	15.40	0.18	0.14
query22	5.06	0.08	0.05
query23	15.67	0.28	0.11
query24	3.72	0.53	0.98
query25	0.09	0.07	0.07
query26	0.15	0.14	0.16
query27	0.06	0.06	0.06
query28	4.96	1.16	0.98
query29	12.63	4.29	3.57
query30	0.33	0.14	0.12
query31	2.84	0.62	0.40
query32	3.24	0.56	0.47
query33	3.12	3.11	3.09
query34	15.85	5.19	4.55
query35	4.61	4.61	4.62
query36	0.72	0.54	0.51
query37	0.11	0.08	0.07
query38	0.06	0.04	0.04
query39	0.04	0.03	0.04
query40	0.18	0.15	0.15
query41	0.09	0.04	0.03
query42	0.04	0.03	0.03
query43	0.05	0.04	0.04
Total cold run time: 100.39 s
Total hot run time: 28.45 s

hello-stephen · 2025-10-30T08:59:25Z

BE Regression && UT Coverage Report

Increment line coverage 100.00% (1/1) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	71.43% (24020/33628)
Line Coverage	57.87% (249894/431787)
Region Coverage	52.99% (207460/391501)
Branch Coverage	54.73% (89204/163000)

deardeng

LGTM

github-actions · 2025-10-30T13:46:00Z

PR approved by at least one committer and no changes requested.

…57464) introduce by #52118 1. Remove the `query_options().enable_file_cache` check in `olap_scanner.cpp` when reporting file cache profile statistics. This check should only apply to external table scanners (FileScanner).

…cloud mode #57464 (#57534) Cherry-picked from #57464 Co-authored-by: zzzxl <yangsiyu@selectdb.com>

…pache#57464) introduce by apache#52118 1. Remove the `query_options().enable_file_cache` check in `olap_scanner.cpp` when reporting file cache profile statistics. This check should only apply to external table scanners (FileScanner).

[fix](profile) ensure file cache profile stats output in cloud mode

e564ba5

deardeng approved these changes Oct 29, 2025

View reviewed changes

github-actions bot added the reviewed label Oct 29, 2025

fix

eff8031

fix

3b8a41f

zzzxl1993 requested a review from deardeng October 30, 2025 09:46

deardeng approved these changes Oct 30, 2025

View reviewed changes

gavinchou approved these changes Oct 30, 2025

View reviewed changes

github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 30, 2025

gavinchou added the dev/4.0.x label Oct 30, 2025

gavinchou merged commit 99bd0cb into apache:master Oct 30, 2025
27 of 29 checks passed

github-actions bot mentioned this pull request Oct 30, 2025

branch-4.0: [fix](profile) ensure file cache profile stats output in cloud mode #57464 #57534

Merged

yiguolei pushed a commit that referenced this pull request Oct 31, 2025

branch-4.0: [fix](profile) ensure file cache profile stats output in …

053f451

…cloud mode #57464 (#57534) Cherry-picked from #57464 Co-authored-by: zzzxl <yangsiyu@selectdb.com>

yiguolei added dev/4.0.1-merged and removed dev/4.0.x labels Oct 31, 2025

Conversation

zzzxl1993 commented Oct 29, 2025 • edited by gavinchou Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Thearas commented Oct 29, 2025

Uh oh!

zzzxl1993 commented Oct 29, 2025

Uh oh!

deardeng left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Oct 29, 2025

Uh oh!

doris-robot commented Oct 29, 2025

Uh oh!

doris-robot commented Oct 29, 2025

BE UT Coverage Report

Uh oh!

hello-stephen commented Oct 29, 2025

BE Regression && UT Coverage Report

Uh oh!

zzzxl1993 commented Oct 30, 2025

Uh oh!

doris-robot commented Oct 30, 2025

Uh oh!

doris-robot commented Oct 30, 2025

BE UT Coverage Report

Uh oh!

zzzxl1993 commented Oct 30, 2025

Uh oh!

hello-stephen commented Oct 30, 2025

BE UT Coverage Report

Uh oh!

doris-robot commented Oct 30, 2025

Uh oh!

hello-stephen commented Oct 30, 2025

BE Regression && UT Coverage Report

Uh oh!

deardeng left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Oct 30, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

zzzxl1993 commented Oct 29, 2025 •

edited by gavinchou

Loading