[fix](cloud)Fix read from peer use thread pool not asyncio #57587

deardeng · 2025-10-31T09:39:20Z

Related PR：
#56384 modify the enable_cache_read_from_peer configuration from false to true.

deardeng · 2025-10-31T09:39:32Z

run buildall

deardeng · 2025-10-31T09:44:28Z

run buildall

doris-robot · 2025-10-31T10:18:40Z

ClickBench: Total hot run time: 27.97 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 9b025b9f7d119237d7deccb109ac5fbd2bc2db82, data reload: false

query1	0.06	0.05	0.05
query2	0.09	0.05	0.05
query3	0.25	0.08	0.09
query4	1.61	0.12	0.12
query5	0.28	0.26	0.25
query6	1.18	0.65	0.66
query7	0.03	0.03	0.02
query8	0.05	0.04	0.04
query9	0.60	0.52	0.52
query10	0.59	0.59	0.58
query11	0.17	0.12	0.12
query12	0.17	0.13	0.12
query13	0.62	0.60	0.61
query14	1.02	1.01	1.01
query15	0.86	0.84	0.85
query16	0.39	0.40	0.40
query17	1.09	1.05	1.04
query18	0.22	0.23	0.21
query19	1.95	1.83	1.83
query20	0.02	0.01	0.01
query21	15.44	0.18	0.13
query22	5.15	0.07	0.05
query23	15.67	0.27	0.10
query24	3.05	0.69	0.91
query25	0.07	0.06	0.05
query26	0.15	0.14	0.13
query27	0.06	0.05	0.06
query28	5.10	1.16	0.94
query29	12.65	4.06	3.28
query30	0.28	0.13	0.12
query31	2.82	0.62	0.39
query32	3.22	0.56	0.48
query33	3.18	3.04	3.09
query34	15.78	5.17	4.53
query35	4.62	4.58	4.58
query36	0.68	0.51	0.50
query37	0.10	0.07	0.07
query38	0.07	0.04	0.04
query39	0.04	0.03	0.03
query40	0.17	0.15	0.14
query41	0.08	0.04	0.03
query42	0.04	0.03	0.03
query43	0.04	0.04	0.03
Total cold run time: 99.71 s
Total hot run time: 27.97 s

hello-stephen · 2025-10-31T10:44:09Z

FE UT Coverage Report

Increment line coverage 100% (0/0) 🎉
Increment coverage report
Complete coverage report

doris-robot · 2025-10-31T10:46:15Z

BE UT Coverage Report

Increment line coverage 0.00% (0/7) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	52.70% (18047/34247)
Line Coverage	37.95% (163861/431752)
Region Coverage	32.30% (124956/386883)
Branch Coverage	33.68% (54615/162140)

hello-stephen · 2025-10-31T13:26:49Z

BE Regression && UT Coverage Report

Increment line coverage 6.25% (7/112) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	71.40% (24033/33660)
Line Coverage	57.82% (250054/432491)
Region Coverage	52.88% (207519/392469)
Branch Coverage	54.62% (89159/163247)

hello-stephen · 2025-10-31T13:50:09Z

FE Regression Coverage Report

Increment line coverage 100% (0/0) 🎉
Increment coverage report
Complete coverage report

gavinchou · 2025-11-01T10:45:43Z

be/src/cloud/cloud_internal_service.cpp

+        if (type == PFetchPeerDataRequest_Type_PEER_FILE_RANGE) {
+            status = handle_peer_file_range_request(path, response);
+        } else if (type == PFetchPeerDataRequest_Type_PEER_FILE_CACHE_BLOCK) {
+            status = handle_peer_file_cache_block_request(request, response);


handle_peer_file_cache_block_request
and
handle_peer_file_range_request
can be a function

process type in that function

github-actions · 2025-11-01T10:48:47Z

PR approved by at least one committer and no changes requested.

github-actions · 2025-11-01T10:48:49Z

PR approved by anyone and no changes requested.

liaoxin01

LGTM

) Related PR： apache#56384 modify the `enable_cache_read_from_peer` configuration from false to true.

…#57587 (#57807) picked from #57587

) Related PR： apache#56384 modify the `enable_cache_read_from_peer` configuration from false to true.

…#57587 (#59000) cherry pick from #57587

deardeng requested review from dataroaring, gavinchou and w41ter as code owners October 31, 2025 09:39

[fix](cloud)Fix read from peer use thread pool not asyncio

9b025b9

deardeng force-pushed the fix-peer-async-io branch from aa47587 to 9b025b9 Compare October 31, 2025 09:43

gavinchou added dev/3.1.x dev/4.0.x labels Nov 1, 2025

gavinchou reviewed Nov 1, 2025

View reviewed changes

gavinchou approved these changes Nov 1, 2025

View reviewed changes

github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 1, 2025

github-actions bot added the reviewed label Nov 1, 2025

liaoxin01 approved these changes Nov 1, 2025

View reviewed changes

hello-stephen merged commit 77380ff into apache:master Nov 2, 2025
33 of 37 checks passed

github-actions bot added dev/3.1.x-conflict dev/4.0.x-conflict labels Nov 2, 2025

deardeng added a commit to deardeng/incubator-doris that referenced this pull request Nov 7, 2025

[fix](cloud)Fix read from peer use thread pool not asyncio (apache#57587

d1ae6a8

) Related PR： apache#56384 modify the `enable_cache_read_from_peer` configuration from false to true.

deardeng mentioned this pull request Nov 7, 2025

branch-3.1: [fix](cloud)Fix read from peer use thread pool not asyncio #57587 #57807

Merged

morrySnow pushed a commit that referenced this pull request Nov 7, 2025

branch-3.1: [fix](cloud)Fix read from peer use thread pool not asyncio …

f88a835

…#57587 (#57807) picked from #57587

morrySnow added dev/3.1.3-merged and removed dev/3.1.x dev/3.1.x-conflict labels Nov 10, 2025

deardeng added a commit to deardeng/incubator-doris that referenced this pull request Dec 12, 2025

[fix](cloud)Fix read from peer use thread pool not asyncio (apache#57587

ba08ca3

) Related PR： apache#56384 modify the `enable_cache_read_from_peer` configuration from false to true.

deardeng mentioned this pull request Dec 12, 2025

branch-4.0: [fix](cloud)Fix read from peer use thread pool not asyncio #57587 #59000

Merged

deardeng added a commit to deardeng/incubator-doris that referenced this pull request Dec 12, 2025

[fix](cloud)Fix read from peer use thread pool not asyncio (apache#57587

6166210

) Related PR： apache#56384 modify the `enable_cache_read_from_peer` configuration from false to true.

gavinchou removed the dev/4.0.x-conflict label Dec 17, 2025

deardeng added a commit to deardeng/incubator-doris that referenced this pull request Dec 18, 2025

[fix](cloud)Fix read from peer use thread pool not asyncio (apache#57587

1d2a0da

) Related PR： apache#56384 modify the `enable_cache_read_from_peer` configuration from false to true.

yiguolei pushed a commit that referenced this pull request Dec 22, 2025

branch-4.0: [fix](cloud)Fix read from peer use thread pool not asyncio …

c7b96a4

…#57587 (#59000) cherry pick from #57587

yiguolei added dev/4.0.3-merged and removed dev/4.0.x labels Dec 22, 2025

[fix](cloud)Fix read from peer use thread pool not asyncio #57587

[fix](cloud)Fix read from peer use thread pool not asyncio #57587

Uh oh!

Conversation

deardeng commented Oct 31, 2025 • edited by gavinchou Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

deardeng commented Oct 31, 2025

Uh oh!

deardeng commented Oct 31, 2025

Uh oh!

doris-robot commented Oct 31, 2025

Uh oh!

hello-stephen commented Oct 31, 2025

FE UT Coverage Report

Uh oh!

doris-robot commented Oct 31, 2025

BE UT Coverage Report

Uh oh!

hello-stephen commented Oct 31, 2025

BE Regression && UT Coverage Report

Uh oh!

hello-stephen commented Oct 31, 2025

FE Regression Coverage Report

Uh oh!

gavinchou Nov 1, 2025

Choose a reason for hiding this comment

Uh oh!

gavinchou Nov 1, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Nov 1, 2025

Uh oh!

github-actions bot commented Nov 1, 2025

Uh oh!

liaoxin01 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

deardeng commented Oct 31, 2025 •

edited by gavinchou

Loading