Skip to content

Conversation

@hubgeter
Copy link
Contributor

@hubgeter hubgeter commented Nov 3, 2025

bp #57519
Problem Summary:
This PR adds a TotalGetRequestTime profile metric to the S3 reader. The new metric records the total time spent on all GetObject requests, which will be useful for future performance analysis and optimization.

Example profile (Some less relevant information was manually removed.):

FILE_SCAN_OPERATOR  (id=0.  nereids_id=104.  table  name  =  lineitem):
      CommonCounters:
            -  ExecTime:  11sec669ms
            -  OpenTime:  7.395ms
            -  WaitForDependency[FILE_SCAN_OPERATOR_DEPENDENCY]Time:  11sec634ms
              ....
      CustomCounters:
              ....
          Scanner:
                ....
                -  FileReadTime:  4min8sec
                -  FileScannerGetBlockTime:  4min9sec
                -  MergedSmallIO:  0ns
                    -  ReadTime:  4min8sec
                    -  RequestBytes:  2.05  MB
                    -  RequestIO:  20.0K  (20000)
                -  ParquetReader:  0ns
                    -  ColumnReadTime:  4min9sec
                    -  FileOpenTime:  365.293ms
                    -  ParseFooterTime:  5min6sec
                    -  ParseMetaTime:  126.383ms
                         .....
                -  S3Profile:  0ns
                    -  TooManyRequestErr:  0
                    -  TooManyRequestSleepTime:  0ms
                    -  TotalBytesRead:  199.14  MB
                    -  TotalGetRequestTime:  9min12sec
                    -  TotalGetRequest:  40.0K  (40000)
                -  ScannerCpuTime:  20sec946ms
                -  ScannerGetBlockTime:  9min19sec

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

…der. (apache#57519)

Problem Summary:
This PR adds a `TotalGetRequestTime` profile metric to the S3 reader.
The new metric records the total time spent on all `GetObject` requests,
which will be useful for future performance analysis and optimization.

Example profile (Some less relevant information was manually removed.):
```
FILE_SCAN_OPERATOR  (id=0.  nereids_id=104.  table  name  =  lineitem):
      CommonCounters:
            -  ExecTime:  11sec669ms
            -  OpenTime:  7.395ms
            -  WaitForDependency[FILE_SCAN_OPERATOR_DEPENDENCY]Time:  11sec634ms
              ....
      CustomCounters:
              ....
          Scanner:
                ....
                -  FileReadTime:  4min8sec
                -  FileScannerGetBlockTime:  4min9sec
                -  MergedSmallIO:  0ns
                    -  ReadTime:  4min8sec
                    -  RequestBytes:  2.05  MB
                    -  RequestIO:  20.0K  (20000)
                -  ParquetReader:  0ns
                    -  ColumnReadTime:  4min9sec
                    -  FileOpenTime:  365.293ms
                    -  ParseFooterTime:  5min6sec
                    -  ParseMetaTime:  126.383ms
                         .....
                -  S3Profile:  0ns
                    -  TooManyRequestErr:  0
                    -  TooManyRequestSleepTime:  0ms
                    -  TotalBytesRead:  199.14  MB
                    -  TotalGetRequestTime:  9min12sec
                    -  TotalGetRequest:  40.0K  (40000)
                -  ScannerCpuTime:  20sec946ms
                -  ScannerGetBlockTime:  9min19sec
```
@hubgeter hubgeter requested a review from yiguolei as a code owner November 3, 2025 09:28
@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@hubgeter hubgeter changed the title [enhancement](s3)Add TotalGetRequestTime profile metric to the S3 reader. (#57519) branch-4.0:[enhancement](s3)Add TotalGetRequestTime profile metric to the S3 reader. (#57519) Nov 3, 2025
@hubgeter
Copy link
Contributor Author

hubgeter commented Nov 3, 2025

run buildall

@yiguolei yiguolei closed this Nov 5, 2025
@yiguolei yiguolei reopened this Nov 5, 2025
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 5, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2025

PR approved by anyone and no changes requested.

@yiguolei yiguolei merged commit 3b417f2 into apache:branch-4.0 Nov 5, 2025
27 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants