Skip to content

Conversation

@airborne12
Copy link
Member

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@airborne12
Copy link
Member Author

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2025

PR approved by anyone and no changes requested.

@doris-robot
Copy link

ClickBench: Total hot run time: 27.93 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 216a11e125f17eb72008f66cc1138561ae5db016, data reload: false

query1	0.06	0.05	0.05
query2	0.09	0.05	0.06
query3	0.24	0.09	0.09
query4	1.62	0.11	0.12
query5	0.28	0.26	0.25
query6	1.20	0.64	0.66
query7	0.03	0.03	0.03
query8	0.05	0.04	0.04
query9	0.61	0.53	0.54
query10	0.57	0.58	0.59
query11	0.16	0.11	0.12
query12	0.16	0.13	0.12
query13	0.64	0.60	0.60
query14	1.02	1.01	1.00
query15	0.85	0.84	0.84
query16	0.40	0.40	0.41
query17	1.03	1.05	1.01
query18	0.22	0.20	0.20
query19	1.98	1.86	1.84
query20	0.01	0.02	0.01
query21	15.46	0.17	0.13
query22	5.18	0.07	0.05
query23	15.67	0.27	0.10
query24	2.68	0.58	1.32
query25	0.08	0.07	0.06
query26	0.16	0.14	0.15
query27	0.06	0.06	0.07
query28	5.40	1.16	0.93
query29	12.56	3.91	3.20
query30	0.28	0.14	0.14
query31	2.82	0.60	0.40
query32	3.24	0.56	0.49
query33	3.12	3.08	3.12
query34	15.86	5.18	4.59
query35	4.60	4.59	4.60
query36	0.71	0.52	0.50
query37	0.11	0.07	0.07
query38	0.07	0.05	0.04
query39	0.04	0.04	0.04
query40	0.18	0.14	0.14
query41	0.09	0.03	0.03
query42	0.04	0.03	0.03
query43	0.04	0.04	0.04
Total cold run time: 99.67 s
Total hot run time: 27.93 s

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.70% (18048/34249)
Line Coverage 37.99% (164073/431857)
Region Coverage 32.31% (124994/386894)
Branch Coverage 33.74% (54718/162186)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100% (0/0) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.48% (24065/33668)
Line Coverage 57.85% (250272/432602)
Region Coverage 52.87% (207502/392490)
Branch Coverage 54.68% (89294/163295)

Copy link
Member

@eldenmoon eldenmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2025

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 3, 2025
@airborne12 airborne12 merged commit ef4993b into apache:master Nov 3, 2025
27 of 28 checks passed
@airborne12 airborne12 deleted the fix-faiss branch November 3, 2025 13:13
yiguolei pushed a commit that referenced this pull request Nov 4, 2025
#57651)

Cherry-picked from #57642

Co-authored-by: Jack <jiangkai@selectdb.com>
wyxxxcat pushed a commit to wyxxxcat/doris that referenced this pull request Nov 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/4.0.1-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants