Skip to content

Conversation

@mrhhsg
Copy link
Member

@mrhhsg mrhhsg commented Nov 3, 2025

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

When resetting the hash table in aggregation operator, the _agg_arena_pool also needs to be reset.

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Nov 3, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@mrhhsg
Copy link
Member Author

mrhhsg commented Nov 3, 2025

run buildall

@doris-robot
Copy link

ClickBench: Total hot run time: 28.01 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 0b3c55b7051aaf6aeade3068081fc8d6b1a7fb27, data reload: false

query1	0.06	0.05	0.05
query2	0.09	0.05	0.05
query3	0.26	0.08	0.08
query4	1.60	0.12	0.12
query5	0.27	0.26	0.25
query6	1.19	0.65	0.65
query7	0.03	0.03	0.02
query8	0.05	0.04	0.05
query9	0.60	0.52	0.52
query10	0.59	0.57	0.56
query11	0.16	0.11	0.12
query12	0.15	0.12	0.12
query13	0.61	0.60	0.60
query14	1.01	1.02	1.02
query15	0.84	0.85	0.85
query16	0.40	0.39	0.40
query17	1.06	1.03	1.03
query18	0.22	0.20	0.20
query19	1.90	1.85	1.86
query20	0.01	0.02	0.04
query21	15.43	0.20	0.14
query22	5.05	0.07	0.04
query23	15.67	0.28	0.11
query24	2.21	0.59	1.18
query25	0.08	0.06	0.06
query26	0.14	0.14	0.15
query27	0.06	0.06	0.05
query28	5.22	1.14	0.94
query29	12.55	3.87	3.25
query30	0.28	0.14	0.12
query31	2.82	0.61	0.38
query32	3.23	0.56	0.47
query33	3.08	3.11	3.09
query34	15.77	5.18	4.64
query35	4.64	4.60	4.61
query36	0.67	0.50	0.50
query37	0.10	0.07	0.07
query38	0.07	0.04	0.04
query39	0.04	0.03	0.04
query40	0.18	0.15	0.13
query41	0.08	0.03	0.03
query42	0.04	0.04	0.03
query43	0.05	0.03	0.04
Total cold run time: 98.56 s
Total hot run time: 28.01 s

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 100.00% (2/2) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.72% (18056/34249)
Line Coverage 38.01% (164147/431859)
Region Coverage 32.33% (125093/386895)
Branch Coverage 33.77% (54764/162186)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (2/2) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.56% (24093/33668)
Line Coverage 57.98% (250818/432604)
Region Coverage 52.99% (207999/392491)
Branch Coverage 54.81% (89506/163295)

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 4, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2025

PR approved by anyone and no changes requested.

@yiguolei yiguolei merged commit eb771a4 into apache:master Nov 4, 2025
28 of 30 checks passed
@mrhhsg mrhhsg deleted the fix_spill_mem branch November 4, 2025 09:32
yiguolei pushed a commit that referenced this pull request Nov 4, 2025
…tion operator #57657 (#57691)

Cherry-picked from #57657

Co-authored-by: Jerry Hu <hushenggang@selectdb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/4.0.1-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants