Skip to content

[be](comment) add some comment to page zonemap #57703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yiguolei merged 1 commit into from
Nov 5, 2025
Merged

[be](comment) add some comment to page zonemap #57703

yiguolei merged 1 commit into from
Nov 5, 2025

Conversation

@yiguolei
Copy link
Contributor

@yiguolei yiguolei commented Nov 4, 2025

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

hello-stephen commented Nov 4, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@yiguolei
Copy link
Contributor Author

yiguolei commented Nov 4, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Nov 4, 2025

TPC-DS: Total hot run time: 188888 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 2abb0ceb9c51e91996bbedf22567a35b6f792dc2, data reload: false

query1	1057	407	382	382
query2	6591	1672	1713	1672
query3	6751	225	221	221
query4	26230	23840	23032	23032
query5	5652	633	467	467
query6	367	260	227	227
query7	4642	494	292	292
query8	338	270	251	251
query9	8736	2575	2584	2575
query10	538	339	291	291
query11	15301	15047	15687	15047
query12	206	132	125	125
query13	1981	615	461	461
query14	12084	9734	9806	9734
query15	248	216	201	201
query16	7864	702	544	544
query17	1898	858	673	673
query18	2322	437	355	355
query19	375	217	186	186
query20	129	122	121	121
query21	207	133	120	120
query22	4637	4613	4474	4474
query23	34564	34064	33157	33157
query24	8342	2351	2385	2351
query25	548	487	455	455
query26	1210	266	154	154
query27	2688	485	345	345
query28	4274	2172	2156	2156
query29	774	594	480	480
query30	300	223	193	193
query31	899	824	708	708
query32	75	63	66	63
query33	581	354	326	326
query34	779	839	513	513
query35	798	842	750	750
query36	941	1017	903	903
query37	116	107	83	83
query38	3500	3491	3516	3491
query39	1460	1559	1411	1411
query40	213	125	124	124
query41	57	55	55	55
query42	120	104	110	104
query43	486	501	475	475
query44	1194	722	747	722
query45	181	181	179	179
query46	887	979	625	625
query47	1757	1777	1732	1732
query48	388	414	306	306
query49	763	496	404	404
query50	622	679	400	400
query51	3816	3964	3985	3964
query52	107	103	96	96
query53	226	258	203	203
query54	308	298	268	268
query55	84	84	82	82
query56	315	296	302	296
query57	1181	1178	1122	1122
query58	279	281	277	277
query59	2652	2759	2663	2663
query60	352	341	330	330
query61	162	157	161	157
query62	780	706	659	659
query63	227	192	191	191
query64	4422	1143	858	858
query65	4029	4003	3906	3906
query66	1039	426	350	350
query67	15268	15013	15004	15004
query68	8429	861	592	592
query69	505	313	291	291
query70	1325	1300	1211	1211
query71	466	343	316	316
query72	5791	4890	4968	4890
query73	633	568	350	350
query74	8835	9159	8806	8806
query75	3587	3373	2816	2816
query76	3448	1171	742	742
query77	743	394	304	304
query78	9521	9627	8922	8922
query79	2374	787	596	596
query80	704	559	526	526
query81	531	257	225	225
query82	207	156	129	129
query83	264	264	250	250
query84	258	105	88	88
query85	882	480	443	443
query86	358	304	280	280
query87	3709	3703	3617	3617
query88	3497	2257	2262	2257
query89	384	319	308	308
query90	2017	216	219	216
query91	167	174	139	139
query92	89	68	63	63
query93	2271	953	639	639
query94	680	445	332	332
query95	398	325	314	314
query96	494	569	281	281
query97	2908	2969	2907	2907
query98	248	219	213	213
query99	1317	1415	1283	1283
Total cold run time: 278958 ms
Total hot run time: 188888 ms

@doris-robot
Copy link

doris-robot commented Nov 4, 2025

ClickBench: Total hot run time: 27.29 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 2abb0ceb9c51e91996bbedf22567a35b6f792dc2, data reload: false

query1	0.06	0.05	0.05
query2	0.09	0.05	0.05
query3	0.25	0.08	0.08
query4	1.61	0.11	0.11
query5	0.27	0.27	0.26
query6	1.16	0.65	0.64
query7	0.03	0.02	0.02
query8	0.05	0.04	0.04
query9	0.59	0.52	0.50
query10	0.57	0.58	0.57
query11	0.16	0.11	0.11
query12	0.15	0.12	0.12
query13	0.60	0.60	0.61
query14	1.00	1.01	1.00
query15	0.85	0.83	0.85
query16	0.39	0.40	0.39
query17	1.01	1.04	0.99
query18	0.21	0.19	0.20
query19	1.89	1.82	1.78
query20	0.02	0.01	0.02
query21	15.46	0.19	0.12
query22	5.19	0.07	0.04
query23	15.68	0.26	0.10
query24	3.31	0.84	0.39
query25	0.06	0.06	0.06
query26	0.14	0.13	0.14
query27	0.06	0.05	0.06
query28	4.53	1.12	0.94
query29	12.56	3.90	3.29
query30	0.27	0.14	0.11
query31	2.82	0.60	0.38
query32	3.22	0.54	0.46
query33	3.00	3.01	3.04
query34	15.81	5.20	4.50
query35	4.55	4.62	4.54
query36	0.68	0.50	0.48
query37	0.09	0.06	0.06
query38	0.06	0.04	0.04
query39	0.04	0.03	0.03
query40	0.18	0.13	0.13
query41	0.09	0.04	0.03
query42	0.04	0.03	0.03
query43	0.04	0.03	0.03
Total cold run time: 98.84 s
Total hot run time: 27.29 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Nov 4, 2025

BE UT Coverage Report

Increment line coverage 100.00% (2/2) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.73% (18083/34293)
Line Coverage 38.05% (164503/432289)
Region Coverage 32.37% (125376/387296)
Branch Coverage 33.81% (54900/162400)

@hello-stephen
Copy link
Contributor

hello-stephen commented Nov 4, 2025

BE Regression && UT Coverage Report

Increment line coverage 100.00% (2/2) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 72.35% (24389/33712)
Line Coverage 59.16% (256184/433034)
Region Coverage 54.84% (215443/392892)
Branch Coverage 56.31% (92065/163509)

1 similar comment
@hello-stephen
Copy link
Contributor

hello-stephen commented Nov 5, 2025

BE Regression && UT Coverage Report

Increment line coverage 100.00% (2/2) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 72.35% (24389/33712)
Line Coverage 59.16% (256184/433034)
Region Coverage 54.84% (215443/392892)
Branch Coverage 56.31% (92065/163509)

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 5, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2025

PR approved by anyone and no changes requested.

@yiguolei yiguolei merged commit 6f4468b into apache:master Nov 5, 2025
30 of 31 checks passed
wyxxxcat pushed a commit to wyxxxcat/doris that referenced this pull request Nov 18, 2025
@yiguolei @wyxxxcat
[be](comment) add some comment to page zonemap (apache#57703)
f5d4b2a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jacktengg jacktengg jacktengg approved these changes

@Gabriel39 Gabriel39 Gabriel39 approved these changes

+1 more reviewer

@dwdwqfwe dwdwqfwe dwdwqfwe approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@yiguolei @hello-stephen @doris-robot @jacktengg @Gabriel39 @dwdwqfwe