Skip to content

[fix](filecache) fix stack-use-after-return when submit_download_tasks #57724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 1 commit into from
Nov 7, 2025
Merged

[fix](filecache) fix stack-use-after-return when submit_download_tasks #57724

dataroaring merged 1 commit into from
Nov 7, 2025

Conversation

@freemandealer
Copy link
Contributor

@freemandealer freemandealer commented Nov 5, 2025

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@freemandealer
[fix](filecache) fix stack-use-after-return when submit_download_tasks
7b033e8 
Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>
@hello-stephen
Copy link
Contributor

hello-stephen commented Nov 5, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@freemandealer
Copy link
Contributor Author

freemandealer commented Nov 5, 2025

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 5, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2025

PR approved by anyone and no changes requested.

@doris-robot
Copy link

doris-robot commented Nov 5, 2025

TPC-DS: Total hot run time: 190172 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 7b033e8b345d28b9e31b5a976afa0713af2175fc, data reload: false

query1	1053	420	393	393
query2	6556	1711	1705	1705
query3	6758	227	221	221
query4	26515	24003	23829	23829
query5	5834	645	506	506
query6	335	243	231	231
query7	4645	500	299	299
query8	319	274	257	257
query9	8721	2633	2643	2633
query10	554	348	298	298
query11	15326	15001	14975	14975
query12	186	119	114	114
query13	1698	565	449	449
query14	11327	9284	9427	9284
query15	203	198	182	182
query16	7673	704	518	518
query17	1556	798	645	645
query18	2174	470	377	377
query19	257	232	210	210
query20	147	139	142	139
query21	225	139	122	122
query22	4759	4625	4338	4338
query23	34971	33610	33859	33610
query24	9603	2501	2528	2501
query25	616	534	480	480
query26	1279	279	163	163
query27	3591	533	407	407
query28	4421	2299	2228	2228
query29	860	638	507	507
query30	298	234	202	202
query31	964	830	767	767
query32	86	72	70	70
query33	593	426	345	345
query34	821	905	536	536
query35	824	854	812	812
query36	981	1052	935	935
query37	135	112	90	90
query38	3693	3722	3693	3693
query39	1543	1467	1419	1419
query40	220	129	135	129
query41	72	56	57	56
query42	124	112	114	112
query43	486	505	452	452
query44	1256	748	738	738
query45	182	175	165	165
query46	910	996	646	646
query47	1743	1807	1774	1774
query48	397	415	312	312
query49	795	501	396	396
query50	646	679	403	403
query51	3909	3869	3916	3869
query52	116	110	101	101
query53	238	267	201	201
query54	297	295	295	295
query55	86	89	86	86
query56	318	328	311	311
query57	1198	1199	1099	1099
query58	288	280	291	280
query59	2535	2631	2560	2560
query60	339	337	324	324
query61	162	157	154	154
query62	776	714	667	667
query63	234	189	193	189
query64	4450	1159	856	856
query65	4042	3933	3956	3933
query66	1032	436	325	325
query67	15402	15399	14828	14828
query68	8481	965	581	581
query69	518	324	290	290
query70	1282	1247	1191	1191
query71	526	342	319	319
query72	5767	4949	4827	4827
query73	702	570	357	357
query74	8932	9002	8901	8901
query75	4100	3365	2832	2832
query76	3870	1155	734	734
query77	821	417	313	313
query78	9592	9555	8927	8927
query79	2373	872	596	596
query80	673	580	500	500
query81	501	262	229	229
query82	474	166	129	129
query83	288	262	250	250
query84	310	108	95	95
query85	891	484	444	444
query86	332	305	283	283
query87	3836	3793	3687	3687
query88	3589	2262	2282	2262
query89	384	320	289	289
query90	2012	215	215	215
query91	161	165	138	138
query92	89	73	65	65
query93	1758	999	640	640
query94	684	456	347	347
query95	384	324	315	315
query96	499	600	285	285
query97	2963	2972	2868	2868
query98	240	219	214	214
query99	1454	1398	1298	1298
Total cold run time: 282839 ms
Total hot run time: 190172 ms

@doris-robot
Copy link

doris-robot commented Nov 5, 2025

ClickBench: Total hot run time: 27.81 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 7b033e8b345d28b9e31b5a976afa0713af2175fc, data reload: false

query1	0.06	0.04	0.04
query2	0.09	0.05	0.05
query3	0.26	0.09	0.08
query4	1.61	0.12	0.12
query5	0.26	0.26	0.25
query6	1.19	0.66	0.65
query7	0.03	0.02	0.03
query8	0.05	0.04	0.04
query9	0.61	0.52	0.52
query10	0.56	0.57	0.58
query11	0.16	0.11	0.12
query12	0.15	0.12	0.13
query13	0.62	0.60	0.60
query14	1.00	1.01	1.00
query15	0.86	0.84	0.84
query16	0.39	0.39	0.44
query17	1.03	1.02	1.01
query18	0.21	0.19	0.20
query19	1.90	1.83	1.90
query20	0.01	0.02	0.01
query21	15.45	0.18	0.13
query22	5.06	0.08	0.05
query23	15.67	0.26	0.11
query24	2.54	0.71	0.72
query25	0.08	0.07	0.06
query26	0.14	0.13	0.14
query27	0.08	0.05	0.05
query28	5.25	1.15	0.93
query29	12.61	3.89	3.29
query30	0.27	0.14	0.11
query31	2.82	0.60	0.39
query32	3.23	0.57	0.48
query33	3.15	2.99	3.10
query34	15.93	5.16	4.54
query35	4.57	4.58	4.56
query36	0.67	0.50	0.48
query37	0.09	0.07	0.07
query38	0.06	0.04	0.03
query39	0.03	0.04	0.03
query40	0.18	0.15	0.14
query41	0.08	0.03	0.03
query42	0.03	0.03	0.03
query43	0.04	0.04	0.03
Total cold run time: 99.08 s
Total hot run time: 27.81 s

@freemandealer
Copy link
Contributor Author

freemandealer commented Nov 5, 2025

run p0

@hello-stephen
Copy link
Contributor

hello-stephen commented Nov 5, 2025

BE UT Coverage Report

Increment line coverage 0.00% (0/1) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.71% (18085/34309)
Line Coverage 38.05% (164524/432349)
Region Coverage 32.40% (125459/387270)
Branch Coverage 33.81% (54905/162388)

@hello-stephen
Copy link
Contributor

hello-stephen commented Nov 5, 2025

BE Regression && UT Coverage Report

Increment line coverage 0.00% (0/1) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.50% (24116/33728)
Line Coverage 57.92% (250864/433094)
Region Coverage 53.00% (208237/392866)
Branch Coverage 54.70% (89436/163497)

dataroaring
dataroaring approved these changes Nov 5, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@freemandealer
Copy link
Contributor Author

freemandealer commented Nov 6, 2025

run check_coverage

@freemandealer
Copy link
Contributor Author

freemandealer commented Nov 6, 2025

run nonConcurrent

@hello-stephen
Copy link
Contributor

hello-stephen commented Nov 6, 2025

BE Regression && UT Coverage Report

Increment line coverage 0.00% (0/1) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.50% (24116/33728)
Line Coverage 57.92% (250864/433094)
Region Coverage 53.00% (208237/392866)
Branch Coverage 54.70% (89436/163497)

@hello-stephen
Copy link
Contributor

hello-stephen commented Nov 6, 2025

BE Regression && UT Coverage Report

Increment line coverage 0.00% (0/1) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.50% (24114/33728)
Line Coverage 57.91% (250825/433094)
Region Coverage 53.02% (208307/392866)
Branch Coverage 54.70% (89434/163497)

@dataroaring dataroaring merged commit 63a2e96 into apache:master Nov 7, 2025
30 of 31 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 7, 2025
@freemandealer
[fix](filecache) fix stack-use-after-return when submit_download_tasks (
5ec6f7c 
#57724)
@github-actions github-actions bot mentioned this pull request Nov 7, 2025
Merged
github-actions bot pushed a commit that referenced this pull request Nov 7, 2025
@freemandealer
[fix](filecache) fix stack-use-after-return when submit_download_tasks (
9185e65 
#57724)
@github-actions github-actions bot mentioned this pull request Nov 7, 2025
Merged
CalvinKirs pushed a commit to CalvinKirs/incubator-doris that referenced this pull request Nov 7, 2025
@freemandealer @CalvinKirs
[fix](filecache) fix stack-use-after-return when submit_download_tasks (
76c05ff 
apache#57724)
morrySnow pushed a commit that referenced this pull request Nov 7, 2025
@github-actions @freemandealer
branch-3.1: [fix](filecache) fix stack-use-after-return when submit_d…
8023821 
…ownload_tasks #57724 (#57785)

Cherry-picked from #57724

Co-authored-by: zhengyu <zhangzhengyu@selectdb.com>
yiguolei pushed a commit that referenced this pull request Nov 10, 2025
@github-actions @freemandealer
branch-4.0: [fix](filecache) fix stack-use-after-return when submit_d…
ae94e16 
…ownload_tasks #57724 (#57786)

Cherry-picked from #57724

Co-authored-by: zhengyu <zhangzhengyu@selectdb.com>
wyxxxcat pushed a commit to wyxxxcat/doris that referenced this pull request Nov 18, 2025
@freemandealer @wyxxxcat
[fix](filecache) fix stack-use-after-return when submit_download_tasks (
ce822ac 
apache#57724)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gavinchou gavinchou gavinchou approved these changes

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.1.3-merged dev/4.0.2-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@freemandealer @hello-stephen @doris-robot @gavinchou @dataroaring @yiguolei @morrySnow