-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix](type) Unexpected throw exception due to unknown file type #57755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
TPC-DS: Total hot run time: 188651 ms |
ClickBench: Total hot run time: 27.38 s |
|
run buildall |
TPC-DS: Total hot run time: 189792 ms |
ClickBench: Total hot run time: 27.3 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
2 similar comments
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
dataroaring
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
| FileFactory::convert_storage_type(result_file_sink.storage_backend_type); | ||
| if (!file_type_res.has_value()) [[unlikely]] { | ||
| st = std::move(file_type_res).error(); | ||
| st.to_protobuf(result->mutable_status()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LOG(WARNING) << "encounter unkonw type=" << type << " st=" <<st;
|
run buildall |
TPC-H: Total hot run time: 34559 ms |
TPC-DS: Total hot run time: 188526 ms |
ClickBench: Total hot run time: 28.25 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
|
run buildall |
TPC-H: Total hot run time: 35125 ms |
TPC-DS: Total hot run time: 187443 ms |
ClickBench: Total hot run time: 27.52 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
|
run buildall |
TPC-H: Total hot run time: 34092 ms |
TPC-DS: Total hot run time: 190082 ms |
ClickBench: Total hot run time: 27.67 s |
|
run buildall |
TPC-H: Total hot run time: 34294 ms |
TPC-DS: Total hot run time: 187860 ms |
ClickBench: Total hot run time: 27.5 s |
|
PR approved by at least one committer and no changes requested. |
if fe has azure type and be don't has azure, be will crash ``` INFO: jdk_version 17 OpenJDK 64-Bit Server VM warning: Option CriticalJNINatives was deprecated in version 16.0 and will likely be removed in a future release. WARNING: sun.reflect.Reflection.getCallerClass is not supported. This will impact performance. [WARNING!] /sys/kernel/mm/transparent_hugepage/enabled: [always] madvise never, Doris not recommend turning on THP, which may cause the BE process to use more memory and cannot be freed in time. Turn off THP: `echo madvise | sudo tee /sys/kernel/mm/transparent_hugepage/enabled` start BE in local mode F20251011 12:20:23.100927 1614405 file_factory.h:121] not match type to convert, from type:AZURE *** Check failure stack trace: *** @ 0x5565ecf5b596 google::LogMessage::SendToLog() @ 0x5565ecf57fe0 google::LogMessage::Flush() @ 0x5565ecf5bdd9 google::LogMessageFatal::~LogMessageFatal() @ 0x5565e283d89b doris::FileFactory::convert_storage_type() @ 0x5565ec3b36f8 doris::vectorized::VFileResultWriter::_create_file_writer() @ 0x5565ec3b3192 doris::vectorized::VFileResultWriter::_create_next_file_writer() @ 0x5565ec3b1c09 doris::vectorized::VFileResultWriter::open() @ 0x5565ec3a7519 doris::vectorized::AsyncResultWriter::process_block() @ 0x5565ec3a8709 std::_Function_handler<>::_M_invoke() @ 0x5565e295b9ea doris::ThreadPool::dispatch_thread() @ 0x5565e2950011 doris::Thread::supervise_thread() @ 0x7fba8815c1ca start_thread @ 0x7fba88b4b8d3 __GI___clone @ (nil) (unknown) ```
…he#57755) if fe has azure type and be don't has azure, be will crash ``` INFO: jdk_version 17 OpenJDK 64-Bit Server VM warning: Option CriticalJNINatives was deprecated in version 16.0 and will likely be removed in a future release. WARNING: sun.reflect.Reflection.getCallerClass is not supported. This will impact performance. [WARNING!] /sys/kernel/mm/transparent_hugepage/enabled: [always] madvise never, Doris not recommend turning on THP, which may cause the BE process to use more memory and cannot be freed in time. Turn off THP: `echo madvise | sudo tee /sys/kernel/mm/transparent_hugepage/enabled` start BE in local mode F20251011 12:20:23.100927 1614405 file_factory.h:121] not match type to convert, from type:AZURE *** Check failure stack trace: *** @ 0x5565ecf5b596 google::LogMessage::SendToLog() @ 0x5565ecf57fe0 google::LogMessage::Flush() @ 0x5565ecf5bdd9 google::LogMessageFatal::~LogMessageFatal() @ 0x5565e283d89b doris::FileFactory::convert_storage_type() @ 0x5565ec3b36f8 doris::vectorized::VFileResultWriter::_create_file_writer() @ 0x5565ec3b3192 doris::vectorized::VFileResultWriter::_create_next_file_writer() @ 0x5565ec3b1c09 doris::vectorized::VFileResultWriter::open() @ 0x5565ec3a7519 doris::vectorized::AsyncResultWriter::process_block() @ 0x5565ec3a8709 std::_Function_handler<>::_M_invoke() @ 0x5565e295b9ea doris::ThreadPool::dispatch_thread() @ 0x5565e2950011 doris::Thread::supervise_thread() @ 0x7fba8815c1ca start_thread @ 0x7fba88b4b8d3 __GI___clone @ (nil) (unknown) ```
What problem does this PR solve?
if fe has azure type and be don't has azure, be will crash
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)