Skip to content

Conversation

@kaka11chen
Copy link
Contributor

What problem does this PR solve?

Related PR: #55935, #57833

Problem Summary:

Release note

Because the time task scheduler timeout issue, in #55935, we set enable_task_executor_in_internal_table conf's default value to true. in #57833, we fix it for some cases. So in this PR, set enable_task_executor_in_internal_table conf's default value to true.

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Nov 14, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@kaka11chen
Copy link
Contributor Author

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 14, 2025
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TPC-H: Total hot run time: 34706 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 86d29faee706ff1cf2c338d8cf5c91bc01ecc205, data reload: false

------ Round 1 ----------------------------------
q1	17611	5255	5300	5255
q2	1995	368	208	208
q3	10243	1292	722	722
q4	10237	990	383	383
q5	7496	2431	2383	2383
q6	188	170	136	136
q7	910	774	634	634
q8	9334	1330	1116	1116
q9	7144	5243	5131	5131
q10	6913	2262	1831	1831
q11	499	299	303	299
q12	367	368	231	231
q13	17790	3686	3054	3054
q14	237	241	226	226
q15	584	508	506	506
q16	1037	989	945	945
q17	591	888	384	384
q18	7450	7121	7222	7121
q19	1171	952	554	554
q20	365	338	251	251
q21	3700	3184	2345	2345
q22	1052	1019	991	991
Total cold run time: 106914 ms
Total hot run time: 34706 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5152	5144	5109	5109
q2	257	331	236	236
q3	2164	2718	2324	2324
q4	1390	1810	1311	1311
q5	4255	4506	4543	4506
q6	219	182	141	141
q7	2033	1927	1941	1927
q8	2748	2582	2627	2582
q9	7426	7389	7401	7389
q10	3051	3347	2867	2867
q11	603	523	517	517
q12	710	831	650	650
q13	3622	3999	3278	3278
q14	312	310	281	281
q15	544	526	505	505
q16	1092	1119	1075	1075
q17	1229	1582	1429	1429
q18	7758	7805	7393	7393
q19	790	762	856	762
q20	1927	1941	1822	1822
q21	4767	4304	4391	4304
q22	1102	1049	1011	1011
Total cold run time: 53151 ms
Total hot run time: 51419 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 186793 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 86d29faee706ff1cf2c338d8cf5c91bc01ecc205, data reload: false

query1	1036	397	396	396
query2	6614	1726	1713	1713
query3	6759	225	224	224
query4	26258	23343	23432	23343
query5	4478	655	510	510
query6	343	246	229	229
query7	4656	507	299	299
query8	292	265	257	257
query9	8655	2958	2930	2930
query10	503	350	303	303
query11	15831	15040	14853	14853
query12	189	131	118	118
query13	1668	554	436	436
query14	10737	9214	9122	9122
query15	202	189	172	172
query16	7237	690	467	467
query17	1217	745	620	620
query18	1984	420	352	352
query19	230	198	177	177
query20	132	126	129	126
query21	220	133	120	120
query22	3902	4238	4020	4020
query23	33894	33018	33213	33018
query24	8148	2395	2396	2395
query25	621	520	456	456
query26	1245	280	173	173
query27	2801	510	359	359
query28	4436	2234	2232	2232
query29	823	650	502	502
query30	301	223	195	195
query31	915	800	750	750
query32	94	85	83	83
query33	595	389	353	353
query34	811	860	540	540
query35	838	852	778	778
query36	971	1013	890	890
query37	129	116	97	97
query38	3513	3494	3463	3463
query39	1493	1422	1432	1422
query40	229	136	128	128
query41	63	62	61	61
query42	132	125	121	121
query43	505	475	468	468
query44	1241	791	786	786
query45	189	186	179	179
query46	876	983	649	649
query47	1773	1788	1690	1690
query48	396	427	353	353
query49	732	493	424	424
query50	658	697	407	407
query51	3909	3908	3882	3882
query52	118	115	108	108
query53	247	273	211	211
query54	330	346	316	316
query55	100	97	100	97
query56	377	371	363	363
query57	1165	1222	1126	1126
query58	308	310	305	305
query59	2561	2599	2558	2558
query60	383	387	359	359
query61	196	195	184	184
query62	793	735	680	680
query63	234	203	209	203
query64	4662	1299	997	997
query65	4060	3971	4020	3971
query66	1177	462	374	374
query67	15250	14998	14951	14951
query68	7546	939	615	615
query69	512	356	302	302
query70	1348	1314	1248	1248
query71	433	374	345	345
query72	6089	4936	2680	2680
query73	662	613	372	372
query74	9003	8810	8987	8810
query75	3271	3249	2815	2815
query76	3259	1106	726	726
query77	523	414	347	347
query78	9556	9655	8906	8906
query79	2410	870	615	615
query80	650	578	544	544
query81	517	262	228	228
query82	211	167	140	140
query83	261	265	252	252
query84	253	113	101	101
query85	896	499	445	445
query86	396	334	295	295
query87	3712	3689	3548	3548
query88	3837	2272	2264	2264
query89	380	336	294	294
query90	1956	241	240	240
query91	172	160	136	136
query92	95	79	75	75
query93	1938	985	641	641
query94	730	441	346	346
query95	430	351	339	339
query96	490	595	287	287
query97	2880	2973	2873	2873
query98	248	220	215	215
query99	1329	1420	1305	1305
Total cold run time: 273428 ms
Total hot run time: 186793 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 27.65 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 86d29faee706ff1cf2c338d8cf5c91bc01ecc205, data reload: false

query1	0.06	0.05	0.05
query2	0.10	0.06	0.05
query3	0.26	0.09	0.08
query4	1.60	0.11	0.10
query5	0.27	0.25	0.26
query6	1.17	0.65	0.64
query7	0.04	0.03	0.03
query8	0.05	0.05	0.04
query9	0.57	0.52	0.52
query10	0.58	0.56	0.57
query11	0.17	0.12	0.11
query12	0.15	0.12	0.11
query13	0.62	0.60	0.60
query14	1.01	0.99	1.01
query15	0.84	0.84	0.83
query16	0.39	0.39	0.38
query17	1.05	1.02	0.99
query18	0.21	0.20	0.20
query19	1.89	1.79	1.76
query20	0.02	0.01	0.02
query21	15.45	0.21	0.14
query22	4.96	0.07	0.05
query23	15.65	0.26	0.10
query24	2.67	1.17	0.70
query25	0.09	0.06	0.05
query26	0.15	0.14	0.13
query27	0.06	0.05	0.06
query28	4.78	1.21	0.97
query29	12.53	3.83	3.18
query30	0.29	0.13	0.11
query31	2.82	0.57	0.38
query32	3.23	0.55	0.46
query33	3.03	3.07	3.04
query34	15.69	5.21	4.56
query35	4.55	4.59	4.59
query36	0.66	0.53	0.49
query37	0.10	0.07	0.06
query38	0.07	0.04	0.04
query39	0.04	0.02	0.02
query40	0.16	0.14	0.14
query41	0.09	0.03	0.03
query42	0.04	0.03	0.03
query43	0.04	0.03	0.04
Total cold run time: 98.2 s
Total hot run time: 27.65 s

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.81% (18285/34621)
Line Coverage 38.18% (166263/435440)
Region Coverage 33.18% (129273/389586)
Branch Coverage 33.91% (55463/163578)

@morningman
Copy link
Contributor

run check_coverage

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100% (0/0) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.58% (24351/34021)
Line Coverage 58.07% (253235/436114)
Region Coverage 53.45% (211192/395097)
Branch Coverage 54.72% (90098/164653)

@morningman morningman merged commit 2c99d07 into apache:master Nov 15, 2025
27 of 29 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 15, 2025
…lt value to true. (#58017)

### What problem does this PR solve?

Related PR: #55935, #57833

Problem Summary:

### Release note
Because the time task scheduler timeout issue, in #55935, we set
`enable_task_executor_in_internal_table` conf's default value to true.
in #57833, we fix it for some cases. So in this PR, set
`enable_task_executor_in_internal_table` conf's default value to true.
morningman pushed a commit that referenced this pull request Nov 20, 2025
nagisa-kunhah pushed a commit to nagisa-kunhah/doris that referenced this pull request Dec 14, 2025
…lt value to true. (apache#58017)

### What problem does this PR solve?

Related PR: apache#55935, apache#57833

Problem Summary:

### Release note
Because the time task scheduler timeout issue, in apache#55935, we set
`enable_task_executor_in_internal_table` conf's default value to true.
in apache#57833, we fix it for some cases. So in this PR, set
`enable_task_executor_in_internal_table` conf's default value to true.
nagisa-kunhah pushed a commit to nagisa-kunhah/doris that referenced this pull request Dec 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants