-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[Enhancement](function) The date_add function supports MINUTE_SECOND as interval type #58032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
TPC-H: Total hot run time: 34508 ms |
TPC-DS: Total hot run time: 187814 ms |
ClickBench: Total hot run time: 27.39 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
FE Regression Coverage ReportIncrement line coverage |
ff31e72 to
c8cf12b
Compare
|
run buildall |
TPC-H: Total hot run time: 34251 ms |
TPC-DS: Total hot run time: 187820 ms |
ClickBench: Total hot run time: 27.44 s |
FE UT Coverage ReportIncrement line coverage |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
FE Regression Coverage ReportIncrement line coverage |
|
run nonConcurrent |
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
fe/fe-core/src/main/antlr4/org/apache/doris/nereids/DorisLexer.g4
Outdated
Show resolved
Hide resolved
fe/fe-core/src/main/antlr4/org/apache/doris/nereids/DorisParser.g4
Outdated
Show resolved
Hide resolved
...est/suites/query_p0/sql_functions/datetime_functions/test_dateadd_with_other_timeunit.groovy
Show resolved
Hide resolved
|
need a document |
|
run buildall |
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
|
run buildall |
FE UT Coverage ReportIncrement line coverage |
|
run performance |
TPC-H: Total hot run time: 34273 ms |
TPC-DS: Total hot run time: 185034 ms |
ClickBench: Total hot run time: 27.47 s |
FE Regression Coverage ReportIncrement line coverage |
zclllyybb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
FE Regression Coverage ReportIncrement line coverage |
…as interval type (apache#58032) The date_add function supports new type: MINUTE_SECOND, now we can use a string in the format 'minute:second' as the INTERVAL parameter. ``` mysql> select DATE_ADD('2025-10-23 10:10:10', INTERVAL '1:1' MINUTE_SECOND); +---------------------------------------------------------------+ | DATE_ADD('2025-10-23 10:10:10', INTERVAL '1:1' MINUTE_SECOND) | +---------------------------------------------------------------+ | 2025-10-23 10:11:11 | +---------------------------------------------------------------+ 1 row in set (0.01 sec) mysql> select DATE_ADD('2025-10-23 10:10:10', INTERVAL '-1:1' MINUTE_SECOND); +----------------------------------------------------------------+ | DATE_ADD('2025-10-23 10:10:10', INTERVAL '-1:1' MINUTE_SECOND) | +----------------------------------------------------------------+ | 2025-10-23 10:09:09 | +----------------------------------------------------------------+ 1 row in set (0.00 sec) ``
…as interval type (apache#58032) The date_add function supports new type: MINUTE_SECOND, now we can use a string in the format 'minute:second' as the INTERVAL parameter. ``` mysql> select DATE_ADD('2025-10-23 10:10:10', INTERVAL '1:1' MINUTE_SECOND); +---------------------------------------------------------------+ | DATE_ADD('2025-10-23 10:10:10', INTERVAL '1:1' MINUTE_SECOND) | +---------------------------------------------------------------+ | 2025-10-23 10:11:11 | +---------------------------------------------------------------+ 1 row in set (0.01 sec) mysql> select DATE_ADD('2025-10-23 10:10:10', INTERVAL '-1:1' MINUTE_SECOND); +----------------------------------------------------------------+ | DATE_ADD('2025-10-23 10:10:10', INTERVAL '-1:1' MINUTE_SECOND) | +----------------------------------------------------------------+ | 2025-10-23 10:09:09 | +----------------------------------------------------------------+ 1 row in set (0.00 sec) ``
…as interval type (apache#58032) The date_add function supports new type: MINUTE_SECOND, now we can use a string in the format 'minute:second' as the INTERVAL parameter. ``` mysql> select DATE_ADD('2025-10-23 10:10:10', INTERVAL '1:1' MINUTE_SECOND); +---------------------------------------------------------------+ | DATE_ADD('2025-10-23 10:10:10', INTERVAL '1:1' MINUTE_SECOND) | +---------------------------------------------------------------+ | 2025-10-23 10:11:11 | +---------------------------------------------------------------+ 1 row in set (0.01 sec) mysql> select DATE_ADD('2025-10-23 10:10:10', INTERVAL '-1:1' MINUTE_SECOND); +----------------------------------------------------------------+ | DATE_ADD('2025-10-23 10:10:10', INTERVAL '-1:1' MINUTE_SECOND) | +----------------------------------------------------------------+ | 2025-10-23 10:09:09 | +----------------------------------------------------------------+ 1 row in set (0.00 sec) ``
… with TimeStampTZ args and ret type. (#60021) ### What problem does this PR solve? pick: #58032 #58665 #59206 Issue Number: close #xxx Related PR: #xxx Problem Summary: ### Release note None ### Check List (For Author) - Test <!-- At least one of them must be included. --> - [ ] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason <!-- Add your reason? --> - Behavior changed: - [ ] No. - [ ] Yes. <!-- Explain the behavior change --> - Does this need documentation? - [ ] No. - [ ] Yes. <!-- Add document PR link here. eg: apache/doris-website#1214 --> ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into --> --------- Co-authored-by: csding <65964830+codeDing18@users.noreply.github.com>
What problem does this PR solve?
The date_add function supports new type: MINUTE_SECOND, now we can use a string in the format 'minute:second' as the INTERVAL parameter.
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)