Skip to content

Conversation

@freemandealer
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Nov 14, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>
@freemandealer
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 35079 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 6de1c9dae03e41841f641f48c790ac7a1de63c2f, data reload: false

------ Round 1 ----------------------------------
q1	17644	5197	5047	5047
q2	2062	315	206	206
q3	10276	1263	730	730
q4	10220	885	369	369
q5	7488	2475	2360	2360
q6	192	173	139	139
q7	934	771	646	646
q8	9344	1301	1259	1259
q9	7097	5264	5113	5113
q10	6892	2244	1775	1775
q11	488	300	276	276
q12	371	376	236	236
q13	17804	3673	3081	3081
q14	226	235	212	212
q15	585	517	506	506
q16	1012	995	939	939
q17	596	880	378	378
q18	7462	7369	7595	7369
q19	1133	1011	613	613
q20	377	365	234	234
q21	4567	3445	2524	2524
q22	1161	1074	1067	1067
Total cold run time: 107931 ms
Total hot run time: 35079 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5437	5328	5412	5328
q2	262	338	242	242
q3	2407	2876	2511	2511
q4	1472	1860	1486	1486
q5	4544	4513	4690	4513
q6	213	167	127	127
q7	1998	1903	1854	1854
q8	2833	2619	2552	2552
q9	7305	7298	7421	7298
q10	3052	3169	2866	2866
q11	604	531	516	516
q12	680	732	597	597
q13	3282	3690	3063	3063
q14	268	279	268	268
q15	546	502	489	489
q16	1031	1031	990	990
q17	1114	1486	1346	1346
q18	7484	7010	6957	6957
q19	772	789	812	789
q20	1922	1954	1818	1818
q21	4796	4388	4267	4267
q22	1073	1034	993	993
Total cold run time: 53095 ms
Total hot run time: 50870 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 188341 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 6de1c9dae03e41841f641f48c790ac7a1de63c2f, data reload: false

query1	1022	411	431	411
query2	6557	1739	1707	1707
query3	6751	226	218	218
query4	26986	23835	23349	23349
query5	4439	654	482	482
query6	330	241	230	230
query7	4644	510	293	293
query8	309	258	261	258
query9	8712	2611	2608	2608
query10	501	326	287	287
query11	15287	15010	14853	14853
query12	175	124	114	114
query13	1691	584	447	447
query14	10775	9677	9538	9538
query15	204	195	179	179
query16	7698	662	531	531
query17	1233	741	610	610
query18	2009	425	324	324
query19	208	203	181	181
query20	132	125	120	120
query21	212	131	113	113
query22	3929	4103	3924	3924
query23	33906	33145	32835	32835
query24	8463	2458	2454	2454
query25	590	515	470	470
query26	1240	271	162	162
query27	2760	501	362	362
query28	4399	2228	2197	2197
query29	812	644	491	491
query30	301	228	201	201
query31	891	799	748	748
query32	81	80	72	72
query33	602	383	324	324
query34	798	852	533	533
query35	838	847	751	751
query36	932	999	934	934
query37	118	114	84	84
query38	3533	3574	3515	3515
query39	1493	1441	1412	1412
query40	217	130	117	117
query41	62	60	60	60
query42	130	113	111	111
query43	493	506	473	473
query44	1245	740	745	740
query45	192	180	171	171
query46	877	994	661	661
query47	1753	1791	1715	1715
query48	389	456	325	325
query49	764	504	405	405
query50	644	681	407	407
query51	3844	3861	3815	3815
query52	106	114	104	104
query53	250	287	192	192
query54	312	304	287	287
query55	92	86	86	86
query56	339	314	295	295
query57	1179	1194	1107	1107
query58	293	269	279	269
query59	2551	2698	2570	2570
query60	362	385	330	330
query61	183	159	153	153
query62	779	740	637	637
query63	240	202	196	196
query64	4488	1172	840	840
query65	4062	3963	3932	3932
query66	1143	433	332	332
query67	15102	15203	15009	15009
query68	3405	977	617	617
query69	513	324	290	290
query70	1346	1220	1265	1220
query71	407	352	322	322
query72	5583	5052	5072	5052
query73	620	582	361	361
query74	8907	8874	8813	8813
query75	3330	3346	2862	2862
query76	3240	1158	760	760
query77	526	424	334	334
query78	9668	9861	8851	8851
query79	1548	860	623	623
query80	1749	564	510	510
query81	548	261	231	231
query82	418	159	127	127
query83	366	261	248	248
query84	251	111	94	94
query85	918	471	428	428
query86	385	314	309	309
query87	3782	3842	3636	3636
query88	2870	2303	2296	2296
query89	393	332	288	288
query90	1766	224	229	224
query91	171	171	134	134
query92	74	74	70	70
query93	1129	1006	652	652
query94	685	446	355	355
query95	419	334	317	317
query96	485	561	295	295
query97	2923	2991	2854	2854
query98	243	216	210	210
query99	1338	1409	1297	1297
Total cold run time: 267658 ms
Total hot run time: 188341 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 27.69 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 6de1c9dae03e41841f641f48c790ac7a1de63c2f, data reload: false

query1	0.06	0.05	0.04
query2	0.09	0.05	0.05
query3	0.26	0.09	0.08
query4	1.61	0.12	0.11
query5	0.28	0.26	0.26
query6	1.16	0.63	0.65
query7	0.04	0.03	0.03
query8	0.05	0.04	0.04
query9	0.58	0.52	0.52
query10	0.57	0.58	0.57
query11	0.16	0.11	0.11
query12	0.15	0.12	0.11
query13	0.64	0.60	0.60
query14	1.01	1.01	1.02
query15	0.84	0.82	0.84
query16	0.39	0.39	0.39
query17	1.01	1.00	1.04
query18	0.21	0.20	0.20
query19	1.93	1.85	1.82
query20	0.02	0.02	0.01
query21	15.47	0.18	0.13
query22	5.12	0.07	0.05
query23	15.64	0.24	0.09
query24	2.55	0.78	0.75
query25	0.08	0.06	0.06
query26	0.14	0.12	0.12
query27	0.07	0.06	0.06
query28	4.33	1.15	0.93
query29	12.55	3.90	3.18
query30	0.28	0.14	0.12
query31	2.81	0.58	0.38
query32	3.23	0.55	0.46
query33	3.05	3.09	3.04
query34	15.87	5.17	4.54
query35	4.54	4.55	4.59
query36	0.66	0.50	0.49
query37	0.10	0.07	0.06
query38	0.06	0.04	0.03
query39	0.03	0.02	0.02
query40	0.17	0.15	0.14
query41	0.09	0.03	0.03
query42	0.03	0.03	0.03
query43	0.04	0.03	0.03
Total cold run time: 97.97 s
Total hot run time: 27.69 s

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 58.06% (18/31) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.81% (18282/34621)
Line Coverage 38.17% (166200/435467)
Region Coverage 33.13% (129162/389865)
Branch Coverage 33.89% (55448/163608)

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Nov 14, 2025
@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 57.89% (22/38) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.54% (24340/34021)
Line Coverage 58.05% (253166/436149)
Region Coverage 53.47% (211441/395454)
Branch Coverage 54.78% (90221/164691)

@gavinchou gavinchou merged commit 5ebf22d into apache:master Nov 18, 2025
26 of 28 checks passed
nagisa-kunhah pushed a commit to nagisa-kunhah/doris that referenced this pull request Dec 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants