branch-4.0: [fix](blockrule)Fix concurrency issues in SqlBlockRuleMgr after restart fe #58296 #58326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rt fe (#58296) Even if the map is defined as a ConcurrentHashMap, it becomes a LinkedHashMap after Gson deserialization. The current PR provides a simple solution for SqlBlockRuleMgr, but other modules have the same issue and require a unified approach. **error msg** ``` 2025-11-20 03:02:08,499 WARN (thrift-server-pool-8|216) [StmtExecutor.executeByLegacy():1172] execute Exception. stmt[119845, 6e589b912ba24ce4-aeb134c8d43662b5] java.util.ConcurrentModificationException: null at com.google.gson.internal.LinkedTreeMap$LinkedTreeMapIterator.nextNode(LinkedTreeMap.java:572) ~[gson-2.10.1.jar:?] at com.google.gson.internal.LinkedTreeMap$EntrySet$1.next(LinkedTreeMap.java:596) ~[gson-2.10.1.jar:?] at com.google.gson.internal.LinkedTreeMap$EntrySet$1.next(LinkedTreeMap.java:594) ~[gson-2.10.1.jar:?] at java.util.AbstractMap$2$1.next(AbstractMap.java:418) ~[?:?] at java.util.Iterator.forEachRemaining(Iterator.java:133) ~[?:?] at java.util.Spliterators$IteratorSpliterator.forEachRemaining(Spliterators.java:1845) ~[?:?] at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509) ~[?:?] at java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499) ~[?:?] at java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:921) ~[?:?] at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234) ~[?:?] at java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:682) ~[?:?] at org.apache.doris.blockrule.SqlBlockRuleMgr.matchSql(SqlBlockRuleMgr.java:241) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.qe.StmtExecutor.checkBlockRulesByRegex(StmtExecutor.java:678) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.qe.StmtExecutor.checkBlockRules(StmtExecutor.java:670) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.qe.StmtExecutor.executeByLegacy(StmtExecutor.java:1079) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.qe.StmtExecutor.execute(StmtExecutor.java:653) ~[doris-fe.jar:1.2-SNAPSHOT] ```
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
|
run buildall |
Contributor
FE UT Coverage ReportIncrement line coverage |
yiguolei
approved these changes
Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #58296