Skip to content

[fix](remote) Endpoint contains http:// will result in UnknownHostException #58500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
w41ter merged 1 commit into from
Dec 3, 2025
Merged

[fix](remote) Endpoint contains http:// will result in UnknownHostException #58500

w41ter merged 1 commit into from
Dec 3, 2025

Conversation

@wyxxxcat
Copy link
Contributor

@wyxxxcat wyxxxcat commented Nov 28, 2025 •
edited
Loading

What problem does this PR solve?

Problem Summary:

endponit maybe contains http://, incorrect splicing will lead to UnknownHostException

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

hello-stephen commented Nov 28, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@wyxxxcat
Copy link
Contributor Author

wyxxxcat commented Nov 28, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Nov 28, 2025

TPC-H: Total hot run time: 34077 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 93104cc6fefe150e3e6cf35e27f3027fcbe5b223, data reload: false

------ Round 1 ----------------------------------
q1	17609	5119	4909	4909
q2	2038	317	208	208
q3	10301	1303	748	748
q4	10222	832	370	370
q5	7519	2458	2231	2231
q6	184	174	134	134
q7	962	795	629	629
q8	9351	1351	1057	1057
q9	6915	5261	5260	5260
q10	6827	2247	1810	1810
q11	535	314	282	282
q12	339	366	232	232
q13	17755	3683	3033	3033
q14	229	247	212	212
q15	575	526	512	512
q16	910	858	817	817
q17	581	815	418	418
q18	7264	7186	7002	7002
q19	972	961	571	571
q20	339	335	219	219
q21	2975	3130	2468	2468
q22	1007	999	955	955
Total cold run time: 105409 ms
Total hot run time: 34077 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4927	4900	4915	4900
q2	314	405	319	319
q3	2167	2673	2311	2311
q4	1318	1744	1322	1322
q5	4221	4158	4663	4158
q6	235	175	139	139
q7	2115	2029	1841	1841
q8	2666	2485	2464	2464
q9	7872	7407	7403	7403
q10	3090	3241	2847	2847
q11	587	521	496	496
q12	686	771	642	642
q13	3500	3807	3434	3434
q14	311	312	284	284
q15	542	513	536	513
q16	975	956	898	898
q17	1243	1458	1422	1422
q18	8199	7602	7623	7602
q19	793	774	830	774
q20	1980	2100	1913	1913
q21	4881	4522	4499	4499
q22	1045	1015	985	985
Total cold run time: 53667 ms
Total hot run time: 51166 ms

@doris-robot
Copy link

doris-robot commented Nov 28, 2025

TPC-DS: Total hot run time: 181652 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 93104cc6fefe150e3e6cf35e27f3027fcbe5b223, data reload: false

query1	1076	402	399	399
query2	6559	1561	1600	1561
query3	6749	230	222	222
query4	25430	23446	22901	22901
query5	5858	624	457	457
query6	351	243	230	230
query7	4645	519	312	312
query8	327	265	252	252
query9	8712	2610	2593	2593
query10	574	356	311	311
query11	15321	15367	14560	14560
query12	178	134	116	116
query13	1692	580	449	449
query14	10742	5579	5570	5570
query15	283	198	194	194
query16	7770	699	511	511
query17	1632	814	647	647
query18	2052	441	380	380
query19	320	221	192	192
query20	133	128	121	121
query21	223	137	116	116
query22	3855	3978	3855	3855
query23	32900	32081	31941	31941
query24	8107	2410	2465	2410
query25	620	569	508	508
query26	1226	288	172	172
query27	2685	496	369	369
query28	4412	2149	2150	2149
query29	828	656	530	530
query30	312	255	213	213
query31	817	721	622	622
query32	96	80	78	78
query33	667	380	355	355
query34	805	876	534	534
query35	787	818	743	743
query36	903	922	836	836
query37	126	111	86	86
query38	3892	3782	3802	3782
query39	1427	1402	1403	1402
query40	225	134	123	123
query41	66	62	64	62
query42	126	110	112	110
query43	442	451	425	425
query44	1305	758	755	755
query45	214	200	182	182
query46	877	1000	655	655
query47	1669	1699	1625	1625
query48	397	435	340	340
query49	766	502	425	425
query50	660	682	414	414
query51	3859	3938	3844	3844
query52	115	121	112	112
query53	239	262	198	198
query54	311	298	278	278
query55	96	95	91	91
query56	339	332	331	331
query57	1121	1154	1098	1098
query58	282	288	273	273
query59	2300	2485	2293	2293
query60	359	356	336	336
query61	155	155	164	155
query62	770	768	677	677
query63	239	196	195	195
query64	4504	1247	922	922
query65	4050	3974	3986	3974
query66	1024	470	341	341
query67	15529	14813	14981	14813
query68	8374	982	633	633
query69	558	340	306	306
query70	1123	1022	1048	1022
query71	515	341	304	304
query72	5757	4926	4826	4826
query73	692	588	344	344
query74	8788	8748	8676	8676
query75	3891	3040	2610	2610
query76	3756	1136	717	717
query77	816	416	314	314
query78	9462	9529	8819	8819
query79	2669	842	588	588
query80	679	598	541	541
query81	510	271	234	234
query82	464	139	113	113
query83	297	266	252	252
query84	312	112	96	96
query85	899	495	452	452
query86	349	281	296	281
query87	4062	4070	3974	3974
query88	4095	2297	2298	2297
query89	396	346	302	302
query90	1961	223	227	223
query91	178	176	147	147
query92	90	70	72	70
query93	2222	1009	658	658
query94	722	458	350	350
query95	491	422	403	403
query96	524	559	286	286
query97	2654	2662	2596	2596
query98	244	218	216	216
query99	1407	1370	1276	1276
Total cold run time: 276088 ms
Total hot run time: 181652 ms

@doris-robot
Copy link

doris-robot commented Nov 28, 2025

ClickBench: Total hot run time: 27.38 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 93104cc6fefe150e3e6cf35e27f3027fcbe5b223, data reload: false

query1	0.06	0.05	0.05
query2	0.09	0.05	0.05
query3	0.26	0.08	0.09
query4	1.61	0.11	0.11
query5	0.27	0.26	0.24
query6	1.18	0.64	0.62
query7	0.03	0.03	0.03
query8	0.06	0.04	0.04
query9	0.56	0.53	0.51
query10	0.56	0.56	0.56
query11	0.16	0.11	0.11
query12	0.15	0.11	0.11
query13	0.64	0.61	0.61
query14	0.99	0.98	0.99
query15	0.81	0.80	0.81
query16	0.40	0.40	0.39
query17	1.09	1.09	1.03
query18	0.22	0.21	0.22
query19	1.81	1.88	1.83
query20	0.02	0.01	0.01
query21	15.46	0.27	0.14
query22	4.85	0.05	0.05
query23	16.22	0.26	0.09
query24	1.29	0.28	0.43
query25	0.10	0.06	0.06
query26	0.15	0.14	0.14
query27	0.07	0.06	0.04
query28	3.89	1.23	1.01
query29	12.58	3.97	3.23
query30	0.27	0.13	0.13
query31	2.82	0.62	0.40
query32	3.23	0.54	0.46
query33	3.03	3.04	3.03
query34	16.67	5.16	4.52
query35	4.53	4.58	4.62
query36	0.66	0.51	0.48
query37	0.10	0.07	0.07
query38	0.07	0.04	0.04
query39	0.05	0.03	0.03
query40	0.18	0.14	0.15
query41	0.08	0.03	0.03
query42	0.04	0.02	0.02
query43	0.04	0.04	0.04
Total cold run time: 97.35 s
Total hot run time: 27.38 s

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 30, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 30, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 30, 2025

PR approved by anyone and no changes requested.

@w41ter w41ter merged commit 0b5c2c9 into apache:master Dec 3, 2025
29 of 31 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 3, 2025
@wyxxxcat
[fix](remote) Endpoint contains http:// will result in `UnknownHost…
f8d9795 
…Exception` (#58500)

endponit maybe contains `http://`, incorrect splicing will lead to
`UnknownHostException`
@github-actions github-actions bot mentioned this pull request Dec 3, 2025
Merged
yiguolei pushed a commit that referenced this pull request Dec 3, 2025
@github-actions @wyxxxcat
branch-4.0: [fix](remote) Endpoint contains http:// will result in …
74df91a 
…`UnknownHostException` #58500 (#58667)

Cherry-picked from #58500

Co-authored-by: Yixuan Wang <wangyixuan@selectdb.com>
nagisa-kunhah pushed a commit to nagisa-kunhah/doris that referenced this pull request Dec 14, 2025
@wyxxxcat @nagisa-kunhah
[fix](remote) Endpoint contains http:// will result in `UnknownHost…
193ac71 
…Exception` (apache#58500)

endponit maybe contains `http://`, incorrect splicing will lead to
`UnknownHostException`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gavinchou gavinchou gavinchou approved these changes

@w41ter w41ter w41ter approved these changes

@dataroaring dataroaring Awaiting requested review from dataroaring dataroaring is a code owner

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/4.0.2-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@wyxxxcat @hello-stephen @doris-robot @gavinchou @w41ter @yiguolei