Skip to content

[fix](ut) fix unstable ut: testGetHostAbnormal #58623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morrySnow merged 4 commits into from
Dec 3, 2025
Merged

[fix](ut) fix unstable ut: testGetHostAbnormal #58623

morrySnow merged 4 commits into from
Dec 3, 2025

Conversation

@924060929
Copy link
Contributor

@924060929 924060929 commented Dec 2, 2025

What problem does this PR solve?

fix unstable ut: testGetHostAbnormal

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@924060929
Copy link
Contributor Author

924060929 commented Dec 2, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Dec 2, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

morrySnow
morrySnow reviewed Dec 2, 2025
View reviewed changes
fe/fe-core/src/test/java/org/apache/doris/qe/SimpleSchedulerTest.java Outdated
SimpleScheduler.addToBlacklist(be1.getId(), "test");
SimpleScheduler.addToBlacklist(be2.getId(), "test");
SimpleScheduler.addToBlacklist(be3.getId(), "test");
SimpleScheduler.addToBlacklist(be4.getId(), "test");
Copy link
Contributor

@morrySnow morrySnow Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need sleep? or not?

Copy link
Contributor Author

@924060929 924060929 Dec 2, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not

@doris-robot
Copy link

doris-robot commented Dec 2, 2025

TPC-H: Total hot run time: 35608 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit ea27fbe7af464a24cec12cc9e9852ae8ddf212aa, data reload: false

------ Round 1 ----------------------------------
q1	17658	5308	5071	5071
q2	2075	331	210	210
q3	10231	1434	790	790
q4	10216	879	330	330
q5	7563	2626	2467	2467
q6	213	190	138	138
q7	1020	843	654	654
q8	9367	1583	1268	1268
q9	7056	5610	5520	5520
q10	6869	2233	1833	1833
q11	513	317	290	290
q12	340	423	244	244
q13	17776	3817	3055	3055
q14	242	245	221	221
q15	601	529	504	504
q16	927	883	813	813
q17	676	884	569	569
q18	7520	7111	7145	7111
q19	925	1098	640	640
q20	374	379	239	239
q21	4130	4008	2683	2683
q22	1072	989	958	958
Total cold run time: 107364 ms
Total hot run time: 35608 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5218	5169	5165	5165
q2	351	402	339	339
q3	2183	2808	2305	2305
q4	1364	1803	1294	1294
q5	4650	4767	4599	4599
q6	266	186	132	132
q7	2119	2027	1843	1843
q8	2941	2718	2635	2635
q9	7587	7634	7582	7582
q10	3267	3454	2891	2891
q11	644	512	490	490
q12	712	749	610	610
q13	3655	4175	3304	3304
q14	316	335	330	330
q15	591	533	533	533
q16	890	950	889	889
q17	1256	1659	1564	1564
q18	8017	7864	7551	7551
q19	913	930	954	930
q20	2060	2089	1792	1792
q21	4770	4419	4074	4074
q22	1087	1048	980	980
Total cold run time: 54857 ms
Total hot run time: 51832 ms

@924060929
Copy link
Contributor Author

924060929 commented Dec 2, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Dec 2, 2025

TPC-H: Total hot run time: 34791 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 40edfead2d5211e65a174b3d16f27198f379b506, data reload: false

------ Round 1 ----------------------------------
q1	17632	5132	4964	4964
q2	2069	328	213	213
q3	10212	1332	778	778
q4	10223	889	333	333
q5	7535	2428	2211	2211
q6	189	172	138	138
q7	980	798	668	668
q8	9357	1455	1198	1198
q9	7086	5326	5316	5316
q10	6861	2202	1806	1806
q11	530	316	295	295
q12	361	377	230	230
q13	17809	3658	3053	3053
q14	232	229	211	211
q15	587	529	512	512
q16	908	868	824	824
q17	688	819	483	483
q18	7487	7123	7190	7123
q19	1122	960	608	608
q20	366	363	237	237
q21	4076	3657	2653	2653
q22	1007	968	937	937
Total cold run time: 107317 ms
Total hot run time: 34791 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5066	4996	4993	4993
q2	325	385	319	319
q3	2124	2697	2286	2286
q4	1360	1761	1327	1327
q5	4214	4551	4565	4551
q6	210	175	128	128
q7	2042	2042	1831	1831
q8	2764	2635	2569	2569
q9	7444	7540	7481	7481
q10	3122	3267	2888	2888
q11	601	521	499	499
q12	727	777	649	649
q13	3616	4118	3211	3211
q14	296	300	275	275
q15	570	520	514	514
q16	901	931	909	909
q17	1214	1421	1465	1421
q18	7851	7650	7694	7650
q19	962	867	872	867
q20	1886	1976	1796	1796
q21	4823	4260	4121	4121
q22	1069	1020	953	953
Total cold run time: 53187 ms
Total hot run time: 51238 ms

@924060929
Copy link
Contributor Author

924060929 commented Dec 2, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Dec 2, 2025

TPC-H: Total hot run time: 35859 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 23f84d09eddc2f26b550b4013011c818e31c11f4, data reload: false

------ Round 1 ----------------------------------
q1	17645	5136	4895	4895
q2	2039	350	214	214
q3	10207	1303	725	725
q4	10210	822	321	321
q5	7495	2442	2186	2186
q6	195	166	137	137
q7	969	792	635	635
q8	9361	1447	1144	1144
q9	7034	5375	5328	5328
q10	6790	2218	1798	1798
q11	541	333	304	304
q12	343	373	228	228
q13	17790	3711	3006	3006
q14	247	243	219	219
q15	575	510	510	510
q16	918	877	824	824
q17	702	813	523	523
q18	7634	7557	7997	7557
q19	1178	1014	624	624
q20	419	391	247	247
q21	4357	4014	3382	3382
q22	1140	1052	1054	1052
Total cold run time: 107789 ms
Total hot run time: 35859 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5173	5130	5135	5130
q2	343	416	311	311
q3	2369	2903	2497	2497
q4	1470	1852	1464	1464
q5	4536	4451	4470	4451
q6	211	174	128	128
q7	2115	1913	1772	1772
q8	2596	2578	2438	2438
q9	7478	7525	7517	7517
q10	3108	3188	2652	2652
q11	564	500	475	475
q12	635	692	593	593
q13	3294	3612	3022	3022
q14	274	295	255	255
q15	529	490	493	490
q16	864	891	837	837
q17	1121	1303	1290	1290
q18	7513	7026	7220	7026
q19	842	811	869	811
q20	1954	2012	1866	1866
q21	4669	4256	4080	4080
q22	1085	1026	981	981
Total cold run time: 52743 ms
Total hot run time: 50086 ms

@doris-robot
Copy link

doris-robot commented Dec 2, 2025

TPC-DS: Total hot run time: 182444 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 23f84d09eddc2f26b550b4013011c818e31c11f4, data reload: false

query1	1108	410	398	398
query2	6593	1208	1170	1170
query3	6748	242	230	230
query4	25459	23359	23145	23145
query5	5255	662	512	512
query6	343	245	236	236
query7	4665	541	317	317
query8	315	254	244	244
query9	8751	2625	2643	2625
query10	554	357	347	347
query11	15282	15341	14969	14969
query12	190	120	109	109
query13	1678	555	422	422
query14	9803	5864	5891	5864
query15	205	197	185	185
query16	7663	685	531	531
query17	1182	768	609	609
query18	2060	421	330	330
query19	205	196	174	174
query20	128	125	118	118
query21	222	135	120	120
query22	3965	3961	3901	3901
query23	32886	31988	31933	31933
query24	8471	2419	2414	2414
query25	609	516	454	454
query26	1248	286	166	166
query27	2727	527	345	345
query28	4356	2167	2207	2167
query29	777	628	492	492
query30	313	245	208	208
query31	801	695	649	649
query32	86	74	72	72
query33	603	386	326	326
query34	822	872	540	540
query35	799	817	757	757
query36	902	920	835	835
query37	122	111	85	85
query38	3822	3898	3798	3798
query39	1469	1405	1398	1398
query40	228	130	120	120
query41	66	62	65	62
query42	126	114	114	114
query43	441	451	416	416
query44	1344	745	745	745
query45	199	191	192	191
query46	910	1018	662	662
query47	1702	1741	1639	1639
query48	402	436	324	324
query49	785	496	405	405
query50	693	708	422	422
query51	3973	3942	3852	3852
query52	117	121	114	114
query53	250	270	201	201
query54	331	312	294	294
query55	105	93	93	93
query56	380	361	349	349
query57	1166	1184	1075	1075
query58	329	288	293	288
query59	2329	2410	2324	2324
query60	382	372	368	368
query61	190	182	190	182
query62	796	723	654	654
query63	238	197	203	197
query64	4560	1317	1016	1016
query65	4079	3946	3969	3946
query66	1099	480	359	359
query67	15440	15083	14975	14975
query68	7872	987	628	628
query69	530	364	321	321
query70	1082	1040	1021	1021
query71	437	350	323	323
query72	5995	4807	4854	4807
query73	675	579	344	344
query74	8907	9006	8760	8760
query75	3029	3031	2508	2508
query76	3308	1170	745	745
query77	505	414	309	309
query78	9693	9655	8766	8766
query79	2749	862	590	590
query80	682	593	497	497
query81	527	277	244	244
query82	694	145	114	114
query83	287	266	253	253
query84	259	124	93	93
query85	915	482	440	440
query86	382	306	293	293
query87	4132	4060	4107	4060
query88	4306	2293	2285	2285
query89	400	335	297	297
query90	2060	229	221	221
query91	173	178	146	146
query92	92	74	71	71
query93	2551	1032	664	664
query94	743	450	333	333
query95	508	416	401	401
query96	547	566	286	286
query97	2654	2690	2558	2558
query98	252	218	223	218
query99	1324	1396	1266	1266
Total cold run time: 274117 ms
Total hot run time: 182444 ms

@doris-robot
Copy link

doris-robot commented Dec 2, 2025

ClickBench: Total hot run time: 27.38 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 23f84d09eddc2f26b550b4013011c818e31c11f4, data reload: false

query1	0.05	0.05	0.05
query2	0.10	0.05	0.05
query3	0.26	0.08	0.08
query4	1.63	0.11	0.11
query5	0.27	0.26	0.27
query6	1.16	0.65	0.63
query7	0.03	0.02	0.03
query8	0.05	0.04	0.04
query9	0.59	0.51	0.51
query10	0.56	0.56	0.56
query11	0.16	0.11	0.12
query12	0.15	0.11	0.12
query13	0.64	0.60	0.61
query14	1.01	0.99	0.98
query15	0.83	0.80	0.93
query16	0.44	0.46	0.39
query17	1.12	1.06	1.08
query18	0.24	0.22	0.22
query19	1.90	1.88	1.75
query20	0.02	0.01	0.02
query21	15.44	0.28	0.15
query22	4.90	0.05	0.05
query23	16.13	0.30	0.10
query24	1.41	0.28	0.61
query25	0.06	0.07	0.11
query26	0.15	0.13	0.14
query27	0.06	0.06	0.05
query28	4.18	1.22	1.02
query29	12.65	3.93	3.21
query30	0.29	0.14	0.12
query31	2.82	0.64	0.39
query32	3.24	0.55	0.47
query33	3.03	3.09	3.08
query34	16.92	5.25	4.56
query35	4.61	4.58	4.51
query36	0.66	0.51	0.49
query37	0.11	0.06	0.06
query38	0.07	0.04	0.05
query39	0.04	0.03	0.03
query40	0.18	0.14	0.14
query41	0.09	0.04	0.03
query42	0.05	0.03	0.03
query43	0.04	0.03	0.04
Total cold run time: 98.34 s
Total hot run time: 27.38 s

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 2, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2025

PR approved by anyone and no changes requested.

@morrySnow morrySnow merged commit 0881339 into apache:master Dec 3, 2025
26 of 28 checks passed
@924060929 924060929 deleted the testGetHostAbnormal branch December 3, 2025 03:53
github-actions bot pushed a commit that referenced this pull request Dec 3, 2025
@924060929
[fix](ut) fix unstable ut: testGetHostAbnormal (#58623)
248b080
@github-actions github-actions bot mentioned this pull request Dec 3, 2025
Merged
github-actions bot pushed a commit that referenced this pull request Dec 3, 2025
@924060929
[fix](ut) fix unstable ut: testGetHostAbnormal (#58623)
f3c3afe
@github-actions github-actions bot mentioned this pull request Dec 3, 2025
Merged
yiguolei pushed a commit that referenced this pull request Dec 3, 2025
@github-actions @924060929
branch-4.0: [fix](ut) fix unstable ut: testGetHostAbnormal #58623 (#5…
c34de42 
…8659)

Cherry-picked from #58623

Co-authored-by: 924060929 <lanhuajian@selectdb.com>
@yiguolei yiguolei removed the dev/4.0.x label Dec 3, 2025
morrySnow pushed a commit that referenced this pull request Dec 4, 2025
@github-actions @924060929
branch-3.1: [fix](ut) fix unstable ut: testGetHostAbnormal #58623 (#5…
55ac1c4 
…8658)

Cherry-picked from #58623

Co-authored-by: 924060929 <lanhuajian@selectdb.com>
nagisa-kunhah pushed a commit to nagisa-kunhah/doris that referenced this pull request Dec 14, 2025
@924060929 @nagisa-kunhah
[fix](ut) fix unstable ut: testGetHostAbnormal (apache#58623)
a992842
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@starocean999 starocean999 starocean999 approved these changes

@morrySnow morrySnow morrySnow approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.1.4-merged dev/4.0.2-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@924060929 @hello-stephen @doris-robot @starocean999 @morrySnow @yiguolei