Skip to content

Conversation

@BiteTheDDDDt
Copy link
Contributor

@BiteTheDDDDt BiteTheDDDDt commented Dec 4, 2025

What problem does this PR solve?

Sometimes we don't need to calculate all_match_one (for example, when no columns are materialized in probe_side_output_column)

      SELECT /*+ LEADING({store_sales date_dim} item) */
        any(iss.i_brand_id) brand_id
      , any(iss.i_class_id) class_id
      , any(iss.i_category_id) category_id
      FROM
        store_sales
      , item iss
      , date_dim d1
      WHERE (ss_item_sk = iss.i_item_sk)
         AND (ss_sold_date_sk = d1.d_date_sk)
         AND (d1.d_year BETWEEN 1999 AND (1999 + 2));

before:
QQ_1764857385870
after:
QQ_1764857396388

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Dec 4, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@BiteTheDDDDt
Copy link
Contributor Author

run buildall

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 100.00% (13/13) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 53.34% (18634/34932)
Line Coverage 39.02% (172143/441207)
Region Coverage 33.62% (133264/396431)
Branch Coverage 34.58% (57373/165891)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (13/13) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 72.27% (24754/34254)
Line Coverage 58.96% (259891/440828)
Region Coverage 53.97% (216541/401251)
Branch Coverage 55.45% (92489/166790)

Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 7, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2025

PR approved by anyone and no changes requested.

Copy link
Member

@mrhhsg mrhhsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@BiteTheDDDDt BiteTheDDDDt merged commit 5d0fb33 into apache:master Dec 8, 2025
31 of 33 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 10, 2025
Sometimes we don't need to calculate all_match_one (for example, when no
columns are materialized in probe_side_output_column)
```sql
      SELECT /*+ LEADING({store_sales date_dim} item) */
        any(iss.i_brand_id) brand_id
      , any(iss.i_class_id) class_id
      , any(iss.i_category_id) category_id
      FROM
        store_sales
      , item iss
      , date_dim d1
      WHERE (ss_item_sk = iss.i_item_sk)
         AND (ss_sold_date_sk = d1.d_date_sk)
         AND (d1.d_year BETWEEN 1999 AND (1999 + 2));
```

before:
<img width="902" height="1092" alt="QQ_1764857385870"
src="https://github.com/user-attachments/assets/35524c81-889c-4905-b924-20745ad64bf6"
/>
after:
<img width="844" height="1042" alt="QQ_1764857396388"
src="https://github.com/user-attachments/assets/04bf2eb1-63b0-4b36-9497-4265fd25ec53"
/>
yiguolei pushed a commit that referenced this pull request Dec 11, 2025
…58901)

Cherry-picked from #58729

Co-authored-by: Pxl <xl@selectdb.com>
nagisa-kunhah pushed a commit to nagisa-kunhah/doris that referenced this pull request Dec 14, 2025
Sometimes we don't need to calculate all_match_one (for example, when no
columns are materialized in probe_side_output_column)
```sql
      SELECT /*+ LEADING({store_sales date_dim} item) */
        any(iss.i_brand_id) brand_id
      , any(iss.i_class_id) class_id
      , any(iss.i_category_id) category_id
      FROM
        store_sales
      , item iss
      , date_dim d1
      WHERE (ss_item_sk = iss.i_item_sk)
         AND (ss_sold_date_sk = d1.d_date_sk)
         AND (d1.d_year BETWEEN 1999 AND (1999 + 2));
```

before:
<img width="902" height="1092" alt="QQ_1764857385870"
src="https://github.com/user-attachments/assets/35524c81-889c-4905-b924-20745ad64bf6"
/>
after:
<img width="844" height="1042" alt="QQ_1764857396388"
src="https://github.com/user-attachments/assets/04bf2eb1-63b0-4b36-9497-4265fd25ec53"
/>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/4.0.2-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants