Skip to content

Conversation

@englefly
Copy link
Contributor

@englefly englefly commented Dec 5, 2025

What problem does this PR solve?

when group expression number exceeds memoMaxGroupExpressionSize(currently 10000), we stop to exploration group exressions.
However, join-commute is too important for join. and hence, we allow JoinCommute optimization in this situation.

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Dec 5, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@morrySnow morrySnow marked this pull request as draft December 5, 2025 04:03
@englefly
Copy link
Contributor Author

englefly commented Dec 5, 2025

run buildall

1 similar comment
@englefly
Copy link
Contributor Author

englefly commented Dec 5, 2025

run buildall

@englefly englefly marked this pull request as ready for review December 5, 2025 06:26
morrySnow
morrySnow previously approved these changes Dec 5, 2025
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 5, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2025

PR approved by anyone and no changes requested.

@hello-stephen
Copy link
Contributor

FE UT Coverage Report

Increment line coverage 100.00% (1/1) 🎉
Increment coverage report
Complete coverage report

@doris-robot
Copy link

TPC-H: Total hot run time: 34749 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit d66174e642ac285a0d40cc2eacd703ec27b7930a, data reload: false

------ Round 1 ----------------------------------
q1	17638	5143	4939	4939
q2	2148	317	201	201
q3	10216	1336	737	737
q4	10204	833	307	307
q5	7561	2439	2218	2218
q6	187	171	135	135
q7	986	806	643	643
q8	9364	1434	1194	1194
q9	7160	5335	5394	5335
q10	6850	2207	1842	1842
q11	549	309	288	288
q12	390	361	222	222
q13	17797	3688	3068	3068
q14	234	237	214	214
q15	604	508	512	508
q16	876	859	828	828
q17	688	810	509	509
q18	7683	7282	7161	7161
q19	1096	975	615	615
q20	391	357	219	219
q21	4095	3217	2618	2618
q22	1042	982	948	948
Total cold run time: 107759 ms
Total hot run time: 34749 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4979	4942	4914	4914
q2	324	419	336	336
q3	2167	2716	2338	2338
q4	1335	1770	1310	1310
q5	4235	4625	4634	4625
q6	221	179	134	134
q7	2099	2067	1906	1906
q8	2698	2610	2600	2600
q9	7469	7748	7471	7471
q10	3063	3282	2812	2812
q11	600	537	520	520
q12	683	761	613	613
q13	3595	3914	3348	3348
q14	284	317	285	285
q15	551	517	494	494
q16	902	952	907	907
q17	1220	1514	1458	1458
q18	7812	7740	7595	7595
q19	909	862	900	862
q20	1980	2112	2030	2030
q21	4952	4569	4147	4147
q22	1074	1015	974	974
Total cold run time: 53152 ms
Total hot run time: 51679 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 180121 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit d66174e642ac285a0d40cc2eacd703ec27b7930a, data reload: false

query5	4860	638	493	493
query6	351	238	218	218
query7	4666	487	278	278
query8	310	252	233	233
query9	8735	2642	2620	2620
query10	543	327	283	283
query11	15312	14715	14902	14715
query12	201	121	121	121
query13	1697	499	370	370
query14	6462	3305	3018	3018
query14_1	2915	2869	2906	2869
query15	207	200	183	183
query16	7631	495	460	460
query17	1216	733	628	628
query18	2042	448	347	347
query19	217	194	165	165
query20	130	135	120	120
query21	224	147	122	122
query22	3997	3987	3902	3902
query23	16658	16235	15953	15953
query23_1	16014	16312	16250	16250
query24	7180	1605	1196	1196
query24_1	1163	1205	1179	1179
query25	595	463	418	418
query26	1254	280	171	171
query27	2918	475	303	303
query28	4371	2187	2177	2177
query29	797	560	451	451
query30	322	246	225	225
query31	826	706	614	614
query32	86	71	69	69
query33	682	343	295	295
query34	868	869	530	530
query35	797	807	738	738
query36	907	904	818	818
query37	126	91	80	80
query38	3912	3917	3843	3843
query39	760	735	716	716
query39_1	717	699	693	693
query40	235	131	120	120
query41	68	77	70	70
query42	122	95	95	95
query43	439	426	387	387
query44	1298	770	758	758
query45	199	204	184	184
query46	935	983	590	590
query47	1700	1722	1603	1603
query48	407	322	237	237
query49	772	421	359	359
query50	681	307	232	232
query51	3852	3954	3812	3812
query52	114	94	83	83
query53	230	228	182	182
query54	320	253	252	252
query55	100	75	74	74
query56	328	303	285	285
query57	1176	1178	1101	1101
query58	294	268	255	255
query59	2364	2471	2363	2363
query60	364	322	307	307
query61	161	164	166	164
query62	775	688	655	655
query63	230	177	177	177
query64	4538	1207	933	933
query65	4076	3975	3975	3975
query66	1217	448	333	333
query67	15219	15153	14821	14821
query68	4989	975	677	677
query69	516	299	268	268
query70	1098	974	1020	974
query71	423	299	281	281
query72	5859	4775	4701	4701
query73	668	556	308	308
query74	8824	8876	8639	8639
query75	3060	3033	2517	2517
query76	3302	1129	739	739
query77	503	406	311	311
query78	9404	9722	8926	8926
query79	1036	837	585	585
query80	1307	546	466	466
query81	547	267	249	249
query82	559	132	103	103
query83	378	276	259	259
query84	263	124	95	95
query85	939	508	452	452
query86	391	298	275	275
query87	4063	4031	3978	3978
query88	2919	2128	2142	2128
query89	391	332	298	298
query90	1872	176	168	168
query91	195	186	160	160
query92	75	73	67	67
query93	1125	1074	686	686
query94	788	306	304	304
query95	596	408	338	338
query96	550	497	219	219
query97	2617	2689	2578	2578
query98	242	206	197	197
query99	1352	1305	1216	1216
Total cold run time: 266027 ms
Total hot run time: 180121 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 27.2 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit d66174e642ac285a0d40cc2eacd703ec27b7930a, data reload: false

query1	0.06	0.05	0.05
query2	0.10	0.05	0.04
query3	0.26	0.09	0.08
query4	1.62	0.12	0.10
query5	0.26	0.24	0.26
query6	1.15	0.63	0.63
query7	0.04	0.03	0.03
query8	0.06	0.04	0.04
query9	0.58	0.51	0.51
query10	0.56	0.57	0.55
query11	0.16	0.11	0.14
query12	0.14	0.12	0.12
query13	0.62	0.59	0.60
query14	0.99	0.99	0.99
query15	0.81	0.78	0.80
query16	0.39	0.40	0.42
query17	1.08	1.03	1.02
query18	0.23	0.21	0.22
query19	1.96	1.85	1.76
query20	0.02	0.01	0.01
query21	15.45	0.31	0.14
query22	4.86	0.05	0.05
query23	16.04	0.31	0.10
query24	1.95	0.34	0.27
query25	0.09	0.08	0.06
query26	0.16	0.14	0.14
query27	0.06	0.05	0.05
query28	3.19	1.22	1.02
query29	12.61	3.99	3.19
query30	0.28	0.14	0.14
query31	2.83	0.64	0.39
query32	3.23	0.56	0.47
query33	3.04	3.01	3.03
query34	17.07	5.14	4.51
query35	4.57	4.57	4.56
query36	0.66	0.51	0.50
query37	0.11	0.07	0.07
query38	0.08	0.04	0.04
query39	0.04	0.03	0.02
query40	0.18	0.15	0.13
query41	0.09	0.04	0.03
query42	0.04	0.02	0.02
query43	0.04	0.04	0.03
Total cold run time: 97.76 s
Total hot run time: 27.2 s

@hello-stephen
Copy link
Contributor

FE Regression Coverage Report

Increment line coverage 100.00% (1/1) 🎉
Increment coverage report
Complete coverage report

@morrySnow
Copy link
Contributor

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 35012 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit d66174e642ac285a0d40cc2eacd703ec27b7930a, data reload: false

------ Round 1 ----------------------------------
q1	17605	4300	4097	4097
q2	2004	349	232	232
q3	10200	1299	738	738
q4	10220	896	317	317
q5	7547	2173	1857	1857
q6	185	176	138	138
q7	1007	869	706	706
q8	9360	1385	1127	1127
q9	7019	5385	5270	5270
q10	6825	2395	1953	1953
q11	541	333	307	307
q12	675	727	593	593
q13	17786	3686	3025	3025
q14	308	309	271	271
q15	602	522	516	516
q16	683	692	628	628
q17	686	804	569	569
q18	7646	7071	7039	7039
q19	1129	955	606	606
q20	406	364	252	252
q21	4269	3973	3809	3809
q22	1053	1006	962	962
Total cold run time: 107756 ms
Total hot run time: 35012 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4110	4015	4089	4015
q2	326	415	327	327
q3	2103	2686	2272	2272
q4	1367	1743	1286	1286
q5	4240	4565	4780	4565
q6	230	171	132	132
q7	2081	2008	1785	1785
q8	2649	2569	2519	2519
q9	7457	7517	7464	7464
q10	3127	3242	2809	2809
q11	603	532	500	500
q12	631	758	725	725
q13	3803	3873	3342	3342
q14	315	306	296	296
q15	568	501	556	501
q16	656	683	662	662
q17	1211	1509	1440	1440
q18	7968	7569	7381	7381
q19	920	891	858	858
q20	2007	2054	1895	1895
q21	4653	4333	4166	4166
q22	1112	1034	978	978
Total cold run time: 52137 ms
Total hot run time: 49918 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 178096 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit d66174e642ac285a0d40cc2eacd703ec27b7930a, data reload: false

query5	5205	631	494	494
query6	350	248	239	239
query7	4234	458	283	283
query8	314	261	245	245
query9	8780	2539	2514	2514
query10	543	386	335	335
query11	15264	14816	14620	14620
query12	185	120	117	117
query13	1259	531	411	411
query14	6469	3322	2980	2980
query14_1	2870	2922	2845	2845
query15	209	208	191	191
query16	930	478	478	478
query17	1139	723	607	607
query18	2707	456	352	352
query19	253	235	222	222
query20	123	114	113	113
query21	219	136	117	117
query22	3885	4068	3853	3853
query23	16555	16085	15890	15890
query23_1	15942	15999	15981	15981
query24	7366	1652	1232	1232
query24_1	1248	1238	1230	1230
query25	608	509	465	465
query26	1246	277	169	169
query27	2728	466	311	311
query28	4409	2143	2153	2143
query29	818	567	468	468
query30	317	245	216	216
query31	854	714	643	643
query32	82	77	69	69
query33	564	354	308	308
query34	906	896	551	551
query35	857	818	721	721
query36	862	899	825	825
query37	137	99	81	81
query38	2822	2880	2822	2822
query39	764	749	737	737
query39_1	694	709	707	707
query40	229	138	124	124
query41	65	63	64	63
query42	108	103	103	103
query43	408	432	390	390
query44	1294	741	738	738
query45	192	189	182	182
query46	879	987	614	614
query47	1650	1695	1628	1628
query48	315	325	258	258
query49	623	437	353	353
query50	650	300	220	220
query51	3893	3858	3854	3854
query52	106	108	97	97
query53	317	358	287	287
query54	288	262	262	262
query55	80	77	82	77
query56	307	312	334	312
query57	1124	1140	1069	1069
query58	278	255	251	251
query59	2422	2514	2430	2430
query60	308	313	285	285
query61	164	164	156	156
query62	695	670	624	624
query63	333	295	299	295
query64	4986	1340	1049	1049
query65	4034	3964	3922	3922
query66	1378	457	320	320
query67	15128	15029	14737	14737
query68	8503	987	728	728
query69	495	346	307	307
query70	1077	980	1005	980
query71	386	319	286	286
query72	6023	4751	4808	4751
query73	679	600	313	313
query74	8677	8645	8620	8620
query75	3184	3136	2768	2768
query76	4044	1143	744	744
query77	629	401	291	291
query78	9325	9405	8849	8849
query79	1631	872	628	628
query80	689	660	551	551
query81	518	270	239	239
query82	492	129	101	101
query83	285	265	239	239
query84	262	117	95	95
query85	931	524	476	476
query86	386	286	281	281
query87	3044	3045	2982	2982
query88	4340	2256	2241	2241
query89	464	420	399	399
query90	2159	161	155	155
query91	176	167	145	145
query92	93	66	65	65
query93	1687	898	565	565
query94	492	294	270	270
query95	558	384	312	312
query96	591	469	204	204
query97	2283	2287	2201	2201
query98	215	199	206	199
query99	1313	1317	1198	1198
Total cold run time: 262706 ms
Total hot run time: 178096 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 27.27 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit d66174e642ac285a0d40cc2eacd703ec27b7930a, data reload: false

query1	0.06	0.05	0.05
query2	0.09	0.06	0.05
query3	0.26	0.09	0.09
query4	1.62	0.10	0.11
query5	0.27	0.25	0.26
query6	1.17	0.65	0.64
query7	0.03	0.02	0.02
query8	0.05	0.04	0.04
query9	0.59	0.50	0.52
query10	0.57	0.55	0.56
query11	0.16	0.11	0.11
query12	0.14	0.13	0.11
query13	0.62	0.61	0.62
query14	1.00	0.98	1.00
query15	0.83	0.79	0.81
query16	0.43	0.40	0.43
query17	1.06	1.01	1.05
query18	0.23	0.22	0.22
query19	1.93	1.76	1.87
query20	0.02	0.01	0.02
query21	15.44	0.31	0.14
query22	4.75	0.05	0.05
query23	16.24	0.28	0.10
query24	0.97	0.26	0.59
query25	0.08	0.05	0.05
query26	0.14	0.13	0.13
query27	0.07	0.06	0.05
query28	3.75	1.23	1.03
query29	12.64	4.14	3.31
query30	0.28	0.14	0.12
query31	2.82	0.62	0.40
query32	3.23	0.56	0.45
query33	3.00	3.01	3.08
query34	16.84	5.22	4.51
query35	4.49	4.52	4.54
query36	0.66	0.50	0.49
query37	0.12	0.07	0.06
query38	0.07	0.05	0.04
query39	0.05	0.03	0.04
query40	0.18	0.15	0.14
query41	0.09	0.04	0.03
query42	0.04	0.04	0.03
query43	0.05	0.04	0.03
Total cold run time: 97.13 s
Total hot run time: 27.27 s

@hello-stephen
Copy link
Contributor

FE Regression Coverage Report

Increment line coverage 100.00% (1/1) 🎉
Increment coverage report
Complete coverage report

1 similar comment
@hello-stephen
Copy link
Contributor

FE Regression Coverage Report

Increment line coverage 100.00% (1/1) 🎉
Increment coverage report
Complete coverage report

@englefly
Copy link
Contributor Author

run feut

@englefly
Copy link
Contributor Author

run nonConcurrent

@hello-stephen
Copy link
Contributor

FE UT Coverage Report

Increment line coverage 100.00% (1/1) 🎉
Increment coverage report
Complete coverage report

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Jan 6, 2026
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 6, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2026

PR approved by at least one committer and no changes requested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants