Skip to content

[Improvement](function) optimize trivial function deserialize_and_merge_vec #58882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
BiteTheDDDDt merged 4 commits into from
Dec 29, 2025
Merged

[Improvement](function) optimize trivial function deserialize_and_merge_vec #58882

BiteTheDDDDt merged 4 commits into from
Dec 29, 2025

Conversation

@BiteTheDDDDt
Copy link
Contributor

@BiteTheDDDDt BiteTheDDDDt commented Dec 9, 2025 •
edited
Loading

What problem does this PR solve?

SELECT
  max(csales) tpcds_cmax
FROM
  (
    SELECT
      c_customer_sk,
      sum((ss_quantity * ss_sales_price)) csales
    FROM
      store_sales,
      customer,
      date_dim
    WHERE
      (ss_customer_sk = c_customer_sk)
      AND (ss_sold_date_sk = d_date_sk)
      AND (
        d_year IN (
          2000,
          (2000 + 1),
          (2000 + 2),
          (2000 + 3)
        )
      )
    GROUP BY
      c_customer_sk
  ) x;

DeserializeAndMergeTime
202123088 row
avg old d4f6f5: 1min25sec
sum old d4f6f5: 1min9sec
avg new: 45sec157ms
sum new: 36sec84ms

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@BiteTheDDDDt
Copy link
Contributor Author

BiteTheDDDDt commented Dec 9, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Dec 9, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@hello-stephen
Copy link
Contributor

hello-stephen commented Dec 9, 2025

BE UT Coverage Report

Increment line coverage 36.36% (32/88) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 53.36% (18716/35072)
Line Coverage 39.07% (173049/442959)
Region Coverage 33.76% (134301/397766)
Branch Coverage 34.66% (57691/166444)

@hello-stephen
Copy link
Contributor

hello-stephen commented Dec 9, 2025

BE Regression && UT Coverage Report

Increment line coverage 62.50% (55/88) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 72.24% (24831/34374)
Line Coverage 58.96% (260905/442481)
Region Coverage 53.98% (217263/402489)
Branch Coverage 55.47% (92805/167319)

@BiteTheDDDDt
Copy link
Contributor Author

BiteTheDDDDt commented Dec 10, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Dec 10, 2025

BE UT Coverage Report

Increment line coverage 36.36% (32/88) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 53.36% (18716/35072)
Line Coverage 39.06% (173037/442959)
Region Coverage 33.74% (134215/397766)
Branch Coverage 34.65% (57680/166444)

@hello-stephen
Copy link
Contributor

hello-stephen commented Dec 10, 2025

BE Regression && UT Coverage Report

Increment line coverage 62.50% (55/88) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 72.33% (24863/34374)
Line Coverage 59.07% (261382/442483)
Region Coverage 53.91% (216974/402489)
Branch Coverage 55.54% (92931/167319)

@BiteTheDDDDt
Copy link
Contributor Author

BiteTheDDDDt commented Dec 10, 2025

run buildall

@BiteTheDDDDt
Copy link
Contributor Author

BiteTheDDDDt commented Dec 11, 2025

run buildall

@BiteTheDDDDt BiteTheDDDDt changed the title optimize trivial function deserialize_and_merge_vec [Improvement](function) optimize trivial function deserialize_and_merge_vec Dec 11, 2025
@BiteTheDDDDt
Copy link
Contributor Author

BiteTheDDDDt commented Dec 11, 2025

run buildall

@BiteTheDDDDt
Copy link
Contributor Author

BiteTheDDDDt commented Dec 12, 2025

run buildall

@BiteTheDDDDt
optimize trivial function deserialize_and_merge_vec
30b3499 
fix

fix

fix

fix

update

update

fix

update

fix
@BiteTheDDDDt
Copy link
Contributor Author

BiteTheDDDDt commented Dec 12, 2025

run buildall

@BiteTheDDDDt
Copy link
Contributor Author

BiteTheDDDDt commented Dec 12, 2025

run buildall

@BiteTheDDDDt
Copy link
Contributor Author

BiteTheDDDDt commented Dec 13, 2025

run buildall

1 similar comment
@BiteTheDDDDt
Copy link
Contributor Author

BiteTheDDDDt commented Dec 25, 2025

run buildall

HappenLee
HappenLee previously approved these changes Dec 25, 2025
View reviewed changes
Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 25, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 25, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 25, 2025

PR approved by anyone and no changes requested.

@BiteTheDDDDt
Copy link
Contributor Author

BiteTheDDDDt commented Dec 26, 2025

run buildallrun buildall

@BiteTheDDDDt
Copy link
Contributor Author

BiteTheDDDDt commented Dec 26, 2025

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Dec 26, 2025
@hello-stephen
Copy link
Contributor

hello-stephen commented Dec 26, 2025

BE Regression && UT Coverage Report

Increment line coverage 47.56% (39/82) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 72.19% (25047/34698)
Line Coverage 58.89% (262958/446530)
Region Coverage 53.78% (218457/406195)
Branch Coverage 55.29% (93737/169525)

HappenLee
HappenLee approved these changes Dec 29, 2025
View reviewed changes
Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 29, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 29, 2025

PR approved by at least one committer and no changes requested.

mrhhsg
mrhhsg approved these changes Dec 29, 2025
View reviewed changes
Copy link
Member

@mrhhsg mrhhsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@BiteTheDDDDt BiteTheDDDDt merged commit 2823d11 into apache:master Dec 29, 2025
27 of 29 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 29, 2025
@BiteTheDDDDt
[Improvement](function) optimize trivial function deserialize_and_mer…
546aafd 
…ge_vec (#58882)

### What problem does this PR solve?
```sql
SELECT
  max(csales) tpcds_cmax
FROM
  (
    SELECT
      c_customer_sk,
      sum((ss_quantity * ss_sales_price)) csales
    FROM
      store_sales,
      customer,
      date_dim
    WHERE
      (ss_customer_sk = c_customer_sk)
      AND (ss_sold_date_sk = d_date_sk)
      AND (
        d_year IN (
          2000,
          (2000 + 1),
          (2000 + 2),
          (2000 + 3)
        )
      )
    GROUP BY
      c_customer_sk
  ) x;
```
DeserializeAndMergeTime
202123088 row
avg old d4f6f5: 1min25sec
sum old d4f6f5: 1min9sec
avg new: 45sec157ms
sum new: 36sec84ms
@github-actions github-actions bot mentioned this pull request Dec 29, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrhhsg mrhhsg mrhhsg approved these changes

@HappenLee HappenLee HappenLee approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/4.0.x reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@BiteTheDDDDt @hello-stephen @mrhhsg @HappenLee