[fix](pkfk) Fix drop table not drop constraint related info #58958
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
Contributor
FE UT Coverage ReportIncrement line coverage |
Contributor
FE Regression Coverage ReportIncrement line coverage |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 35291 ms |
TPC-DS: Total hot run time: 178392 ms |
ClickBench: Total hot run time: 27.53 s |
Contributor
FE Regression Coverage ReportIncrement line coverage |
feiniaofeiafei
force-pushed
the
fix_pkuk_drop_table
branch
from
fc47c08 to
7a987c9
Compare
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 35887 ms |
TPC-DS: Total hot run time: 178303 ms |
ClickBench: Total hot run time: 28.06 s |
Contributor
FE Regression Coverage ReportIncrement line coverage |
Contributor
Author
|
run external |
feiniaofeiafei
force-pushed
the
fix_pkuk_drop_table
branch
from
7a987c9 to
0b23082
Compare
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 36770 ms |
TPC-DS: Total hot run time: 179138 ms |
ClickBench: Total hot run time: 27.65 s |
morrySnow
approved these changes
Dec 19, 2025
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
Contributor
|
PR approved by anyone and no changes requested. |
924060929
approved these changes
Dec 19, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Dec 19, 2025
Problem Summary: Create two tables, t1 and t2. Create a primary key on table t1 and a foreign key on table t2 referencing t1 primary key. Then drop table t2, and then try to delete the primary key on t1. doris will report error: errCode = 2, detailMessage = Can not find table XXXX in constraint. This is because the `foreignTables` metadata in the `PrimaryKeyConstraint` was not updated when the foreign key table was dropped. `foreignTables` stores the table IDs of the foreign key tables that reference the primary key. When dropping the foreign key table or drop the foreign key, the corresponding entries in `foreignTables` should also be removed.
feiniaofeiafei
added a commit
to feiniaofeiafei/doris
that referenced
this pull request
Dec 22, 2025
…8958) Problem Summary: Create two tables, t1 and t2. Create a primary key on table t1 and a foreign key on table t2 referencing t1 primary key. Then drop table t2, and then try to delete the primary key on t1. doris will report error: errCode = 2, detailMessage = Can not find table XXXX in constraint. This is because the `foreignTables` metadata in the `PrimaryKeyConstraint` was not updated when the foreign key table was dropped. `foreignTables` stores the table IDs of the foreign key tables that reference the primary key. When dropping the foreign key table or drop the foreign key, the corresponding entries in `foreignTables` should also be removed.
morrySnow
pushed a commit
that referenced
this pull request
Dec 22, 2025
feiniaofeiafei
added a commit
to feiniaofeiafei/doris
that referenced
this pull request
Dec 26, 2025
…8958) Problem Summary: Create two tables, t1 and t2. Create a primary key on table t1 and a foreign key on table t2 referencing t1 primary key. Then drop table t2, and then try to delete the primary key on t1. doris will report error: errCode = 2, detailMessage = Can not find table XXXX in constraint. This is because the `foreignTables` metadata in the `PrimaryKeyConstraint` was not updated when the foreign key table was dropped. `foreignTables` stores the table IDs of the foreign key tables that reference the primary key. When dropping the foreign key table or drop the foreign key, the corresponding entries in `foreignTables` should also be removed.
zclllyybb
pushed a commit
that referenced
this pull request
Dec 26, 2025
1.add var agg_shuffle_use_parent_key, default value is true, when set false, can make agg shuffle by all gby key instead of parent shuffle key. 2.pick pkfk drop fix pr #58958
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Create two tables, t1 and t2. Create a primary key on table t1 and a foreign key on table t2 referencing t1 primary key. Then drop table t2, and then try to delete the primary key on t1.
doris will report error:
errCode = 2, detailMessage = Can not find table XXXX in constraint.This is because the
foreignTablesmetadata in thePrimaryKeyConstraintwas not updated when the foreign key table was dropped.foreignTablesstores the table IDs of the foreign key tables that reference the primary key. When dropping the foreign key table or drop the foreign key, the corresponding entries inforeignTablesshould also be removed.Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)